abort on eror

Author: ligurio

luzer/tests/CMakeLists.txt

@@ -14,6 +14,14 @@ make_lua_path(LUA_PATH
 
 if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
   SetClangLibPath("libclang_rt.asan_osx_dynamic.dylib" ASAN_LIBRARY_PATH)
+  # By default, `abort_on_error` is set to 0 on Linux (disabled),
+  # but on macOS it is set to 1 (enabled) by default. When
+  # `abort_on_error` is enabled, the AddressSanitizer calls
+  # `abort()` instead of `_exit()` after printing the error report
+  # and CTest considers such tests to be failed.
+  string(JOIN ":" ASAN_OPTIONS
+    abort_on_error=0
+  )
 endif()
 
 add_test(
@@ -238,7 +246,7 @@ string(JOIN ";" TEST_ENVIRONMENT
   LD_PRELOAD=${ASAN_DSO_PATH}
   LIB_NAME=luac_asan
   ERR_INJECTION=HEAP_BUFFER_OVERFLOW
-  ASAN_OPTIONS=abort_on_error=0
+  ASAN_OPTIONS=${ASAN_OPTIONS}
 )
 generate_luac_test(luzer_luac_asan_heap_buffer_overflow
   "${TEST_ENVIRONMENT}"
@@ -249,7 +257,7 @@ string(JOIN ";" TEST_ENVIRONMENT
   LD_PRELOAD=${ASAN_DSO_PATH}
   LIB_NAME=luac_asan
   ERR_INJECTION=STACK_BUFFER_OVERFLOW
-  ASAN_OPTIONS=abort_on_error=0
+  ASAN_OPTIONS=${ASAN_OPTIONS}
 )
 generate_luac_test(luzer_luac_asan_stack_buffer_overflow
   "${TEST_ENVIRONMENT}"
@@ -260,7 +268,7 @@ string(JOIN ";" TEST_ENVIRONMENT
   LD_PRELOAD=${ASAN_DSO_PATH}
   LIB_NAME=luac_asan
   ERR_INJECTION=DYNAMIC_STACK_BUFFER_OVERFLOW
-  ASAN_OPTIONS=abort_on_error=0
+  ASAN_OPTIONS=${ASAN_OPTIONS}
 )
 generate_luac_test(luzer_luac_asan_dynamic_stack_buffer_overflow
   "${TEST_ENVIRONMENT}"
@@ -271,7 +279,7 @@ string(JOIN ";" TEST_ENVIRONMENT
   LD_PRELOAD=${ASAN_DSO_PATH}
   LIB_NAME=luac_asan
   ERR_INJECTION=GLOBAL_BUFFER_OVERFLOW
-  ASAN_OPTIONS=abort_on_error=0
+  ASAN_OPTIONS=${ASAN_OPTIONS}
 )
 generate_luac_test(luzer_luac_asan_global_buffer_overflow
   "${TEST_ENVIRONMENT}"
@@ -282,7 +290,7 @@ string(JOIN ";" TEST_ENVIRONMENT
   LD_PRELOAD=${ASAN_DSO_PATH}
   LIB_NAME=luac_asan
   ERR_INJECTION=MEMSET_BUFFER_OVERFLOW
-  ASAN_OPTIONS=abort_on_error=0
+  ASAN_OPTIONS=${ASAN_OPTIONS}
 )
 generate_luac_test(luzer_luac_asan_memset_buffer_overflow
   "${TEST_ENVIRONMENT}"
@@ -293,7 +301,7 @@ string(JOIN ";" TEST_ENVIRONMENT
   LD_PRELOAD=${ASAN_DSO_PATH}
   LIB_NAME=luac_asan
   ERR_INJECTION=MEMCPY_BUFFER_OVERFLOW
-  ASAN_OPTIONS=abort_on_error=0
+  ASAN_OPTIONS=${ASAN_OPTIONS}
 )
 generate_luac_test(luzer_luac_asan_memcpy_buffer_overflow
   "${TEST_ENVIRONMENT}"
@@ -383,7 +391,7 @@ if (LUA_HAS_JIT)
     LD_PRELOAD=${ASAN_DSO_PATH}
     FFI_LIB_NAME=testlib_asan${CMAKE_SHARED_LIBRARY_SUFFIX}
     ERR_INJECTION=HEAP_BUFFER_OVERFLOW
-    ASAN_OPTIONS=abort_on_error=0
+    ASAN_OPTIONS=${ASAN_OPTIONS}
   )
   generate_ffi_test(luzer_ffi_asan_heap_overflow
     "${TEST_ENVIRONMENT}"
@@ -394,7 +402,7 @@ if (LUA_HAS_JIT)
     LD_PRELOAD=${UBSAN_DSO_PATH}
     FFI_LIB_NAME=testlib_ubsan${CMAKE_SHARED_LIBRARY_SUFFIX}
     ERR_INJECTION=NULL_POINTER_DEREF
-    ASAN_OPTIONS=abort_on_error=0
+    ASAN_OPTIONS=${ASAN_OPTIONS}
   )
   generate_ffi_test(luzer_ffi_ubsan_null_pointer_deref
     "${TEST_ENVIRONMENT}"