fix: skip conversational headings in content fallback and add missing preamble patterns

Author: marian2js

apps/desktop/src/features/dashboard/lib/clean-artifact-title.test.ts

@@ -312,3 +312,61 @@ void test("cleanArtifactTitle: extracts heading for 'Based on' title with conten
     "Top Competitors Analysis",
   );
 });
+
+// ---------------------------------------------------------------------------
+// "Saved " and "Short answer" preamble detection (task 0021)
+// ---------------------------------------------------------------------------
+
+void test("isConversationalTitle: detects 'Saved ' preamble", () => {
+  assert.ok(isConversationalTitle("Saved the audit here:"));
+});
+
+void test("isConversationalTitle: detects 'Short answer' preamble", () => {
+  assert.ok(isConversationalTitle("Short answer: the real competitive set"));
+});
+
+void test("cleanArtifactTitle: falls back to type label for 'Saved ' preamble", () => {
+  assert.equal(
+    cleanArtifactTitle({
+      title: "Saved the audit here:",
+      type: "strategy_note",
+    }),
+    "Strategy Note",
+  );
+});
+
+void test("cleanArtifactTitle: falls back to type label for 'Short answer' preamble", () => {
+  assert.equal(
+    cleanArtifactTitle({
+      title: "Short answer: the real competitive set",
+      type: "matrix",
+    }),
+    "Matrix",
+  );
+});
+
+// ---------------------------------------------------------------------------
+// Content heading fallback skips conversational headings (task 0021)
+// ---------------------------------------------------------------------------
+
+void test("cleanArtifactTitle: skips conversational content heading and uses next non-conversational heading", () => {
+  assert.equal(
+    cleanArtifactTitle({
+      title: "I still don't have the actual positioning thread 130",
+      type: "page_outline",
+      content: "## I'll start with the overview\n\nSome text\n\n## Positioning Page Outline\n\nDetails...",
+    }),
+    "Positioning Page Outline",
+  );
+});
+
+void test("cleanArtifactTitle: falls back to type label when all content headings are conversational", () => {
+  assert.equal(
+    cleanArtifactTitle({
+      title: "I still don't have the actual positioning thread",
+      type: "strategy_note",
+      content: "## I'll start with the overview\n\nSome text\n\n## Here is what I found\n\nMore text",
+    }),
+    "Strategy Note",
+  );
+});

apps/desktop/src/features/dashboard/lib/clean-artifact-title.ts

@@ -7,7 +7,7 @@ import { normalizeQuotes } from "./normalize-quotes";
  * appear as an artifact title. Case-insensitive.
  */
 export const CONVERSATIONAL_PATTERN =
-  /^(I |I'm |I'll |I've |I don't|I can't|I can |I still|I checked|Got it|Let me|Here |Here'|Sure|OK |Okay|Well |So |Hmm|Based on |According to |After reviewing |After analyzing |Looking at |From the |From my |Given |Pulling |Checking |Reviewing |Analyzing |To help |In order to |For this |For your |As requested|Absolutely|Assuming )/i;
+  /^(I |I'm |I'll |I've |I don't|I can't|I can |I still|I checked|Got it|Let me|Here |Here'|Sure|OK |Okay|Well |So |Hmm|Based on |According to |After reviewing |After analyzing |Looking at |From the |From my |Given |Pulling |Checking |Reviewing |Analyzing |To help |In order to |For this |For your |As requested|Absolutely|Assuming |Saved |Short answer)/i;
 
 /**
  * Returns true if the given title looks like AI conversational preamble
@@ -31,11 +31,15 @@ export function cleanArtifactTitle(
     return stripped;
   }
 
-  // Try to extract the first markdown heading from content
+  // Try to extract the first non-conversational markdown heading from content
   if (artifact.content) {
-    const headingMatch = artifact.content.match(/^#{1,6}\s+(.+)$/m);
-    if (headingMatch) {
-      return stripMarkdown(headingMatch[1].trim());
+    const headingRegex = /^#{1,6}\s+(.+)$/gm;
+    let headingMatch: RegExpExecArray | null;
+    while ((headingMatch = headingRegex.exec(artifact.content)) !== null) {
+      const candidate = stripMarkdown(headingMatch[1].trim());
+      if (!isConversationalTitle(candidate)) {
+        return candidate;
+      }
     }
   }
 

packages/sidecar/src/artifact-extractor/title-cleaner.ts

@@ -3,7 +3,7 @@
  * appear as artifact titles. Case-insensitive, anchored to start.
  */
 const CONVERSATIONAL_PATTERN =
-  /^(I |I'm |I'll |I've |I don't|I can't|I can |I still|I checked|Got it|Let me|Here |Here'|Sure|OK |Okay|Well |So |Hmm|Based on |According to |After reviewing |After analyzing |Looking at |From the |From my |Given |Pulling |Checking |Reviewing |Analyzing |To help |In order to |For this |For your |As requested|Absolutely|Assuming )/i;
+  /^(I |I'm |I'll |I've |I don't|I can't|I can |I still|I checked|Got it|Let me|Here |Here'|Sure|OK |Okay|Well |So |Hmm|Based on |According to |After reviewing |After analyzing |Looking at |From the |From my |Given |Pulling |Checking |Reviewing |Analyzing |To help |In order to |For this |For your |As requested|Absolutely|Assuming |Saved |Short answer)/i;
 
 /**
  * Normalizes Unicode smart/curly quotes to ASCII equivalents

test/sidecar/title-cleaner.test.ts

@@ -161,3 +161,30 @@ More analysis below...`;
     ).toBe("Competitor Positioning Matrix");
   });
 });
+
+// ---------------------------------------------------------------------------
+// "Saved " and "Short answer" preamble detection (task 0021)
+// ---------------------------------------------------------------------------
+describe("isConversationalTitle — Saved / Short answer patterns", () => {
+  it("detects 'Saved ' preamble", () => {
+    expect(isConversationalTitle("Saved the audit here:")).toBe(true);
+  });
+
+  it("detects 'Short answer' preamble", () => {
+    expect(isConversationalTitle("Short answer: the real competitive set")).toBe(true);
+  });
+});
+
+describe("cleanSectionTitle — Saved / Short answer fallback", () => {
+  it("falls back to type label for 'Saved ' preamble without content headings", () => {
+    expect(
+      cleanSectionTitle("Saved the audit here:", "Just plain text.", "strategy_note"),
+    ).toBe("Strategy Note");
+  });
+
+  it("falls back to type label for 'Short answer' preamble without content headings", () => {
+    expect(
+      cleanSectionTitle("Short answer: the real competitive set", "Plain text.", "matrix"),
+    ).toBe("Matrix");
+  });
+});

test/ui/clean-artifact-title.test.ts

@@ -79,6 +79,22 @@ describe("clean-artifact-title utility", () => {
     expect(src).toMatch(/I can /);
   });
 
+  it("detects 'Saved ' preamble pattern", () => {
+    const src = readFileSync(utilPath, "utf-8");
+    expect(src).toMatch(/Saved /);
+  });
+
+  it("detects 'Short answer' preamble pattern", () => {
+    const src = readFileSync(utilPath, "utf-8");
+    expect(src).toMatch(/Short answer/);
+  });
+
+  it("content heading fallback loops and skips conversational headings", () => {
+    const src = readFileSync(utilPath, "utf-8");
+    // Should use a while loop or similar iteration over headings, not just the first match
+    expect(src).toMatch(/while/);
+  });
+
   it("desktop CONVERSATIONAL_PATTERN matches sidecar patterns", () => {
     const src = readFileSync(utilPath, "utf-8");
     const sidecarSrc = readFileSync(