fix: remove unused Insecure field incorrectly assigned KeycloackEnabl…#452
Open
Priyanshubhartistm wants to merge 1 commit into
Open
Conversation
Priyanshubhartistm
requested review from
Harsh4902,
lbroudoux and
yada
as code owners
…e value The Insecure field in microcksClient was being assigned from configCtx.Server.KeycloackEnable (a Keycloak auth flag) which is semantically unrelated to TLS insecurity. Since the Insecure field was never read anywhere in the codebase after assignment, it was effectively dead code. This commit removes both the unused Insecure field from the microcksClient struct and its incorrect assignment in NewClient. The InsecureTLS field already correctly handles TLS skip-verify behavior via configCtx.Server.InsecureTLS. Fixes microcks#434 Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
Priyanshubhartistm
force-pushed
the
fix/remove-insecure-field-incorrect-assignment
branch
from
d799248 to
2229042
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pkg/connectors/microcks_client.go, theNewClientfunction incorrectly assignedconfigCtx.Server.KeycloakEnable(a boolean flag for Keycloak authentication) to thec.Insecurefield (which semantically represents TLS insecurity). This meant that when Keycloak was enabled,c.Insecurewas set totrue- a completely unrelated concern.Insecurefield from themicrocksClientstruct and its incorrect assignment (c.Insecure = configCtx.Server.KeycloakEnable) inNewClient.Insecurefield was never read anywhere in the codebase after being assigned, making it dead code. TheInsecureTLSfield already correctly handles TLS skip-verify behavior viaconfigCtx.Server.InsecureTLS, so no functionality is lost.Related issue(s)
Fixes #434