Match .well-known/smart-configuration capabilities section to capabilities endpoint (#5427)

Refs AB#185285

Author: feordin

src/Microsoft.Health.Fhir.Core/Features/Conformance/GetSmartConfigurationHandler.cs

@@ -5,6 +5,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using System.Net;
 using System.Threading;
 using System.Threading.Tasks;
@@ -62,13 +63,17 @@ public async Task<GetSmartConfigurationResponse> Handle(GetSmartConfigurationReq
                         (authorizationEndpoint, tokenEndpoint) = await _oidcDiscoveryService.ResolveEndpointsAsync(baseEndpoint, cancellationToken);
                     }
 
-                    ICollection<string> capabilities = new List<string>
+                    ICollection<string> capabilities = new List<string>(
+                        Constants.SmartCapabilityClients
+                            .Concat(Constants.SmartCapabilityAdditional)
+                            .Concat(Constants.SmartCapabilityLaunches)
+                            .Concat(Constants.SmartCapabilityPermissions)
+                            .Concat(Constants.SmartCapabilitySSOs));
+
+                    if (!string.IsNullOrEmpty(_smartIdentityProviderConfiguration.Authority))
                     {
-                        "sso-openid-connect",
-                        "permission-offline",
-                        "permission-patient",
-                        "permission-user",
-                    };
+                        ((List<string>)capabilities).AddRange(Constants.SmartCapabilityThirdPartyContexts);
+                    }
 
                     // Add SMART v2 scope support - these are the core scopes supported natively by the FHIR service
                     ICollection<string> scopesSupported = new List<string>

src/Microsoft.Health.Fhir.Shared.Core.UnitTests/Features/Conformance/GetSmartConfigurationHandlerTests.cs

@@ -5,6 +5,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using System.Net;
 using System.Threading;
 using System.Threading.Tasks;
@@ -26,6 +27,16 @@ namespace Microsoft.Health.Fhir.Core.UnitTests.Features.Conformance
     [Trait(Traits.Category, Categories.Conformance)]
     public class GetSmartConfigurationHandlerTests
     {
+        private static readonly List<string> ExpectedBaseCapabilities = new List<string>(
+            Constants.SmartCapabilityClients
+                .Concat(Constants.SmartCapabilityAdditional)
+                .Concat(Constants.SmartCapabilityLaunches)
+                .Concat(Constants.SmartCapabilityPermissions)
+                .Concat(Constants.SmartCapabilitySSOs));
+
+        private static readonly List<string> ExpectedThirdPartyCapabilities = new List<string>(
+            ExpectedBaseCapabilities.Concat(Constants.SmartCapabilityThirdPartyContexts));
+
         private static GetSmartConfigurationHandler CreateHandler(
             SecurityConfiguration securityConfiguration,
             SmartIdentityProviderConfiguration smartIdpConfig = null,
@@ -80,13 +91,7 @@ public async Task GivenASmartConfigurationHandler_WhenSecurityConfigurationEnabl
 
             Assert.Equal(baseEndpoint + "/oauth2/v2.0/authorize", response.AuthorizationEndpoint.ToString());
             Assert.Equal(baseEndpoint + "/oauth2/v2.0/token", response.TokenEndpoint.ToString());
-            Assert.Equal(response.Capabilities, new List<string>
-                    {
-                        "sso-openid-connect",
-                        "permission-offline",
-                        "permission-patient",
-                        "permission-user",
-                    });
+            Assert.Equal(ExpectedBaseCapabilities, response.Capabilities);
 
             // Verify SMART v2 scopes are included
             Assert.NotNull(response.ScopesSupported);
@@ -172,13 +177,7 @@ public async Task GivenASmartConfigurationHandler_WhenAadSmartOnFhirProxyEnabled
 
             Assert.Equal("https://fhir.example.com/AadSmartOnFhirProxy/authorize", response.AuthorizationEndpoint.ToString());
             Assert.Equal("https://fhir.example.com/AadSmartOnFhirProxy/token", response.TokenEndpoint.ToString());
-            Assert.Equal(response.Capabilities, new List<string>
-                    {
-                        "sso-openid-connect",
-                        "permission-offline",
-                        "permission-patient",
-                        "permission-user",
-                    });
+            Assert.Equal(ExpectedBaseCapabilities, response.Capabilities);
 
             // Verify SMART v2 scopes are included
             Assert.NotNull(response.ScopesSupported);
@@ -206,13 +205,7 @@ public async Task GivenASmartConfigurationHandler_WhenAadSmartOnFhirProxyDisable
 
             Assert.Equal(authority + "/oauth2/v2.0/authorize", response.AuthorizationEndpoint.ToString());
             Assert.Equal(authority + "/oauth2/v2.0/token", response.TokenEndpoint.ToString());
-            Assert.Equal(response.Capabilities, new List<string>
-                    {
-                        "sso-openid-connect",
-                        "permission-offline",
-                        "permission-patient",
-                        "permission-user",
-                    });
+            Assert.Equal(ExpectedBaseCapabilities, response.Capabilities);
 
             // Verify SMART v2 scopes are included
             Assert.NotNull(response.ScopesSupported);
@@ -245,6 +238,15 @@ public async Task GivenASmartConfigurationHandler_When3rdPartyIdpSpecified_ThenC
             var expectedAuthority = !string.IsNullOrEmpty(authority) ? authority.TrimEnd('/') : baseUri;
             Assert.Equal(expectedAuthority + "/oauth2/v2.0/authorize", response.AuthorizationEndpoint.ToString());
             Assert.Equal(expectedAuthority + "/oauth2/v2.0/token", response.TokenEndpoint.ToString());
+
+            if (!string.IsNullOrEmpty(authority))
+            {
+                Assert.Equal(ExpectedThirdPartyCapabilities, response.Capabilities);
+            }
+            else
+            {
+                Assert.Equal(ExpectedBaseCapabilities, response.Capabilities);
+            }
         }
     }
 }