Skip to content

Missing type on array.ย #18

@treytomes

Description

@treytomes

Hi! ๐Ÿ‘‹

Firstly, thanks for your work on this project! ๐Ÿ™‚

Today I used patch-package to patch ml-regression-base@3.0.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/ml-regression-base/src/index.ts b/node_modules/ml-regression-base/src/index.ts
index e33697e..0dca7e9 100644
--- a/node_modules/ml-regression-base/src/index.ts
+++ b/node_modules/ml-regression-base/src/index.ts
@@ -18,13 +18,13 @@ export default class BaseRegression {
     }
   }
 
-  predict(x: number): number;
-  predict(x: NumberArray): number[];
+  // predict(x: number): number;
+  // predict(x: NumberArray): number[];
   predict(x: number | NumberArray) {
     if (typeof x === 'number') {
       return this._predict(x);
     } else if (isAnyArray(x)) {
-      const y = [];
+      const y: number[] = [];
       for (const xVal of x) {
         y.push(this._predict(xVal));
       }

This issue body was partially generated by patch-package.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions