Merge pull request #1276 from mnfst/codebase-3

Remove dead endpoints and unused code

Author: brunobuddy

.changeset/remove-dead-code.md

@@ -0,0 +1,5 @@
+---
+"manifest": patch
+---
+
+Remove dead EmailConfigController, unused API endpoints, and orphaned frontend functions

packages/backend/src/model-prices/model-prices.controller.spec.ts

@@ -8,7 +8,6 @@ describe('ModelPricesController', () => {
   beforeEach(() => {
     mockService = {
       getAll: jest.fn(),
-      triggerSync: jest.fn(),
     } as unknown as jest.Mocked<ModelPricesService>;
     controller = new ModelPricesController(mockService);
   });
@@ -22,14 +21,4 @@ describe('ModelPricesController', () => {
     expect(result).toBe(expected);
     expect(mockService.getAll).toHaveBeenCalledTimes(1);
   });
-
-  it('delegates to service.triggerSync()', async () => {
-    const expected = { updated: 100 };
-    mockService.triggerSync.mockResolvedValue(expected);
-
-    const result = await controller.triggerSync();
-
-    expect(result).toEqual(expected);
-    expect(mockService.triggerSync).toHaveBeenCalledTimes(1);
-  });
 });

packages/backend/src/model-prices/model-prices.controller.ts

@@ -1,4 +1,4 @@
-import { Controller, Get, Post, UseInterceptors } from '@nestjs/common';
+import { Controller, Get, UseInterceptors } from '@nestjs/common';
 import { CacheInterceptor, CacheTTL } from '@nestjs/cache-manager';
 import { ModelPricesService } from './model-prices.service';
 import { MODEL_PRICES_CACHE_TTL_MS } from '../common/constants/cache.constants';
@@ -13,9 +13,4 @@ export class ModelPricesController {
   async getModelPrices() {
     return this.modelPricesService.getAll();
   }
-
-  @Post('model-prices/sync')
-  async triggerSync() {
-    return this.modelPricesService.triggerSync();
-  }
 }

packages/backend/src/model-prices/model-prices.service.spec.ts

@@ -2,17 +2,15 @@ import { ModelPricesService } from './model-prices.service';
 
 describe('ModelPricesService', () => {
   let service: ModelPricesService;
-  let mockPricingCache: { getAll: jest.Mock; reload: jest.Mock };
-  let mockPricingSync: { getLastFetchedAt: jest.Mock; refreshCache: jest.Mock };
+  let mockPricingCache: { getAll: jest.Mock };
+  let mockPricingSync: { getLastFetchedAt: jest.Mock };
 
   beforeEach(() => {
     mockPricingCache = {
       getAll: jest.fn().mockReturnValue([]),
-      reload: jest.fn().mockResolvedValue(undefined),
     };
     mockPricingSync = {
       getLastFetchedAt: jest.fn().mockReturnValue(null),
-      refreshCache: jest.fn().mockResolvedValue(0),
     };
     service = new ModelPricesService(mockPricingCache as never, mockPricingSync as never);
   });
@@ -172,39 +170,4 @@ describe('ModelPricesService', () => {
       expect(result.models[2].validated).toBeUndefined();
     });
   });
-
-  describe('triggerSync', () => {
-    it('should call refreshCache and reload, then return update count', async () => {
-      mockPricingSync.refreshCache.mockResolvedValue(15);
-
-      const result = await service.triggerSync();
-
-      expect(mockPricingSync.refreshCache).toHaveBeenCalledTimes(1);
-      expect(mockPricingCache.reload).toHaveBeenCalledTimes(1);
-      expect(result).toEqual({ updated: 15 });
-    });
-
-    it('should return 0 when no models were updated', async () => {
-      mockPricingSync.refreshCache.mockResolvedValue(0);
-
-      const result = await service.triggerSync();
-
-      expect(result).toEqual({ updated: 0 });
-    });
-
-    it('should reload cache after refreshCache completes', async () => {
-      const callOrder: string[] = [];
-      mockPricingSync.refreshCache.mockImplementation(async () => {
-        callOrder.push('refreshCache');
-        return 5;
-      });
-      mockPricingCache.reload.mockImplementation(async () => {
-        callOrder.push('reload');
-      });
-
-      await service.triggerSync();
-
-      expect(callOrder).toEqual(['refreshCache', 'reload']);
-    });
-  });
 });

packages/backend/src/model-prices/model-prices.service.ts

@@ -27,10 +27,4 @@ export class ModelPricesService {
       lastSyncedAt,
     };
   }
-
-  async triggerSync() {
-    const updated = await this.pricingSync.refreshCache();
-    await this.pricingCache.reload();
-    return { updated };
-  }
 }

packages/backend/src/notifications/dto/email-config.dto.ts

@@ -1,22 +1,17 @@
 import { Module } from '@nestjs/common';
 import { NotificationsController } from './notifications.controller';
-import { EmailConfigController } from './email-config.controller';
 import { NotificationRulesService } from './services/notification-rules.service';
 import { NotificationCronService } from './services/notification-cron.service';
 import { NotificationEmailService } from './services/notification-email.service';
-import { EmailConfigService } from './services/email-config.service';
-import { NotificationEmailAddressService } from './services/notification-email-address.service';
 import { EmailProviderConfigService } from './services/email-provider-config.service';
 import { LimitCheckService } from './services/limit-check.service';
 
 @Module({
-  controllers: [NotificationsController, EmailConfigController],
+  controllers: [NotificationsController],
   providers: [
     NotificationRulesService,
     NotificationCronService,
     NotificationEmailService,
-    EmailConfigService,
-    NotificationEmailAddressService,
     EmailProviderConfigService,
     LimitCheckService,
   ],