Merge pull request #1277 from mnfst/codebase-optim

refactor: create packages/shared to DRY up duplicated code

Author: brunobuddy

.changeset/dry-shared-package.md

@@ -0,0 +1,5 @@
+---
+"manifest": patch
+---
+
+Create packages/shared to centralize duplicated constants, types, and utilities across backend, frontend, and plugin. Moves TIERS, TIER_LABELS, AUTH_TYPES, API_KEY_PREFIX, MODEL_PREFIX_MAP, inferProviderFromModel, ResolveResponse, and subscription-capabilities into a single source of truth.

.github/workflows/ci.yml

@@ -52,6 +52,7 @@ jobs:
           node-version: 22
           cache: npm
       - run: npm ci
+      - run: npm run build --workspace=packages/shared
       - run: npx tsc --noEmit
         working-directory: packages/backend
       - run: npm run build --workspace=packages/backend
@@ -87,6 +88,7 @@ jobs:
           node-version: 22
           cache: npm
       - run: npm ci
+      - run: npm run build --workspace=packages/shared
       - run: npm run build --workspace=packages/backend
       - name: Unit tests (sql.js dialect)
         run: npm test --workspace=packages/backend
@@ -102,6 +104,7 @@ jobs:
           node-version: 22
           cache: npm
       - run: npm ci
+      - run: npm run build --workspace=packages/shared
       - run: npx tsc --noEmit
         working-directory: packages/frontend
       - run: npm test --workspace=packages/frontend -- --coverage
@@ -118,6 +121,26 @@ jobs:
           directory: packages/frontend/coverage
           fail_ci_if_error: false
 
+  shared:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 22
+          cache: npm
+      - run: npm ci
+      - run: npm run build --workspace=packages/shared
+      - run: npm test --workspace=packages/shared -- --coverage --coverageReporters=lcov
+      - name: Upload shared coverage to Codecov
+        if: always()
+        uses: codecov/codecov-action@v5
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          flags: shared
+          directory: packages/shared/coverage
+          fail_ci_if_error: false
+
   plugin:
     runs-on: ubuntu-latest
     steps:
@@ -127,6 +150,7 @@ jobs:
           node-version: 22
           cache: npm
       - run: npm ci
+      - run: npm run build --workspace=packages/shared
       - run: npm test --workspace=packages/openclaw-plugin -- --coverage --coverageReporters=lcov
       - name: Upload plugin coverage to Codecov
         if: always()

codecov.yml

@@ -20,6 +20,9 @@ flags:
   plugin:
     paths:
       - packages/openclaw-plugin/src/
+  shared:
+    paths:
+      - packages/shared/src/
 bundle_analysis:
   warning_threshold: "5%"
   status: "informational"

eslint.config.mjs

@@ -7,7 +7,7 @@ export default [
     ignores: ['**/dist/**', '**/node_modules/**', '**/coverage/**', '**/*.js', '**/*.mjs'],
   },
   {
-    files: ['packages/backend/src/**/*.ts', 'packages/frontend/src/**/*.ts', 'packages/frontend/src/**/*.tsx', 'packages/openclaw-plugin/src/**/*.ts'],
+    files: ['packages/shared/src/**/*.ts', 'packages/backend/src/**/*.ts', 'packages/frontend/src/**/*.ts', 'packages/frontend/src/**/*.tsx', 'packages/openclaw-plugin/src/**/*.ts'],
     languageOptions: {
       parser: tsParser,
       parserOptions: {

package-lock.json

@@ -27,6 +27,7 @@
   ],
   "packageManager": "npm@10.9.2",
   "workspaces": [
+    "packages/shared",
     "packages/frontend",
     "packages/backend",
     "packages/openclaw-plugin"
@@ -39,7 +40,7 @@
     "build:plugin": "npm run build --workspace=packages/openclaw-plugin",
     "publish:plugin": "npm publish --access public --workspace=packages/openclaw-plugin",
     "check:api-prefix": "node scripts/check-api-prefix.js",
-    "lint": "eslint packages/backend/src packages/frontend/src packages/openclaw-plugin/src",
+    "lint": "eslint packages/shared/src packages/backend/src packages/frontend/src packages/openclaw-plugin/src",
     "format": "prettier --write 'packages/*/src/**/*.{ts,tsx,css}'",
     "changeset": "changeset",
     "version-packages": "changeset version && node scripts/sync-plugin-version.js",

package.json

@@ -18,6 +18,7 @@
     "migration:create": "typeorm-ts-node-commonjs migration:create"
   },
   "dependencies": {
+    "manifest-shared": "*",
     "@nestjs/cache-manager": "^3.1.0",
     "@nestjs/common": "^11.0.0",
     "@nestjs/config": "^4.0.0",

packages/backend/package.json

@@ -1 +1 @@
-export const API_KEY_PREFIX = 'mnfst_';
+export { API_KEY_PREFIX } from 'manifest-shared';

packages/backend/src/common/constants/api-key.constants.ts

@@ -1,28 +1 @@
-/**
- * Infer a provider ID from a model name string.
- * Mirrors the frontend logic in services/routing-utils.ts.
- */
-const MODEL_PREFIX_MAP: [RegExp, string][] = [
-  [/^openrouter\//, 'openrouter'],
-  [/^claude-/, 'anthropic'],
-  [/^gpt-|^o[134]-|^o[134] |^chatgpt-/, 'openai'],
-  [/^gemini-/, 'gemini'],
-  [/^deepseek-/, 'deepseek'],
-  [/^grok-/, 'xai'],
-  [/^mistral-|^codestral|^pixtral|^open-mistral/, 'mistral'],
-  [/^kimi-|^moonshot-/, 'moonshot'],
-  [/^minimax-/i, 'minimax'],
-  [/^glm-/, 'zai'],
-  [/^qwen[23]|^qwq-/, 'qwen'],
-  [/^[a-z][\w-]*\//, 'openrouter'],
-];
-
-export function inferProviderFromModel(model: string): string | undefined {
-  if (model.startsWith('custom:')) return 'custom';
-  if (/:/.test(model) && !model.endsWith(':free')) return 'ollama';
-  const lower = model.toLowerCase();
-  for (const [re, id] of MODEL_PREFIX_MAP) {
-    if (re.test(lower)) return id;
-  }
-  return undefined;
-}
+export { MODEL_PREFIX_MAP, inferProviderFromModel } from 'manifest-shared';

packages/backend/src/common/utils/provider-inference.ts

@@ -1,14 +1,7 @@
-import {
-  IsArray,
-  IsIn,
-  IsNotEmpty,
-  IsNumber,
-  IsOptional,
-  ValidateNested,
-} from 'class-validator';
+import { IsArray, IsIn, IsNotEmpty, IsNumber, IsOptional, ValidateNested } from 'class-validator';
 import { Type } from 'class-transformer';
 
-const VALID_TIERS = ['simple', 'standard', 'complex', 'reasoning'] as const;
+import { TIERS } from 'manifest-shared';
 
 class MessageDto {
   @IsNotEmpty()
@@ -38,6 +31,6 @@ export class ResolveRequestDto {
 
   @IsOptional()
   @IsArray()
-  @IsIn(VALID_TIERS, { each: true })
-  recentTiers?: Array<(typeof VALID_TIERS)[number]>;
+  @IsIn(TIERS, { each: true })
+  recentTiers?: Array<(typeof TIERS)[number]>;
 }