Skip to content

Commit 70d8013

Browse files
committed
refactor(builder): use io.Copy(hash, reader) directly
Simplify computeDigestAndSize by copying directly to the sha256 writer instead of using io.TeeReader + io.Discard. hash.Hash already implements io.Writer, making the tee unnecessary. Addresses review feedback on PR #474. Signed-off-by: Zhao Chen <winters.zc@antgroup.com>
1 parent ccb9228 commit 70d8013

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

pkg/backend/build/builder.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,8 +266,7 @@ func (ab *abstractBuilder) computeDigestAndSize(ctx context.Context, mediaType,
266266
wrappedReader := onHash(info.Size(), reader)
267267

268268
hash := sha256.New()
269-
tee := io.TeeReader(wrappedReader, hash)
270-
size, err := io.Copy(io.Discard, tee)
269+
size, err := io.Copy(hash, wrappedReader)
271270
if err != nil {
272271
return reader, "", 0, fmt.Errorf("failed to copy content to hash: %w", err)
273272
}

0 commit comments

Comments
 (0)