refactor: solid connections (@fehmer)#8018
Open
fehmer wants to merge 20 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactor connections/friends UX to Solid + TanStack collections/queries, removing legacy friends/blocked-users DOM logic and snapshot-stored connections.
Changes:
- Add
collections/connections(tanstack/solid-db) +queries/friends(solid-query) as new data sources. - Replace legacy friends page + blocked users table with Solid
DataTablepages/components mounted via<mount>. - Move shared “age” formatting into
utils/date-and-time.tsand update friend indicators to use the new collection.
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/ts/utils/date-and-time.ts | Add shared formatAge() helper for connections UI timestamps. |
| frontend/src/ts/queries/friends.ts | New Solid Query options + invalidation for friends list. |
| frontend/src/ts/pages/friends.ts | Remove legacy friends page implementation. |
| frontend/src/ts/pages/account-settings.ts | Stop legacy blocked-users table wiring in tab updates. |
| frontend/src/ts/elements/account-settings/blocked-user-table.ts | Remove legacy blocked-users table implementation. |
| frontend/src/ts/db.ts | Remove snapshot-level connections + legacy friend/connection helpers. |
| frontend/src/ts/controllers/page-controller.ts | Route friends page through solidPage() + connections loading/invalidation. |
| frontend/src/ts/constants/default-snapshot.ts | Drop connections from snapshot type/default. |
| frontend/src/ts/components/pages/profile/UserDetails.tsx | Switch “add friend”/friend badge logic to connections collection. |
| frontend/src/ts/components/pages/leaderboard/Table.tsx | Use connections collection for “isFriend” rendering. |
| frontend/src/ts/components/pages/connections/PendingRequests.tsx | New Solid pending-requests table + actions (accept/reject/block). |
| frontend/src/ts/components/pages/connections/FriendsPage.tsx | New Solid friends page wrapper (pending + list). |
| frontend/src/ts/components/pages/connections/FriendsList.tsx | New Solid friends list table + add/remove flows. |
| frontend/src/ts/components/pages/account-settings/BlockedUsers.tsx | New Solid blocked-users table + unblock flow. |
| frontend/src/ts/components/mount.tsx | Register new mountable components (friends page, blocked users). |
| frontend/src/ts/components/layout/header/Nav.tsx | Pending-requests bubble driven by connections live query. |
| frontend/src/ts/components/common/UserBadge.tsx | Prevent badge text wrapping via whitespace-nowrap. |
| frontend/src/ts/collections/connections.ts | New connections collection, live queries, optimistic actions, invalidation hooks. |
| frontend/src/styles/media-queries-purple.scss | Remove legacy friends/blocked-users responsive overrides. |
| frontend/src/styles/media-queries-green.scss | Remove legacy friends responsive overrides. |
| frontend/src/styles/media-queries-brown.scss | Remove legacy friends/blocked-users responsive overrides. |
| frontend/src/styles/media-queries-blue.scss | Remove legacy friends responsive overrides. |
| frontend/src/styles/index.scss | Stop importing removed legacy friends.scss. |
| frontend/src/styles/friends.scss | Remove legacy friends page stylesheet. |
| frontend/src/styles/account-settings.scss | Remove legacy blocked-users tab table styling. |
| frontend/src/index.html | Inline friends page mountpoint instead of loading legacy HTML partial. |
| frontend/src/html/pages/friends.html | Remove legacy friends HTML partial. |
| frontend/src/html/pages/account-settings.html | Replace blocked-users HTML with Solid mountpoint. |
Contributor
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.