dx: commits should fail if they do not pass linter

Author: mrdjohnson

.eslintrc.cjs

@@ -24,7 +24,10 @@ module.exports = {
     'import/no-unresolved': 'error',
     'import/no-relative-packages': 'error',
     'import/no-self-import': 'error',
-    'import/newline-after-import': ['error', { count: 1, exactCount: true, considerComments: true }],
+    'import/newline-after-import': [
+      'error',
+      { count: 1, exactCount: true, considerComments: true },
+    ],
     'import/no-duplicates': 'error',
 
     'no-restricted-imports': 'off',
@@ -45,23 +48,27 @@ module.exports = {
     ],
 
     // https://stackoverflow.com/a/64067915
-    "no-unused-vars": "off",
-    "@typescript-eslint/no-unused-vars": [
-      "error",
+    'no-unused-vars': 'off',
+    '@typescript-eslint/no-unused-vars': [
+      'error',
       {
-        "argsIgnorePattern": "^_",
-        "varsIgnorePattern": "^_",
-        "caughtErrorsIgnorePattern": "^_"
-      }
-    ]
+        argsIgnorePattern: '^_',
+        varsIgnorePattern: '^_',
+        caughtErrorsIgnorePattern: '^_',
+      },
+    ],
   },
 
   settings: {
     'import/parsers': {
       '@typescript-eslint/parser': ['.ts', '.tsx'],
     },
     'import/resolver': {
-      typescript: {},
+      typescript: {
+        // always try to resolve types under `<root>@types` directory even it doesn't contain any source code, like `@types/unist`
+        alwaysTryTypes: true,
+        project: './tsconfig.json',
+      },
     },
   },
 }

.husky/pre-commit

@@ -1,2 +1,2 @@
-npx tsc
+yarn lint
 npx lint-staged

environments/firefox/firefox.background.ts

@@ -8,6 +8,6 @@ browser.runtime.onInstalled.addListener(() => {
   console.log('Installed!')
 })
 
-browser.windows.getCurrent({ populate: true }).then((windowInfo) => {
-  let myWindowId = windowInfo.id;
-});
+// browser.windows.getCurrent({ populate: true }).then((windowInfo) => {
+//   let myWindowId = windowInfo.id;
+// });

src/main.tsx

@@ -9,7 +9,7 @@ import App from '~/App'
 import DaisyUiThemeProvider from '~/containers/DaisyUiThemeProvider'
 
 import '~/index.css'
-import StartupSpinner from './icons/StartupSpinner'
+import StartupSpinner from '~/icons/StartupSpinner'
 
 const errorPage = (
   <div className="flex h-screen w-screen items-center justify-center bg-base-100">

src/tests/components/Omnibar.test.tsx

@@ -10,8 +10,8 @@ import OmniBar from '~/components/OmniBar'
 import { settingStore } from '~/core/setting/SettingStore'
 import { chatStore } from '~/core/chat/ChatStore'
 import { focusStore } from '~/core/FocusStore'
-import { connectionStore } from '../../core/connection/ConnectionStore'
-import { setServerResponse } from '../msw'
+import { connectionStore } from '~/core/connection/ConnectionStore'
+import { setServerResponse } from '~/tests/msw'
 
 describe('OmniBar', () => {
   const navigate = vi.fn()

tailwind.config.ts

@@ -1,7 +1,7 @@
 /** @type {import('tailwindcss').Config} */
 
 import { heroui } from '@heroui/react'
-import themes, { synthwave } from 'daisyui/src/theming/themes'
+import themes from 'daisyui/src/theming/themes'
 
 const errorColor = 'oklch(51% 0.17 22.1)'