added DSI, Switch, OLED Board diagrams, Removed .hw gudes, (#1497)

* Added DSI Board diagram

* Added Switch 2

* Fixed error with .pop being run on non 3ds consoles

* Added Switch Board

* Added plates, removed guides (as its no longer used), Removed recomendation for o2ds as its no longer offered by nintendo

* Added OLED Diagram, Made by Emerkt

* Fixed fix some ponctuation, Emerkt

* Fixed formatting

* Adding missing board titles

* Flake vs Wurm

* Update hwtest.hardware.md

* Update plates.hardware.md

---------

Co-authored-by: eip <36315290+eip618@users.noreply.github.com>

Author: Wurmatron

cogs/assistance-cmds/hardware/guides.hardware.md

@@ -10,4 +10,4 @@ Please note: if the console is unmodded, your only option is to run the test usi
 Once this test has completed, any amount of errors above 0 indicates RAM failure. This is currently unfixable barring a complete motherboard replacement. If you need assistance transferring your files to a new console/motherboard, you can ask in  https://discord.com/channels/196618637950451712/196635695958196224 .
 
 *While it's technically possible to replace the RAM, it's very time consuming, requires a donor board, and would likely end up costing more than a replacement board, or a whole new console.*
-*If your console is an Old 2DS or New 2DS XL, it may be worth looking into a replacement from [Nintendo](<https://www.nintendo.com/>)*
+*If your console is a New 2DS XL, it may be worth looking into a replacement from [Nintendo](<https://www.nintendo.com/>)*

cogs/assistance-cmds/hardware/hwtest.hardware.md

@@ -0,0 +1,12 @@
+---
+title: Worn Plates
+help-desc: Notes on replacment plates / shells
+thumbnail-url: https://hacksguidewiki.sfo3.digitaloceanspaces.com/hardwarewiki/Peeling.webp
+aliases: plate,worn
+---
+
+Are your outer plates worn or peeling? 
+We recommend covering them with a shell instead of replacing as replacement covers are of extremely poor quality (peel and scratch easily, usually don't fit properly, brittle, etc). Most 3DS systems have solid color covers, which can be found on AliExpress for cheap.
+- If you really are set on replacing them, we recommend tracking down OEM/Original ones, which you most likely have to salvage from another system.
+- Please note: most of the ones being sold as OEM/Original are also just the 3rd party ones you can find on Aliexpress with large markups.
+- If you are still planning on buying a 3rd party one, be ready with some files, a knife, and resin to correct the poor molding, and place a clear cover over it afterward.

cogs/assistance-cmds/hardware/plates.hardware.md

@@ -60,10 +60,12 @@
     'switch': 'https://www.ifixit.com/Device/Nintendo_Switch',
     'switcholed': 'https://www.ifixit.com/Device/Nintendo_Switch_OLED_Model',
     'switchlite': 'https://www.ifixit.com/Device/Nintendo_Switch_Lite',
-    'joycons': 'https://www.ifixit.com/Device/Joy-Con',
+    'joycon': 'https://www.ifixit.com/Device/Joy-Con',
     'procontroller': 'https://www.ifixit.com/Device/Switch_Pro_Controller',
     'gamewatch': 'https://www.ifixit.com/Device/Game_Watch_Nintendo',
     'gameboylight': 'https://www.ifixit.com/Device/Game_Boy_Light',
+    "joycon2": "https://www.ifixit.com/Device/Nintendo_Switch_2_Joy-Con",
+    "switch2": "https://www.ifixit.com/Device/Nintendo_Switch_2",
     # Sega
     'segacd': 'https://www.ifixit.com/Device/Sega_CD',
     'dreamcast': 'https://www.ifixit.com/Device/Sega_Dreamcast',
@@ -168,9 +170,12 @@
     "hdh": "switchlite",
     "heg": "switcholed",
     "procon": "procontroller",
-    "joycon": "joycons",
+    "joycons": "joycon",
     "wup": "wiiu",
     "rvl": "wii",
+    "bee": "switch2",
+    "s2": "switch2",
+    "joycons2": "joycon2"
 }
 
 boards = {
@@ -183,6 +188,9 @@
     "new3dsxl": "https://hacksguidewiki.sfo3.digitaloceanspaces.com/hardwarewiki/Board-n3dsxl.png",
     "new2dsxl": "https://hacksguidewiki.sfo3.digitaloceanspaces.com/hardwarewiki/Board-n2dsxl.png",
     "ds": "https://hacksguidewiki.sfo3.digitaloceanspaces.com/hardwarewiki/Board-ntr-compressed.png",
+    "dsi": "https://hacksguidewiki.sfo3.digitaloceanspaces.com/hardwarewiki/Board-dsi-compressed.png",
+    "switch": "https://hacksguidewiki.sfo3.digitaloceanspaces.com/hardwarewiki/Board-switch-compressed.png",
+    "switcholed": "https://hacksguidewiki.sfo3.digitaloceanspaces.com/hardwarewiki/OLED_board_diagram_compressed.png"
 }
 
 # Used for board command title
@@ -196,6 +204,9 @@
     "new3dsxl": "\"New\" 3DS XL (2015)",
     "new2dsxl": "\"New\" 2DS XL",
     "ds": "DS (Fat/NTR)",
+    "dsi": "DSI (TWL)",
+    "switch": "Switch (v1/v2)",
+    "switcholed": "Switch OLED"
 }
 
 bits = {
@@ -211,11 +222,24 @@
     "switch": "PH 00, Y00",
     "switchlite": "PH 00, Y00",
     "switcholed": "PH 00, Y00",
-    "joycons": "PH 00, Y00",
+    "joycon": "PH 00, Y00",
     "procontroller": "PH 00, Y00",
+    "joycon2": "PH 0, PH00, Y00"
 }
 
 
+valid_3ds = ['3ds', '3dsxl', 'new3ds', 'new3dsxl', '2ds', 'new2dsxl']
+
+
+def is_3ds(dname):
+    try:
+        if dname in valid_3ds or alias[dname] in valid_3ds:
+            return True
+        return False
+    except:
+        return False
+
+
 class AssistanceHardware(commands.Cog):
     """
     General hardware commands that will mostly be used in the hardware but also other help channels.
@@ -305,6 +329,13 @@ async def pop(self, ctx: KurisuContext, console: str = ""):
         """Fix popping issue for the given console. """
         console = console.lower()
         embed = discord.Embed(color=discord.Color.blue())
+
+        if not is_3ds(console):
+            embed.description = f'{ctx.author.mention}, Valid options are `' + ', '.join(valid_3ds) + "`"
+            embed.color = discord.Color.red()
+            await ctx.send(embed=embed, delete_after=10)
+            return
+
         if console in boards.keys():
             embed.set_image(url=boards[console])
 
@@ -313,13 +344,13 @@ async def pop(self, ctx: KurisuContext, console: str = ""):
                 embed.set_image(url=boards[alias[console]])
 
             else:
-                embed.description = f'{ctx.author.mention}, Valid options are `' + ', '.join(boards) + "`"
+                embed.description = f'{ctx.author.mention}, Valid options are `' + ', '.join(valid_3ds) + "`"
                 embed.color = discord.Color.red()
                 await ctx.send(embed=embed, delete_after=10)
                 return
 
         else:
-            embed.description = f'{ctx.author.mention}, Valid options are `' + ', '.join(boards) + "`"
+            embed.description = f'{ctx.author.mention}, Valid options are `' + ', '.join(valid_3ds) + "`"
             embed.color = discord.Color.red()
             await ctx.send(embed=embed, delete_after=10)
             return