Commit dd5f019
committed
Add on-monitor-changed config callback
When a monitor is connected or disconnected, users often need to
reload external tools (e.g. sketchybar) that depend on the display
configuration. AeroSpace already detects monitor count changes in
gcMonitors() and rearranges workspaces, but provides no hook for
users to run commands in response.
Add on-monitor-changed callback that fires when the set of connected
monitors changes.
Detection: register a CGDisplayReconfigurationCallback in
GlobalObserver. This fires reliably for monitor connect/disconnect
at the CoreGraphics level, unlike NSApplication notifications which
may not be delivered to agent apps. The callback triggers a refresh
session which runs gcMonitors() and layoutWorkspaces() as usual.
Callback timing: checkOnMonitorChangedCallback() runs AFTER
layoutWorkspaces() in runRefreshSessionBlocking, so external tools
that query AeroSpace (e.g. `aerospace list-workspaces --monitor X`)
see the final workspace-to-monitor assignments. This avoids a race
where the callback fires mid-rearrangement and tools see stale state.
The callback tracks monitor count via a separate _previousMonitorCount
variable rather than hooking into gcMonitors() directly, because other
refresh sessions (triggered by concurrent AX notifications) often call
rearrangeWorkspacesOnMonitors() first, making gcMonitors()'s own
count comparison a no-op by the time the display reconfiguration
session runs.
Config syntax:
on-monitor-changed = 'exec-and-forget sketchybar --reload'
Also adds monitor-changed to the subscribe event types so that
`aerospace subscribe monitor-changed` works for external tooling.1 parent 8d5dc7b commit dd5f019
File tree
10 files changed
+45
-2
lines changed- Sources
- AppBundleTests/command
- AppBundle
- config
- layout
- model
- tree
- Common
- cmdArgs/impl
- util
10 files changed
+45
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
56 | 66 | | |
57 | 67 | | |
58 | 68 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| 57 | + | |
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| 105 | + | |
105 | 106 | | |
106 | 107 | | |
107 | 108 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
48 | 52 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
135 | 138 | | |
136 | 139 | | |
137 | 140 | | |
138 | 141 | | |
139 | 142 | | |
140 | 143 | | |
141 | 144 | | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
142 | 163 | | |
143 | 164 | | |
144 | 165 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
64 | 65 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| 83 | + | |
| 84 | + | |
83 | 85 | | |
84 | 86 | | |
85 | 87 | | |
| |||
99 | 101 | | |
100 | 102 | | |
101 | 103 | | |
| 104 | + | |
| 105 | + | |
102 | 106 | | |
103 | 107 | | |
104 | 108 | | |
| |||
0 commit comments