VScode is treated as a dialog/floating

[oskarkivra]

Body

Steps to reproduce:

1. Open VScode
2. VScode is acting as a dialog and floating around and can be had to focus/find

Expected result:
VScode should be treated as a window

Actual result:
VScode is treated as a dialog

Additional info

I could fix this by adding:

[[on-window-detected]]
    if.app-id = 'com.microsoft.VSCode'
    run = 'layout tiling'

Should I create a PR and update isDialogHeuristic and just add:

if id == "com.microsoft.VSCode" {
  return true
}

Or is it more to it?

$ aerospace -v
aerospace CLI client version: 0.19.2-Beta d246f250468fc9d427a2eb901d56794af7ac6609
AeroSpace.app server version: 0.19.2-Beta d246f250468fc9d427a2eb901d56794af7ac6609

[nikitabobko]

I can't reproduce the issue. VS Code is treated as a normal tiling window on my machine.

We even have a test for VS Code:

AeroSpace/axDumps/vs_code.json5

Line 95 in ed17fc0

"Aero.AxUiElementWindowType" : "window",

Please attach your aerospace debug-windows output for the VS Code window

[oskarkivra]

I now realized that I had "window.nativeFullScreen": false, in my vscode config which means that vscode don't gets its own (native) workspace when I press the green full screen button.
If I set "window.nativeFullScreen": true, it works without run = 'layout tiling'.

Sorry for reporting this but now you know about window.nativeFullScreen :)

[nikitabobko]

0.20.0-Beta version fixes the problem even when "window.nativeFullScreen": true

[drod3763]

This also affects Cursor editor and likely any other VSCode fork. Does the beta fix also handle those?