Skip to content

Change the default value for auto-reload-config to true #1882

@nikitabobko

Description

@nikitabobko

Description

Currently, the default value for auto-reload-config is false because the current implementation doesn't allow to support the current flow:

  1. The user just installs AeroSpace and doesn't yet have a custom config
  2. AeroSpace starts watching for /Applications/AeroSpace.app/Contents/Resources/default-config.toml
  3. User creates the custom config.
    Expected: AeroSpace starts watching for the custom config instead of the built-in one.

Unfortunately, it's unclear how to support the mentioned flow by using the current implementation of file watcher. The current implementation relies on file descriptors (file descriptors for non existing files don't exist)

Motivation

auto-reload-config = true is a sane default for new users. For old users, it just doesn't matter

Possible solutions

  1. Migrate to path watching API instead of file descriptor API Auto reload config #1743
  2. Watch for descriptors of chain of containing directories? Could be very busy since we might need to watch for $HOME.

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions