Optional parameter to specify preferred editor#1963
Closed
technocidal wants to merge 2 commits intonikitabobko:mainfrom
Closed
Optional parameter to specify preferred editor#1963technocidal wants to merge 2 commits intonikitabobko:mainfrom
technocidal wants to merge 2 commits intonikitabobko:mainfrom
Conversation
Give users the option to explicitly set an editor instead of relying on the automatic behavior. There are scenarios where users have different editors for different purposes e.g. Visual Studio Code for actual projects and Textastic for small configuration files.
technocidal
commented
Feb 16, 2026
|
|
||
| func getTextEditorToOpenConfig() -> URL { | ||
| NSWorkspace.shared.urlForApplication(toOpen: findCustomConfigUrl().urlOrNil ?? defaultConfigUrl)? | ||
| @MainActor func getTextEditorToOpenConfig() -> URL { |
Author
There was a problem hiding this comment.
(question) Moving this to @MainActor is probably not a big deal (e.g. this function isn't constantly called, other functions in this same file that are used to populate the menubar are already annotated with @MainActor etc.), but it's the most significant change from a runtime perspective so I wanted to point it out.
Owner
|
I am against adding a config option for such minor use case. You are overconfiguring |
Author
|
Makes sense! I'll take your suggestion to heart and if I still want this down the road, I can always just setup an automated workflow somewhere to have a patched version. AeroSpace has made my Mac so much more enjoyable. Thank you for building it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give users the option to explicitly set an editor instead of relying on the automatic behavior. There are scenarios where users have different editors for different purposes e.g. Visual Studio Code for actual projects and Textastic for small configuration files.
PR checklist
./run-tests.shexits with non-zero exit code. test.logFailure to follow the checklist with no apparent reasons will result in silent PR rejection.