debugger: add more logs to probe mode

Add more log points in the probe mode and enable the debuglog
int the probe mode tests.

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63663
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>

Author: joyeecheung

lib/internal/debugger/inspect_probe.js

@@ -505,13 +505,15 @@ class ProbeInspectorSession {
 
   onChildOutput(text, which) {
     if (which !== 'stderr') { return; }
+    debug('child stderr: %j', text);
 
     this.childStderr += text;
 
     const combined = this.disconnectSentinelBuffer + text;
     // Detect the disconnect sentinel.
     if (this.connected &&
         StringPrototypeIncludes(combined, kProbeDisconnectSentinel)) {
+      debug('disconnect sentinel detected, resetting client');
       this.disconnectRequested = true;
       this.client.reset();
     }
@@ -587,6 +589,7 @@ class ProbeInspectorSession {
   }
 
   onPaused(params) {
+    debug('paused: finished=%d, reason=%s hitBreakpoints=%j', this.finished, params.reason, params.hitBreakpoints);
     this.handlePaused(params).catch((error) => {
       if (error === kInspectorFailedSentinel) { return; }
       this.recordInspectorFailure({
@@ -837,6 +840,9 @@ class ProbeInspectorSession {
   }
 
   onScriptParsed(params) {
+    if (params.url && !StringPrototypeStartsWith(params.url, 'node:')) {
+      debug('scriptParsed: scriptId=%s url=%s, length=%d', params.scriptId, params.url, params.length);
+    }
     // This map grows by the number of scripts parsed, which is limited, and is just a
     // small string -> string map. The lifetime is bounded by probe timeout etc. so cleanup is overkill.
     this.scriptIdToUrl.set(params.scriptId, params.url);
@@ -879,6 +885,8 @@ class ProbeInspectorSession {
       }
 
       const result = await this.callCdp('Debugger.setBreakpointByUrl', params);
+      debug('breakpoint set: id=%s urlRegex=%s locations=%j',
+            result.breakpointId, params.urlRegex, result.locations);
       this.breakpointDefinitions.set(result.breakpointId, { probeIndices });
     }
   }

test/parallel/test-debugger-probe-bound-never-hit.js

@@ -16,7 +16,7 @@ spawnSyncAndAssert(process.execPath, [
   '--probe', 'probe-bound-never-hit.js:4',
   '--expr', '1',
   'probe-bound-never-hit.js',
-], { cwd }, {
+], { cwd, env: { ...process.env, NODE_DEBUG: 'inspect_probe' } }, {
   stdout(output) {
     assertProbeJson(output, {
       v: 2,

test/parallel/test-debugger-probe-child-inspect-port-zero.js

@@ -19,7 +19,7 @@ spawnSyncAndAssert(process.execPath, [
   '--',
   '--inspect-port=0',
   'probe.js',
-], { cwd }, {
+], { cwd, env: { ...process.env, NODE_DEBUG: 'inspect_probe' } }, {
   stdout(output) {
     assertProbeJson(output, {
       v: 2,

test/parallel/test-debugger-probe-explicit-column.js

@@ -24,7 +24,7 @@ spawnSyncAndAssert(process.execPath, [
   '--probe', 'probe-multi-statement.js:5:29',
   '--expr', 'acc.length',
   'probe-multi-statement.js',
-], { cwd }, {
+], { cwd, env: { ...process.env, NODE_DEBUG: 'inspect_probe' } }, {
   stdout(output) {
     assertProbeJson(output, {
       v: 2,

test/parallel/test-debugger-probe-expression-throws.js

@@ -23,7 +23,7 @@ spawnSyncAndExit(process.execPath, [
   '--probe', `${fixture}:16`, '--expr', probes[0].expr,
   '--probe', `${fixture}:17`, '--expr', probes[1].expr,
   fixture,
-], { cwd }, {
+], { cwd, env: { ...process.env, NODE_DEBUG: 'inspect_probe' } }, {
   status: 0,
   signal: null,
   stdout(output) {

test/parallel/test-debugger-probe-failure-hang-during-evaluate.js

@@ -24,7 +24,7 @@ spawnSyncAndExit(process.execPath, [
   '--probe', `${fixture}:10`, '--expr', probes[0].expr,
   '--probe', `${fixture}:11`, '--expr', probes[1].expr,
   fixture,
-], { cwd }, {
+], { cwd, env: { ...process.env, NODE_DEBUG: 'inspect_probe' } }, {
   status: 1,
   signal: null,
   stdout(output) {

test/parallel/test-debugger-probe-failure-process-exit.js

@@ -18,7 +18,7 @@ spawnSyncAndExit(process.execPath, [
   'inspect', '--json',
   '--probe', `${fixture}:8`, '--expr', probes[0].expr,
   fixture,
-], { cwd }, {
+], { cwd, env: { ...process.env, NODE_DEBUG: 'inspect_probe' } }, {
   status: 1,
   signal: null,
   stdout(output) {

test/parallel/test-debugger-probe-global-option-order.js

@@ -17,7 +17,7 @@ spawnSyncAndAssert(process.execPath, [
   '--expr', 'finalValue',
   '--json',
   'probe.js',
-], { cwd }, {
+], { cwd, env: { ...process.env, NODE_DEBUG: 'inspect_probe' } }, {
   stdout(output) {
     assertProbeJson(output, {
       v: 2,

test/parallel/test-debugger-probe-json-preview.js

@@ -24,7 +24,7 @@ spawnSyncAndAssert(process.execPath, [
   '--probe', probeArg,
   '--expr', 'errorValue',
   'probe-types.js',
-], { cwd }, {
+], { cwd, env: { ...process.env, NODE_DEBUG: 'inspect_probe' } }, {
   stdout(output) {
     assertProbeJson(output, {
       v: 2,

test/parallel/test-debugger-probe-json-special-values.js

@@ -39,7 +39,7 @@ spawnSyncAndAssert(process.execPath, [
   '--probe', probeArg,
   '--expr', 'errorValue',
   'probe-types.js',
-], { cwd }, {
+], { cwd, env: { ...process.env, NODE_DEBUG: 'inspect_probe' } }, {
   stdout(output) {
     assertProbeJson(output, {
       v: 2,