You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(Table): scope expansion re-measure to changed rows; document RO limits
Address CodeRabbit nitpicks on #6379:
- Watcher: diff the before/after TanStack expanded state and only call
virtualizer.measureElement on rows whose expanded flag actually
toggled, instead of sweeping every visible row on every change. When
the state is the boolean sentinel `true` (expand-all) we fall back
to the full sweep since there are no individual row ids to diff.
- Watcher: drop the redundant inner `if (!virtualizer)` guard — the
whole watch is already inside `if (virtualizer) { ... }`.
- JSDoc: note that TanStack's ResizeObserver is attached to the main
<tr> only, and the built-in expansion watcher fires on expand/collapse
toggles but not on intra-expansion size changes (late-loading images,
async content, nested toggles). Users whose expansion region can
resize after mount should call `virtualizer.measure()` themselves.
0 commit comments