Skip to content

Commit 5b4c9fb

Browse files
yezaoshu蚂蚁代码服务
authored andcommitted
PullRequest: 893 fix: 使用getDefaultSchema获取需要定位的数据库信息
Merge branch 'fix/databaseid of git@code.alipay.com:oceanbase/oceanbase-developer-center.git into dev-4.3.4 https://code.alipay.com/oceanbase/oceanbase-developer-center/pull_requests/893 Reviewed-by: 晓康 <xxk268858@oceanbase.com> * fix: 使用getDefaultSchema获取需要定位的数据库信息
1 parent 061c928 commit 5b4c9fb

File tree

3 files changed

+11
-23
lines changed

3 files changed

+11
-23
lines changed

src/page/Gateway/customConnect.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,11 @@ import dayjs from 'dayjs';
3636
async function getDefaultSchema(dsId: number, userName: string) {
3737
const res = await listDatabases(null, dsId, 1, 999);
3838
const databases = res?.contents;
39+
// mysql 模式的默认数据库是 information_schema
3940
const informationSchema = databases?.find((d) => d.name === 'information_schema');
41+
// oracle 模式的的默认数据库是和用户名相同的 schema
4042
const sameName = databases?.find((d) => d.name?.toLowerCase() === userName?.toLowerCase());
43+
// 如果都没有,则取第一个
4144
return informationSchema?.id || sameName?.id || databases?.[0]?.id;
4245
}
4346

@@ -197,7 +200,6 @@ export const action = async (config: ICustomConnectAction) => {
197200
return 'Connection Test Failed';
198201
}
199202
const createResult = await newConnection(params);
200-
const databaseName = params?.defaultSchema;
201203

202204
if (createResult) {
203205
gotoSQLWorkspace(
@@ -208,7 +210,6 @@ export const action = async (config: ICustomConnectAction) => {
208210
generateUniqKey(),
209211
false,
210212
false,
211-
databaseName,
212213
);
213214
} else {
214215
return 'create connection failed';

src/page/Workspace/SideBar/ResourceTree/Container.tsx

Lines changed: 7 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -59,25 +59,13 @@ export default inject(
5959
}
6060

6161
const resolveParams = async () => {
62-
const databaseName = searchParams.get('databaseName');
63-
if (tempDatasourceId) {
64-
const databaseListData =
65-
resourcetreeContext.databaseList?.length > 0
66-
? resourcetreeContext.databaseList
67-
: await resourcetreeContext.reloadDatabaseList();
68-
if (databaseName && databaseListData) {
69-
const targetDatabase = databaseListData.find(
70-
(db) => db.name === databaseName && db?.dataSource?.id === parseInt(tempDatasourceId),
71-
);
72-
if (targetDatabase) {
73-
// 打开sql窗口
74-
openNewSQLPage(targetDatabase.id);
75-
// 删除databaseName参数
76-
const newSearchParams = new URLSearchParams(searchParams);
77-
newSearchParams.delete('databaseName');
78-
setSearchParams(newSearchParams, { replace: true });
79-
}
80-
}
62+
const databaseId = searchParams.get('databaseId');
63+
if (databaseId) {
64+
// 打开sql窗口
65+
openNewSQLPage(parseInt(databaseId));
66+
const newSearchParams = new URLSearchParams(searchParams);
67+
newSearchParams.delete('databaseId');
68+
setSearchParams(newSearchParams, { replace: true });
8169
}
8270
};
8371

src/util/route/index.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,12 @@ export function gotoSQLWorkspace(
2424
tabKey: string = '',
2525
isLogicalDatabase: boolean = false,
2626
isCreateTable: boolean = false,
27-
databaseName?: string,
2827
) {
2928
const url =
3029
location.origin +
3130
location.pathname +
3231
(tabKey
33-
? `#/sqlworkspace/${tabKey}/${datasourceId}?databaseName=${databaseName}`
32+
? `#/sqlworkspace/${tabKey}/${datasourceId}?databaseId=${databaseId}`
3433
: `#/sqlworkspace?projectId=${projectId || ''}&datasourceId=${
3534
datasourceId || ''
3635
}&databaseId=${

0 commit comments

Comments
 (0)