Skip to content

Commit c45371c

Browse files
author
之瑛
committed
PullRequest: 829 修复最大值限制 key 读取
Merge branch 'fix/max-config of git@code.alipay.com:oceanbase/oceanbase-developer-center.git into dev-4.3.4 https://code.alipay.com/oceanbase/oceanbase-developer-center/pull_requests/829 Reviewed-by: 晓康 <xxk268858@oceanbase.com> * refactor: 调整最大值key 读取 * refactor: 优化代码样式 * refactor: 调整函数名称
1 parent 4d030af commit c45371c

3 files changed

Lines changed: 15 additions & 12 deletions

File tree

src/component/ODCSetting/config/group/sqlQuery.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import { getCurrentOrganizationId } from '@/store/setting';
1818
import { IODCSetting, ODCSettingGroup } from '../../config';
1919
import InputIntergerItem from '../../Item/InputIntegerItem';
2020
import InputItem from '../../Item/InputItem';
21-
import { validForqueryLimit, validForqueryQueryNumber } from '../../validators';
21+
import { validForQueryLimit, validForQueryQueryNumber } from '../../validators';
2222

2323
const databaseGroup: ODCSettingGroup = {
2424
label: formatMessage({
@@ -41,7 +41,7 @@ const sqlQuerySetting: IODCSetting[] = [
4141
rules: [
4242
{
4343
validator(rule, value, callback) {
44-
return validForqueryLimit(value);
44+
return validForQueryLimit(value);
4545
},
4646
},
4747
],
@@ -72,7 +72,7 @@ const sqlQuerySetting: IODCSetting[] = [
7272
rules: [
7373
{
7474
validator(rule, value, callback) {
75-
return validForqueryQueryNumber(value);
75+
return validForQueryQueryNumber(value);
7676
},
7777
},
7878
],

src/component/ODCSetting/config/personal/personalSqlQuery.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import { getCurrentOrganizationId } from '@/store/setting';
1818
import { IODCSetting, ODCSettingGroup } from '../../config';
1919
import InputIntergerItem from '../../Item/InputIntegerItem';
2020
import InputItem from '../../Item/InputItem';
21-
import { validForqueryLimit, validForqueryQueryNumber } from '../../validators';
21+
import { validForQueryLimit, validForQueryQueryNumber } from '../../validators';
2222

2323
const databaseGroup: ODCSettingGroup = {
2424
label: formatMessage({
@@ -42,7 +42,7 @@ const personalSqlQuerySetting: IODCSetting[] = [
4242
rules: [
4343
{
4444
validator(rule, value, callback) {
45-
return validForqueryLimit(value);
45+
return validForQueryLimit(value);
4646
},
4747
},
4848
],
@@ -73,7 +73,7 @@ const personalSqlQuerySetting: IODCSetting[] = [
7373
rules: [
7474
{
7575
validator(rule, value, callback) {
76-
return validForqueryQueryNumber(value);
76+
return validForQueryQueryNumber(value);
7777
},
7878
},
7979
],

src/component/ODCSetting/validators.ts

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import { formatMessage } from '@/util/intl';
22
import setting, { getCurrentOrganizationId } from '@/store/setting';
3+
import { getSystemConfig } from '@/common/network/other';
34

4-
export const validForqueryQueryNumber = (value) => {
5+
export const validForQueryQueryNumber = (value) => {
56
const sessionQueryLimit = sessionStorage.getItem(`maxQueryLimit-${getCurrentOrganizationId()}`);
67
const queryLimit = setting.getSpaceConfigByKey('odc.sqlexecute.default.maxQueryLimit');
78
if (!value) {
@@ -35,11 +36,13 @@ export const validForqueryQueryNumber = (value) => {
3536
return Promise.resolve();
3637
};
3738

38-
export const validForqueryLimit = (value) => {
39-
const limit =
40-
Number(setting.configurations['odc.session.sql-execute.max-result-set-rows']) || 100000;
41-
if (value > limit) {
42-
return Promise.reject(`不超过${limit}`);
39+
export const validForQueryLimit = async (value) => {
40+
const res = await getSystemConfig();
41+
const maxResultsetRows =
42+
parseInt(res?.['odc.session.sql-execute.max-result-set-rows']) || Number.MAX_SAFE_INTEGER;
43+
44+
if (value > maxResultsetRows) {
45+
return Promise.reject(`不超过${maxResultsetRows}`);
4346
}
4447
if (!value) {
4548
return Promise.reject(

0 commit comments

Comments
 (0)