fix: align NoOpProvider reason and ProviderInitializationError default error code with spec

Signed-off-by: Cristian Marta <cristian@caffe-lento.com>

Author: cristiangmarta

lib/open_feature/sdk/provider/no_op_provider.rb

@@ -23,7 +23,7 @@ module Provider
       # * <tt>fetch_object_value</tt> - Retrieve feature flag object value
       #
       class NoOpProvider
-        REASON_NO_OP = "No-op"
+        REASON_NO_OP = Reason::DEFAULT
         NAME = "No-op Provider"
 
         attr_reader :metadata

lib/open_feature/sdk/provider_initialization_error.rb

@@ -21,8 +21,8 @@ class ProviderInitializationError < StandardError
       # @param message [String] the error message
       # @param provider [Object] the provider that failed to initialize
       # @param original_error [Exception] the original error that caused the failure
-      # @param error_code [String] the OpenFeature error code (defaults to PROVIDER_FATAL)
-      def initialize(message, provider: nil, original_error: nil, error_code: Provider::ErrorCode::PROVIDER_FATAL)
+      # @param error_code [String] the OpenFeature error code (defaults to GENERAL)
+      def initialize(message, provider: nil, original_error: nil, error_code: Provider::ErrorCode::GENERAL)
         super(message)
         @provider = provider
         @original_error = original_error

spec/open_feature/sdk/hooks/logging_hook_spec.rb

@@ -148,12 +148,15 @@
     end
 
     it "uses error_code from exception when available" do
-      error_with_code = OpenFeature::SDK::ProviderInitializationError.new("init failed")
+      error_with_code = OpenFeature::SDK::ProviderInitializationError.new(
+        "init failed",
+        error_code: "CUSTOM_ERROR_CODE"
+      )
       hook = described_class.new(logger: logger)
 
       expect(logger).to receive(:error) do |&block|
         message = block.call
-        expect(message).to include("error_code=PROVIDER_FATAL")
+        expect(message).to include("error_code=CUSTOM_ERROR_CODE")
       end
 
       hook.error(hook_context: hook_context, exception: error_with_code, hints: hints)

spec/open_feature/sdk/provider_initialization_error_spec.rb

@@ -29,8 +29,8 @@
         expect(error).to be_a(StandardError)
       end
 
-      it "sets the error code to PROVIDER_FATAL by default" do
-        expect(error.error_code).to eq(OpenFeature::SDK::Provider::ErrorCode::PROVIDER_FATAL)
+      it "sets the error code to GENERAL by default" do
+        expect(error.error_code).to eq(OpenFeature::SDK::Provider::ErrorCode::GENERAL)
       end
     end
 
@@ -49,8 +49,8 @@
         expect(error.original_error).to be_nil
       end
 
-      it "sets the error code to PROVIDER_FATAL by default" do
-        expect(error.error_code).to eq(OpenFeature::SDK::Provider::ErrorCode::PROVIDER_FATAL)
+      it "sets the error code to GENERAL by default" do
+        expect(error.error_code).to eq(OpenFeature::SDK::Provider::ErrorCode::GENERAL)
       end
     end