Skip to content

housenumber layer missing some houses #296

@davecraig

Description

@davecraig

In my town (at least!), there are quite a lot of OSM buildings which only have an addr:housenumber and have no addr:street or addr:blockNumber. If there's more than one of those in a tile that have the same value for addr:housenumber then only one of them will appear in the tile and the rest are dropped. This processing happens in Housenumber.postProcess.

One example of this is where https://www.openstreetmap.org/way/443794377 does not appear in the pmtiles output https://maps.protomaps.com/#flavorName=light&lang=en&map=18.2/55.9454/-4.313623.

The housenumber is removed because multiple building in the tile have the calculated partition value street + blockNumber + housenumber because street and blockNumber are empty. From the git history this is to match openmaptiles/openmaptiles#1391.

If I change postProcess to use var items = list.stream().toList(); then my street numbers all appear in the map, and also the size of my test map (scotland) actually shrinks(!).

What do you think a good approach would be until a time when all of the OSM points with addr:housenumber include an addr:street?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions