Use SEP-0053 in SEP-0010 instead of malformed transactions #1762
johansten
started this conversation in
Stellar Ecosystem Proposals
Replies: 1 comment 1 reply
-
What is the hack being referred to in the comment, or that is being proposed to be removed? |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
IIRC the motivation for this hack was originally to be able to support hardware wallets.
With the Ledger signer adopting SEP-0053 signatures, maybe it's time to get rid of this?
A more sophisticated signing infrastructure would rightfully not sign anything that looks like a transaction if the intent is for a message signature, and it would rightfully reject a malformed transaction if the intent was to sign a transaction.
This hack fits neither or.
Beta Was this translation helpful? Give feedback.
All reactions