Clean up robot PR surface

Author: Niutels

packages/editor/src/components/ui/item-catalog/catalog-items.tsx

@@ -1,5 +1,4 @@
 import type { AssetInput } from '@pascal-app/core'
-import { PASCAL_TRUCK_ASSET } from '../../../lib/pascal-truck'
 
 export const CATALOG_ITEMS: AssetInput[] = [
   {
@@ -14,7 +13,6 @@ export const CATALOG_ITEMS: AssetInput[] = [
     rotation: [0, 0, 0],
     dimensions: [2, 1.7, 5],
   },
-  PASCAL_TRUCK_ASSET,
   {
     id: 'ev-wall-charger',
     category: 'appliance',

packages/editor/src/components/ui/panels/navigation-panel.tsx

@@ -2,24 +2,19 @@
 
 import { emitter } from '@pascal-app/core'
 import { useViewer } from '@pascal-app/viewer'
-import { Bot, Copy, Move, Power, Shield, Trash2, Wrench } from 'lucide-react'
+import { Copy, Move, Power, Trash2, Wrench } from 'lucide-react'
 import { type PointerEvent as ReactPointerEvent, useEffect, useMemo, useRef, useState } from 'react'
 import { useShallow } from 'zustand/react/shallow'
 import { cn } from '../../../lib/utils'
 import useEditor from '../../../store/use-editor'
-import type { NavigationQueuedTask, NavigationRobotModel } from '../../../store/use-navigation'
+import type { NavigationQueuedTask } from '../../../store/use-navigation'
 import useNavigation from '../../../store/use-navigation'
 import navigationVisualsStore from '../../../store/use-navigation-visuals'
 import { Tooltip, TooltipContent, TooltipTrigger } from '../primitives/tooltip'
 
 const PANEL_BUTTON_CLASS =
   'flex h-10 w-10 items-center justify-center rounded-xl border border-border/60 bg-background/70 text-muted-foreground transition-colors hover:border-border hover:bg-background hover:text-foreground disabled:cursor-not-allowed disabled:opacity-45'
 
-const ROBOT_MODEL_LABELS: Record<NavigationRobotModel, string> = {
-  armored: 'Armored robot',
-  pascal: 'Pascal robot',
-}
-
 type TaskDragState = {
   clientX: number
   clientY: number
@@ -181,10 +176,8 @@ export function NavigationPanel() {
     itemMoveControllers,
     moveQueuedTask,
     removeQueuedTask,
-    robotModel,
     robotMode,
     setActiveTask,
-    setRobotModel,
     setRobotMode,
     taskQueue,
   } = useNavigation(
@@ -193,10 +186,8 @@ export function NavigationPanel() {
       itemMoveControllers: state.itemMoveControllers,
       moveQueuedTask: state.moveQueuedTask,
       removeQueuedTask: state.removeQueuedTask,
-      robotModel: state.robotModel,
       robotMode: state.robotMode,
       setActiveTask: state.setActiveTask,
-      setRobotModel: state.setRobotModel,
       setRobotMode: state.setRobotMode,
       taskQueue: state.taskQueue,
     })),
@@ -384,9 +375,6 @@ export function NavigationPanel() {
 
   const robotTooltip =
     robotMode === 'normal' ? 'Turn robot off (manual mode).' : 'Turn robot off (task mode).'
-  const nextRobotModel = robotModel === 'pascal' ? 'armored' : 'pascal'
-  const RobotModelIcon = robotModel === 'pascal' ? Bot : Shield
-  const modelTooltip = `${ROBOT_MODEL_LABELS[robotModel]}. Switch to ${ROBOT_MODEL_LABELS[nextRobotModel]}.`
 
   return (
     <div data-testid="navigation-panel" ref={rootRef}>
@@ -410,24 +398,6 @@ export function NavigationPanel() {
             </TooltipTrigger>
             <TooltipContent side="left">{robotTooltip}</TooltipContent>
           </Tooltip>
-          <Tooltip>
-            <TooltipTrigger asChild>
-              <button
-                aria-label={`Switch to ${ROBOT_MODEL_LABELS[nextRobotModel]}`}
-                className={cn(
-                  PANEL_BUTTON_CLASS,
-                  robotModel === 'armored' &&
-                    'border-cyan-300/50 bg-cyan-500/15 text-cyan-100 hover:border-cyan-200 hover:bg-cyan-500/20 hover:text-white',
-                )}
-                data-testid="navigation-robot-model-toggle"
-                onClick={() => setRobotModel(nextRobotModel)}
-                type="button"
-              >
-                <RobotModelIcon className="h-4 w-4" />
-              </button>
-            </TooltipTrigger>
-            <TooltipContent side="left">{modelTooltip}</TooltipContent>
-          </Tooltip>
         </div>
       </div>
 

packages/editor/src/lib/pascal-truck.ts

@@ -4,7 +4,6 @@ import type { SceneGraph } from './scene'
 
 export const PASCAL_TRUCK_ASSET_ID = 'pascal-truck'
 export const PASCAL_TRUCK_ITEM_NODE_ID = 'item_pascal_truck_seed'
-export const PASCAL_TRUCK_DEFAULT_LEVEL_ID = 'level_9zq0a3e17uf8an2u'
 
 export const PASCAL_TRUCK_ASSET: AssetInput = {
   id: PASCAL_TRUCK_ASSET_ID,
@@ -19,8 +18,8 @@ export const PASCAL_TRUCK_ASSET: AssetInput = {
   dimensions: [4.42, 2.5, 2.28],
 }
 
-export const PASCAL_TRUCK_SCENE_POSITION: [number, number, number] = [7.25, 0, -11.25]
-export const PASCAL_TRUCK_SCENE_ROTATION: [number, number, number] = [0, Math.PI / 2, 0]
+export const PASCAL_TRUCK_SCENE_POSITION: [number, number, number] = [0, 0, 0]
+export const PASCAL_TRUCK_SCENE_ROTATION: [number, number, number] = [0, 0, 0]
 export const PASCAL_TRUCK_SCENE_SCALE: [number, number, number] = [1, 1, 1]
 
 export const PASCAL_TRUCK_ENTRY_CLIP_NAME = 'Jumping_Down'
@@ -82,16 +81,7 @@ function isRecord(value: unknown): value is Record<string, unknown> {
 
 function shouldPreservePascalTruckPlacement(sourceTruckNode?: ItemNode | null) {
   const metadata = isRecord(sourceTruckNode?.metadata) ? sourceTruckNode.metadata : null
-  if (metadata?.manualPlacement !== true) {
-    return false
-  }
-
-  const seededBy = typeof metadata.seededBy === 'string' ? metadata.seededBy : null
-  if (seededBy === 'apps/editor/app/page.tsx') {
-    return false
-  }
-
-  return true
+  return metadata?.manualPlacement === true
 }
 
 function getScaledItemDimensions(node: Record<string, unknown>): [number, number, number] | null {
@@ -498,11 +488,6 @@ function resolvePascalTruckLevelId(
     return preferredLevelId
   }
 
-  const preferredLevel = sceneGraph.nodes[PASCAL_TRUCK_DEFAULT_LEVEL_ID]
-  if (isRecord(preferredLevel) && preferredLevel.type === 'level') {
-    return PASCAL_TRUCK_DEFAULT_LEVEL_ID
-  }
-
   let fallbackLevelId: string | null = null
   for (const node of Object.values(sceneGraph.nodes)) {
     if (!isRecord(node) || node.type !== 'level' || typeof node.id !== 'string') {
@@ -605,11 +590,10 @@ export function buildPascalTruckNodeForScene(
         id: PASCAL_TRUCK_ITEM_NODE_ID,
         metadata: {
           manualPlacement: false,
-          seededBy: 'packages/editor/src/components/editor/index.tsx',
         },
         name: PASCAL_TRUCK_ASSET.name,
         object: 'node',
-        parentId: parentId ?? PASCAL_TRUCK_DEFAULT_LEVEL_ID,
+        parentId,
         position: seededTransform.position,
         rotation: seededTransform.rotation,
         scale: seededTransform.scale,