From 53802671ac11859258e4fa3d92eee337a2d2a9b3 Mon Sep 17 00:00:00 2001 From: Rebecca Alpert Date: Mon, 29 Jun 2026 15:02:33 -0400 Subject: [PATCH] fix(RhMicronCaretDown): Replace with fill for menus Design reports that filled icon is needed here. --- .../Breadcrumb/examples/Breadcrumb.md | 2 +- .../__snapshots__/DatePicker.test.tsx.snap | 2 +- .../src/components/FormSelect/FormSelect.tsx | 4 +- .../__snapshots__/FormSelect.test.tsx.snap | 18 ++++----- .../src/components/Menu/examples/Menu.md | 2 +- .../src/components/MenuToggle/MenuToggle.tsx | 4 +- .../__snapshots__/MenuToggle.test.tsx.snap | 16 ++++---- .../src/components/Modal/examples/Modal.md | 1 - .../PaginationOptionsMenu.test.tsx.snap | 2 +- .../__snapshots__/Pagination.test.tsx.snap | 40 +++++++++---------- .../components/SearchInput/SearchInput.tsx | 4 +- .../__snapshots__/SearchInput.test.tsx.snap | 6 +-- .../src/demos/CustomMenus/CustomMenus.md | 4 +- .../components/Modal/examples/Modal.md | 1 - .../demos/BreadcrumbDemo/BreadcrumbDemo.tsx | 4 +- .../SimpleDropdown.test.tsx.snap | 4 +- .../CheckboxSelectSnapshots.test.tsx.snap | 4 +- .../MultiTypeaheadSelect.test.tsx.snap | 2 +- .../__snapshots__/SimpleSelect.test.tsx.snap | 4 +- .../TypeaheadSelect.test.tsx.snap | 2 +- 20 files changed, 62 insertions(+), 64 deletions(-) diff --git a/packages/react-core/src/components/Breadcrumb/examples/Breadcrumb.md b/packages/react-core/src/components/Breadcrumb/examples/Breadcrumb.md index fca73aac82e..e3546da2065 100644 --- a/packages/react-core/src/components/Breadcrumb/examples/Breadcrumb.md +++ b/packages/react-core/src/components/Breadcrumb/examples/Breadcrumb.md @@ -8,7 +8,7 @@ ouia: true import { useRef, useState } from 'react'; import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon'; -import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; +import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon'; ## Examples diff --git a/packages/react-core/src/components/DatePicker/__tests__/__snapshots__/DatePicker.test.tsx.snap b/packages/react-core/src/components/DatePicker/__tests__/__snapshots__/DatePicker.test.tsx.snap index 755f0cf701a..1cbdedbbac2 100644 --- a/packages/react-core/src/components/DatePicker/__tests__/__snapshots__/DatePicker.test.tsx.snap +++ b/packages/react-core/src/components/DatePicker/__tests__/__snapshots__/DatePicker.test.tsx.snap @@ -165,7 +165,7 @@ exports[`With popover opened 1`] = ` width="1em" > diff --git a/packages/react-core/src/components/FormSelect/FormSelect.tsx b/packages/react-core/src/components/FormSelect/FormSelect.tsx index 1a0d99c6eed..0e909bbeadc 100644 --- a/packages/react-core/src/components/FormSelect/FormSelect.tsx +++ b/packages/react-core/src/components/FormSelect/FormSelect.tsx @@ -6,7 +6,7 @@ import { ValidatedOptions } from '../../helpers/constants'; import { FormControlIcon } from '../FormControl/FormControlIcon'; import { getOUIAProps, OUIAProps } from '../../helpers'; import { SSRSafeIds } from '../../helpers/SSRSafeIds/SSRSafeIds'; -import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; +import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon'; export interface FormSelectProps extends Omit, 'onChange' | 'onBlur' | 'onFocus' | 'disabled'>, OUIAProps { @@ -98,7 +98,7 @@ class FormSelect extends Component { {hasStatusIcon && } - + diff --git a/packages/react-core/src/components/FormSelect/__tests__/__snapshots__/FormSelect.test.tsx.snap b/packages/react-core/src/components/FormSelect/__tests__/__snapshots__/FormSelect.test.tsx.snap index bb835115c38..1706ddc5703 100644 --- a/packages/react-core/src/components/FormSelect/__tests__/__snapshots__/FormSelect.test.tsx.snap +++ b/packages/react-core/src/components/FormSelect/__tests__/__snapshots__/FormSelect.test.tsx.snap @@ -36,7 +36,7 @@ exports[`FormSelect Disabled FormSelect input 1`] = ` width="1em" > @@ -80,7 +80,7 @@ exports[`FormSelect FormSelect input with aria-label does not generate console e width="1em" > @@ -125,7 +125,7 @@ exports[`FormSelect FormSelect input with id does not generate console error 1`] width="1em" > @@ -168,7 +168,7 @@ exports[`FormSelect FormSelect input with no aria-label or id generates console width="1em" > @@ -258,7 +258,7 @@ exports[`FormSelect Grouped FormSelect input 1`] = ` width="1em" > @@ -340,7 +340,7 @@ exports[`FormSelect Simple FormSelect input 1`] = ` width="1em" > @@ -401,7 +401,7 @@ exports[`FormSelect invalid FormSelect input 1`] = ` width="1em" > @@ -462,7 +462,7 @@ exports[`FormSelect validated success FormSelect input 1`] = ` width="1em" > @@ -523,7 +523,7 @@ exports[`FormSelect validated warning FormSelect input 1`] = ` width="1em" > diff --git a/packages/react-core/src/components/Menu/examples/Menu.md b/packages/react-core/src/components/Menu/examples/Menu.md index 122940856c2..fdd0cf06a7b 100644 --- a/packages/react-core/src/components/Menu/examples/Menu.md +++ b/packages/react-core/src/components/Menu/examples/Menu.md @@ -30,7 +30,7 @@ import RhUiTableIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-table-ic import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-notification-fill-icon'; import RhUiStorageDomainFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-storage-domain-fill-icon'; import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon'; -import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; +import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon'; ## Examples diff --git a/packages/react-core/src/components/MenuToggle/MenuToggle.tsx b/packages/react-core/src/components/MenuToggle/MenuToggle.tsx index c31ccade269..a754e51f7a7 100644 --- a/packages/react-core/src/components/MenuToggle/MenuToggle.tsx +++ b/packages/react-core/src/components/MenuToggle/MenuToggle.tsx @@ -1,7 +1,7 @@ import { Component, forwardRef, isValidElement } from 'react'; import styles from '@patternfly/react-styles/css/components/MenuToggle/menu-toggle'; import { css } from '@patternfly/react-styles'; -import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; +import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon'; import { BadgeProps } from '../Badge'; import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon'; import RhUiCheckCircleFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-check-circle-fill-icon'; @@ -154,7 +154,7 @@ class MenuToggleBase extends Component { {status !== undefined && {_statusIcon}} - + ); diff --git a/packages/react-core/src/components/MenuToggle/__tests__/__snapshots__/MenuToggle.test.tsx.snap b/packages/react-core/src/components/MenuToggle/__tests__/__snapshots__/MenuToggle.test.tsx.snap index 0d681905576..daab926d974 100644 --- a/packages/react-core/src/components/MenuToggle/__tests__/__snapshots__/MenuToggle.test.tsx.snap +++ b/packages/react-core/src/components/MenuToggle/__tests__/__snapshots__/MenuToggle.test.tsx.snap @@ -31,7 +31,7 @@ exports[`Old Snapshot tests - remove when refactoring passes additional classes width="1em" > @@ -71,7 +71,7 @@ exports[`Old Snapshot tests - remove when refactoring renders successfully 1`] = width="1em" > @@ -120,7 +120,7 @@ exports[`Old Snapshot tests - remove when refactoring shows badge 1`] = ` width="1em" > @@ -177,7 +177,7 @@ exports[`Old Snapshot tests - remove when refactoring shows icon 1`] = ` width="1em" > @@ -218,7 +218,7 @@ exports[`Old Snapshot tests - remove when refactoring shows isDisabled 1`] = ` width="1em" > @@ -258,7 +258,7 @@ exports[`Old Snapshot tests - remove when refactoring shows isExpanded 1`] = ` width="1em" > @@ -329,7 +329,7 @@ exports[`Old Snapshot tests - remove when refactoring shows isPrimary 1`] = ` width="1em" > @@ -369,7 +369,7 @@ exports[`Old Snapshot tests - remove when refactoring shows plain text 1`] = ` width="1em" > diff --git a/packages/react-core/src/components/Modal/examples/Modal.md b/packages/react-core/src/components/Modal/examples/Modal.md index 1f4c3a8fb2b..3dc2b747c07 100644 --- a/packages/react-core/src/components/Modal/examples/Modal.md +++ b/packages/react-core/src/components/Modal/examples/Modal.md @@ -8,7 +8,6 @@ ouia: true import { Fragment, useRef, useState } from 'react'; import WarningTriangleIcon from '@patternfly/react-icons/dist/esm/icons/warning-triangle-icon'; -import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; import RhUiAttentionBellFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-attention-bell-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import formStyles from '@patternfly/react-styles/css/components/Form/form'; diff --git a/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/PaginationOptionsMenu.test.tsx.snap b/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/PaginationOptionsMenu.test.tsx.snap index 251ae4017f4..11f32b6df6b 100644 --- a/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/PaginationOptionsMenu.test.tsx.snap +++ b/packages/react-core/src/components/Pagination/__tests__/Generated/__snapshots__/PaginationOptionsMenu.test.tsx.snap @@ -43,7 +43,7 @@ exports[`PaginationOptionsMenu should match snapshot (auto-generated) 1`] = ` width="1em" > diff --git a/packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap b/packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap index 7a79535b815..3861ac20cc0 100644 --- a/packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap +++ b/packages/react-core/src/components/Pagination/__tests__/__snapshots__/Pagination.test.tsx.snap @@ -63,7 +63,7 @@ exports[`Pagination API verify inset2xl inset breakpoints 1`] = ` width="1em" > @@ -324,7 +324,7 @@ exports[`Pagination API verify insetLg inset breakpoints 1`] = ` width="1em" > @@ -585,7 +585,7 @@ exports[`Pagination API verify insetMd inset breakpoints 1`] = ` width="1em" > @@ -846,7 +846,7 @@ exports[`Pagination API verify insetNone inset breakpoints 1`] = ` width="1em" > @@ -1107,7 +1107,7 @@ exports[`Pagination API verify insetSm inset breakpoints 1`] = ` width="1em" > @@ -1368,7 +1368,7 @@ exports[`Pagination API verify insetXl inset breakpoints 1`] = ` width="1em" > @@ -1615,7 +1615,7 @@ exports[`Pagination component render custom pagination toggle 1`] = ` width="1em" > @@ -1880,7 +1880,7 @@ exports[`Pagination component render custom perPageOptions 1`] = ` width="1em" > @@ -2145,7 +2145,7 @@ exports[`Pagination component render custom start end 1`] = ` width="1em" > @@ -2625,7 +2625,7 @@ exports[`Pagination component render last page 1`] = ` width="1em" > @@ -2890,7 +2890,7 @@ exports[`Pagination component render limited number of pages 1`] = ` width="1em" > @@ -3146,7 +3146,7 @@ exports[`Pagination component render should render correctly bottom 1`] = ` width="1em" > @@ -3399,7 +3399,7 @@ exports[`Pagination component render should render correctly bottom sticky 1`] = width="1em" > @@ -3664,7 +3664,7 @@ exports[`Pagination component render should render correctly compact 1`] = ` width="1em" > @@ -3930,7 +3930,7 @@ exports[`Pagination component render should render correctly disabled 1`] = ` width="1em" > @@ -4198,7 +4198,7 @@ exports[`Pagination component render should render correctly sticky 1`] = ` width="1em" > @@ -4463,7 +4463,7 @@ exports[`Pagination component render should render correctly top 1`] = ` width="1em" > @@ -4728,7 +4728,7 @@ exports[`Pagination component render titles 1`] = ` width="1em" > @@ -4993,7 +4993,7 @@ exports[`Pagination component render up drop direction 1`] = ` width="1em" > @@ -5258,7 +5258,7 @@ exports[`Pagination component render zero results 1`] = ` width="1em" > diff --git a/packages/react-core/src/components/SearchInput/SearchInput.tsx b/packages/react-core/src/components/SearchInput/SearchInput.tsx index 192b2413358..124c3b07806 100644 --- a/packages/react-core/src/components/SearchInput/SearchInput.tsx +++ b/packages/react-core/src/components/SearchInput/SearchInput.tsx @@ -8,7 +8,7 @@ import AngleUpIcon from '@patternfly/react-icons/dist/esm/icons/angle-up-icon'; import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon'; import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon'; import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon'; -import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; +import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon'; import { AdvancedSearchMenu } from './AdvancedSearchMenu'; import { TextInputGroup, TextInputGroupMain, TextInputGroupUtilities } from '../TextInputGroup'; import { InputGroup, InputGroupItem } from '../InputGroup'; @@ -465,7 +465,7 @@ const SearchInputBase: React.FunctionComponent = ({ onClick={onToggle} isDisabled={isDisabled} aria-expanded={isSearchMenuOpen} - icon={} + icon={} /> )} diff --git a/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap b/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap index 95eb703b18e..c57bb30f579 100644 --- a/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap +++ b/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap @@ -108,7 +108,7 @@ exports[`SearchInput advanced search 1`] = ` width="1em" > @@ -263,7 +263,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = ` width="1em" > @@ -608,7 +608,7 @@ exports[`SearchInput renders search input in strict mode 1`] = ` width="1em" > diff --git a/packages/react-core/src/demos/CustomMenus/CustomMenus.md b/packages/react-core/src/demos/CustomMenus/CustomMenus.md index c56e969ec88..f303396bfdf 100644 --- a/packages/react-core/src/demos/CustomMenus/CustomMenus.md +++ b/packages/react-core/src/demos/CustomMenus/CustomMenus.md @@ -17,8 +17,8 @@ import RhUiNotificationFillIcon from '@patternfly/react-icons/dist/esm/icons/rh- import RhUiThumbnailViewSmallFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-thumbnail-view-small-fill-icon'; import brandImg from '../assets/PF-IconLogo.svg'; import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon'; -import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; -import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon'; +import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon'; +import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon'; import avatarImg from '../assets/avatarImg.svg'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Menu/menu'; diff --git a/packages/react-core/src/deprecated/components/Modal/examples/Modal.md b/packages/react-core/src/deprecated/components/Modal/examples/Modal.md index bc800663bfd..7f0552a4f91 100644 --- a/packages/react-core/src/deprecated/components/Modal/examples/Modal.md +++ b/packages/react-core/src/deprecated/components/Modal/examples/Modal.md @@ -11,7 +11,6 @@ import { Fragment, useRef, useState } from 'react'; import { Modal as ModalDeprecated, ModalVariant as ModalVariantDeprecated } from '@patternfly/react-core/deprecated'; import WarningTriangleIcon from '@patternfly/react-icons/dist/esm/icons/warning-triangle-icon'; -import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; import RhUiAttentionBellFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-attention-bell-fill-icon'; import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon'; import spacing from '@patternfly/react-styles/css/utilities/Spacing/spacing'; diff --git a/packages/react-integration/demo-app-ts/src/components/demos/BreadcrumbDemo/BreadcrumbDemo.tsx b/packages/react-integration/demo-app-ts/src/components/demos/BreadcrumbDemo/BreadcrumbDemo.tsx index 386f20bcbe0..6e9ff995e34 100644 --- a/packages/react-integration/demo-app-ts/src/components/demos/BreadcrumbDemo/BreadcrumbDemo.tsx +++ b/packages/react-integration/demo-app-ts/src/components/demos/BreadcrumbDemo/BreadcrumbDemo.tsx @@ -11,7 +11,7 @@ import { MenuToggle } from '@patternfly/react-core'; import RhMicronsCaretLeftIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-left-icon'; -import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; +import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon'; export class BreadcrumbDemo extends Component { static displayName = 'BreadcrumbDemo'; @@ -74,7 +74,7 @@ export class BreadcrumbDemo extends Component { {dropdownItems.length} - + diff --git a/packages/react-templates/src/components/Dropdown/__tests__/__snapshots__/SimpleDropdown.test.tsx.snap b/packages/react-templates/src/components/Dropdown/__tests__/__snapshots__/SimpleDropdown.test.tsx.snap index 4fb7ba082d4..c05bd20066d 100644 --- a/packages/react-templates/src/components/Dropdown/__tests__/__snapshots__/SimpleDropdown.test.tsx.snap +++ b/packages/react-templates/src/components/Dropdown/__tests__/__snapshots__/SimpleDropdown.test.tsx.snap @@ -31,7 +31,7 @@ exports[`Dropdown items Matches snapshot 1`] = ` width="1em" > @@ -71,7 +71,7 @@ exports[`Dropdown toggle Matches snapshot 1`] = ` width="1em" > diff --git a/packages/react-templates/src/components/Select/__tests__/__snapshots__/CheckboxSelectSnapshots.test.tsx.snap b/packages/react-templates/src/components/Select/__tests__/__snapshots__/CheckboxSelectSnapshots.test.tsx.snap index 0f416327faf..bd0aa18e686 100644 --- a/packages/react-templates/src/components/Select/__tests__/__snapshots__/CheckboxSelectSnapshots.test.tsx.snap +++ b/packages/react-templates/src/components/Select/__tests__/__snapshots__/CheckboxSelectSnapshots.test.tsx.snap @@ -32,7 +32,7 @@ exports[`checkbox select with no props snapshot 1`] = ` width="1em" > @@ -73,7 +73,7 @@ exports[`opened checkbox select snapshot 1`] = ` width="1em" > diff --git a/packages/react-templates/src/components/Select/__tests__/__snapshots__/MultiTypeaheadSelect.test.tsx.snap b/packages/react-templates/src/components/Select/__tests__/__snapshots__/MultiTypeaheadSelect.test.tsx.snap index c43482ac965..868fce74ca6 100644 --- a/packages/react-templates/src/components/Select/__tests__/__snapshots__/MultiTypeaheadSelect.test.tsx.snap +++ b/packages/react-templates/src/components/Select/__tests__/__snapshots__/MultiTypeaheadSelect.test.tsx.snap @@ -85,7 +85,7 @@ exports[`MultiTypeaheadSelect Matches snapshot 1`] = ` width="1em" > diff --git a/packages/react-templates/src/components/Select/__tests__/__snapshots__/SimpleSelect.test.tsx.snap b/packages/react-templates/src/components/Select/__tests__/__snapshots__/SimpleSelect.test.tsx.snap index 57d3ffa301d..541fa411c33 100644 --- a/packages/react-templates/src/components/Select/__tests__/__snapshots__/SimpleSelect.test.tsx.snap +++ b/packages/react-templates/src/components/Select/__tests__/__snapshots__/SimpleSelect.test.tsx.snap @@ -32,7 +32,7 @@ exports[`Matches snapshot 1`] = ` width="1em" > @@ -73,7 +73,7 @@ exports[`checkbox select with no props snapshot 1`] = ` width="1em" > diff --git a/packages/react-templates/src/components/Select/__tests__/__snapshots__/TypeaheadSelect.test.tsx.snap b/packages/react-templates/src/components/Select/__tests__/__snapshots__/TypeaheadSelect.test.tsx.snap index 6710ec530a8..1337206f752 100644 --- a/packages/react-templates/src/components/Select/__tests__/__snapshots__/TypeaheadSelect.test.tsx.snap +++ b/packages/react-templates/src/components/Select/__tests__/__snapshots__/TypeaheadSelect.test.tsx.snap @@ -85,7 +85,7 @@ exports[`Matches snapshot 1`] = ` width="1em" >