Ensure serial is not 000

Author: bombsimon

lib/Personnummer.pm

@@ -32,8 +32,8 @@ sub format {
 
     croak "cannot format invalid personal identity numbers" if not $self->valid();
 
-    my $year = $long_format ? $self->{date}->year : $self->{date}->year % 100;
-    my $day = $self->{is_coordination_number} ? $self->{date}->day + 60 : $self->{date}->day;
+    my $year = $long_format                    ? $self->{date}->year     : $self->{date}->year % 100;
+    my $day  = $self->{is_coordination_number} ? $self->{date}->day + 60 : $self->{date}->day;
 
     return
       sprintf( "%s%02d%02d-%03d%d", $year, $self->{date}->month, $day, $self->{serial}, $self->{control} );
@@ -62,7 +62,8 @@ sub valid {
         $self->{serial}
     );
 
-    return defined $self->{date} && _luhn( $pnr ) == ( $self->{control} // -1 );
+    return
+      defined $self->{date} && _luhn( $pnr ) == ( $self->{control} // -1 ) && ( $self->{serial} // -1 ) > 0;
 }
 
 sub is_female {

t/10-validate.t

@@ -20,7 +20,7 @@ subtest 'Valid personal identity numbers' => sub {
 };
 
 subtest 'Invalid personal identity numbers' => sub {
-    my @cases = ( "201702291236", "6403273814", "510819-9167", "640327-381", "640327-3814", );
+    my @cases = ( "201702291236", "6403273814", "510819-9167", "640327-381", "640327-3814", "20150916-0006" );
 
     foreach my $tc ( @cases ) {
         my $pnr = Personnummer->new( $tc );