Correctly get the name of the validation bots

Author: iMattPro

controller/manage/queue/item.php

@@ -481,17 +481,18 @@ protected function validate($action)
 
 		$post_as_robot = $this->request->variable('post_as_robot', 1);
 		$has_robot = !empty($this->contrib->type->forum_robot);
+		$robot_name = $has_robot ? \users_overlord::get_user($this->contrib->type->forum_robot, 'username', true) : '';
 
 		$this->template->assign_vars(array(
 			'ERROR'						=> implode('<br />', $error),
 			'L_TOPIC_REVIEW'			=> $this->user->lang['QUEUE_REVIEW'],
 			'TOPIC_TITLE'				=> $this->contrib->contrib_name,
 			'PAGE_TITLE_EXPLAIN'		=> $this->user->lang[strtoupper($action) . '_QUEUE_CONFIRM'],
 			'S_CONFIRM_ACTION'			=> $this->queue->get_url($action),
-			'S_SHOW_POST_AS_OPTION'		=> $has_robot,
+			'S_SHOW_POST_AS_OPTION'		=> $has_robot && $robot_name,
 			'POST_AS_ROBOT'				=> $post_as_robot,
+			'ROBOT_NAME'				=> $robot_name,
 			'POST_AS_LABEL'				=> $this->user->lang['POST_AS_' . strtoupper($action)],
-			'ROBOT_NAME'				=> ucfirst($this->contrib->type->name),
 		));
 
 		return false;

language/en/manage.php

@@ -86,7 +86,6 @@
 	'PLEASE_WAIT_FOR_TOOL'		=> 'Please wait for the tool to finish running.',
 	'POST_AS_APPROVE'			=> 'Approve as',
 	'POST_AS_DENY'				=> 'Deny as',
-	'POST_AS_ROBOT'				=> '%s Robot',
 	'POST_AS_SELF'				=> 'Yourself',
 	'PUBLIC_NOTES'				=> 'Public release notes',
 

styles/prosilver/template/manage/queue_validate.html

@@ -31,7 +31,7 @@ <h2>{{ PAGE_TITLE }}</h2>
 		<dl>
 			<dt style="width: auto"><label>{{ POST_AS_LABEL ~ lang('COLON') }}</label></dt>
 			<dd style="margin: 0 0 12px 10%">
-				<label><input type="radio" name="post_as_robot" value="1"{% if POST_AS_ROBOT %} checked="checked"{% endif %} />{{ lang('POST_AS_ROBOT', ROBOT_NAME) }}</label>
+				<label><input type="radio" name="post_as_robot" value="1"{% if POST_AS_ROBOT %} checked="checked"{% endif %} />{{ ROBOT_NAME }}</label>
 				<label><input type="radio" name="post_as_robot" value="0"{% if not POST_AS_ROBOT %} checked="checked"{% endif %} />{{ lang('POST_AS_SELF') }}</label>
 			</dd>
 		</dl>