Update command to run npm install for updateplotlyjs

Author: camdecoster

CONTRIBUTING.md

@@ -274,7 +274,21 @@ python commands.py updateplotlyjs
 
 This downloads new versions of `plot-schema.json` and `plotly.min.js` from the `plotly/plotly.js` GitHub repository
 and places them in `plotly/package_data`.
-It then regenerates all of the `graph_objs` classes based on the new schema.
+It then regenerates all of the `graph_objs` classes based on the new schema,
+and finally runs `npm install` in `js/` to refresh `js/package-lock.json` against the new `plotly.js`.
+Commit the updated `js/package-lock.json` along with the regenerated files.
+
+The JupyterLab extension and FigureWidget bundles in `plotly/labextension` and `plotly/package_data/widgetbundle.js`
+are rebuilt as part of the release flow (see [RELEASE.md](RELEASE.md)) rather than on every plotly.js bump.
+
+If you need to skip the `npm install` step entirely (e.g. `npm` isn't available),
+set the `SKIP_NPM=1` environment variable:
+
+```bash
+SKIP_NPM=1 python commands.py updateplotlyjs
+```
+
+If you do skip it, you'll need to run `npm install` in `js/` yourself before committing so the lockfile stays in sync.
 
 ### Using a Development Branch of Plotly.js
 
@@ -319,6 +333,6 @@ Usage: `python commands.py <subcommand> <args>`
 | `codegen [--noformat]` | Regenerate Python files according to `plot-schema.json`.`--noformat` skips formatter step. |
 | `lint` | Lint all Python code in `plotly/`. |
 | `format` | Format all Python code in `plotly/`. |
-| `updateplotlyjs` | Update `plotly.min.js` and `plot-schema.json` to match the `plotly.js` version specified in `js/package.json`. Then, run codegen to regenerate the Python files. |
+| `updateplotlyjs` | Update `plotly.min.js` and `plot-schema.json` to match the `plotly.js` version specified in `js/package.json`, run codegen to regenerate the Python files, then run `npm install` in `js/` to refresh `js/package-lock.json`. Set `SKIP_NPM=1` to skip the npm step. |
 | `updateplotlyjsdev [--devrepo REPONAME --devbranch BRANCHNAME] \| [--local PATH]` | Update `plot-schema.json` and `plotly.min.js` to match the version in the provided plotly.js repo name and branch name, OR local path. Then, run codegen to regenerate the Python files. |
 | `bumpversion X.Y.Z` | Update the plotly.py version number to X.Y.Z across all files where it needs to be updated. |

commands.py

@@ -44,8 +44,15 @@ def plotly_js_version():
     return version
 
 
-def install_js_deps(local):
-    """Install package.json dependencies using npm."""
+def install_js_deps(local, build=True):
+    """Install package.json dependencies using npm.
+
+    When ``build`` is True (the default), also runs ``npm run build`` to
+    rebuild the JupyterLab extension and FigureWidget bundles and verifies
+    that the widget bundle exists. Pass ``build=False`` when you only need
+    to refresh ``node_modules`` / ``package-lock.json`` (e.g. after a
+    plotly.js version bump) and don't need the bundles rebuilt.
+    """
 
     npmName = "npm"
     if platform.system() == "Windows":
@@ -86,18 +93,20 @@ def install_js_deps(local):
                 stdout=sys.stdout,
                 stderr=sys.stderr,
             )
-        check_call(
-            [npmName, "run", "build"],
-            cwd=NODE_ROOT,
-            stdout=sys.stdout,
-            stderr=sys.stderr,
-        )
+        if build:
+            check_call(
+                [npmName, "run", "build"],
+                cwd=NODE_ROOT,
+                stdout=sys.stdout,
+                stderr=sys.stderr,
+            )
         os.utime(NODE_MODULES, None)
 
-    for target in WIDGET_TARGETS:
-        if not os.path.exists(target):
-            msg = "Missing file: %s" % target
-            raise ValueError(msg)
+    if build:
+        for target in WIDGET_TARGETS:
+            if not os.path.exists(target):
+                msg = "Missing file: %s" % target
+                raise ValueError(msg)
 
 
 def overwrite_schema_local(uri):
@@ -215,6 +224,7 @@ def update_plotlyjs(plotly_js_version, outdir):
     update_bundle(plotly_js_version)
     update_schema(plotly_js_version)
     perform_codegen(outdir)
+    install_js_deps(local=None, build=False)
 
 
 # FIXME: switch to argparse