cleanup: PostgresNode does not support conn_params at all (#356)

Note that it is a critical change.

PostgresNode::__init__
- [del] argument conn_params

NodeBackup::spawn_primary
- always uses node.clone_with_new_name_and_base_dir to create a cloned object

Author: dmitry-lipetsk

src/backup.py

@@ -152,12 +152,7 @@ def spawn_primary(self, name=None, destroy=True):
         # Build a new PostgresNode
         assert self.original_node is not None
 
-        if (hasattr(self.original_node, "clone_with_new_name_and_base_dir")):
-            node = self.original_node.clone_with_new_name_and_base_dir(name=name, base_dir=base_dir)
-        else:
-            # For backward compatibility
-            NodeClass = self.original_node.__class__
-            node = NodeClass(name=name, base_dir=base_dir, conn_params=self.original_node.os_ops.conn_params)
+        node = self.original_node.clone_with_new_name_and_base_dir(name=name, base_dir=base_dir)
 
         assert node is not None
         assert type(node) is self.original_node.__class__

src/node.py

@@ -101,7 +101,6 @@
 
 from .backup import NodeBackup
 
-from testgres.operations.os_ops import ConnectionParams
 from testgres.operations.os_ops import OsOperations
 from testgres.operations.local_ops import LocalOperations
 
@@ -174,7 +173,6 @@ def __init__(self,
                  name=None,
                  base_dir=None,
                  port: typing.Optional[int] = None,
-                 conn_params: typing.Optional[ConnectionParams] = None,
                  bin_dir=None,
                  prefix=None,
                  os_ops: typing.Optional[OsOperations] = None,
@@ -194,11 +192,6 @@ def __init__(self,
         assert os_ops is None or isinstance(os_ops, OsOperations)
         assert port_manager is None or isinstance(port_manager, PortManager)
 
-        if conn_params is not None:
-            assert type(conn_params) is ConnectionParams
-
-            raise InvalidOperationException("conn_params is deprecated, please use os_ops parameter instead.")
-
         # private
         if os_ops is None:
             self._os_ops = __class__._get_os_ops()