Binner v2.4.1

[replaysMike]

Binner public release

Pre-release for testing if everything is working correctly, from bugs introduced with v2.4.0

---

This discussion was created from the release Binner v2.4.1.

[pdo59]

Hello Mike,
this 2.4.1 is almost perfect! The PartTypes page is now ok. I would like the total quantity of a parent part type to also contain the quantities of its children.

• In the "Inventory page" word search does not work yet.
• The Digikey credentials problem remains: I am redirected to the Digikey site for authentication, I enter my login and my password and once successfully authenticated I get this message:
  {"ErrorCode" : "invalid_request", "Error" :"Invalid redirect URI https://localhost:8090/Authorization/Authorize"}
  I fixed this with an INSERT into the "OauthCredentials" table, but I believe this is still a bug.
  That's all at the moment.

I continue with the update of the Italian translation.

[replaysMike]

I would like the total quantity of a parent part type to also contain the quantities of its children.

I didn't notice this wasn't working as intended, had to check my inventory and count manually and realized the parent is only showing it's parts. It'll be complicated to query recursively, which is probably why I didn't do it in the first place. Going to work on this now as I agree this would be way more useful.

• In the "Inventory page" word search does not work yet.

Can you clarify this one? I'm not quite sure what you mean. The search page that shows inventory seems working to me, as does the Add Inventory page. Unless it's one of the other storage providers that isn't working

• The Digikey credentials problem remains: I am redirected to the Digikey site for authentication, I enter my login and my password and once successfully authenticated I get this message:
  {"ErrorCode" : "invalid_request", "Error" :"Invalid redirect URI https://localhost:8090/Authorization/Authorize"}
  I fixed this with an INSERT into the "OauthCredentials" table, but I believe this is still a bug.

This one is still eluding me but I'll keep digging

[replaysMike]

@pdo59 I've fixed the issue regarding the DigiKey site error when authenticating, your hint helped me find the issue. Will include in v2.4.3

[pdo59]

Great thing Mike!
About the search in Inventory page, I believe that the problem is in your search query; below there is your "simplified" query:
WITH PartsExactMatch (PartId, Rank) AS ( SELECT PartId, 10 as Rank FROM Parts WHERE UserId = 1 and PartNumber = 'BC557' OR DigiKeyPartNumber = 'BC557' ), PartsBeginsWith (partId, Rank) AS ( SELECT PartId, 100 as Rank FROM Parts WHERE UserId = 1 and PartNumber like 'BC557' + '%' OR DigiKeyPartNumber like 'BC557' + '%' ), PartsAny (PartId, Rank) AS ( SELECT PartId, 200 as Rank FROM Parts WHERE UserId = 1 and PartNumber like '%' + 'BC557' + '%' or DigiKeyPartNumber like '%' + 'BC557' + '%' ), PartsMerged (PartId, Rank) AS ( SELECT PartId, Rank From PartsExactMatch UNION SELECT PartId, Rank From PartsBeginsWith UNION SELECT PartId, Rank From PartsAny ) Select p.* from Parts p INNER JOIN ( SELECT PartId, MIN(Rank) Rank FROM PartsMerged GROUP BY PartId ) pm ON pm.PartId = p.PartId ORDER BY pm.Rank ASC

The query uses a '+' operator to concatenate the string, this way the like doesn't work. In MySql/Mariadb the CONCAT() function or space between strings should be used instead.
I hope this helps you in solving the problem.

[replaysMike]

Interesting find - I have MariaDb 10.6.5 installed and it works well with it. I'm going to install MySql on top and test it as well - I believe your findings as Sqlite has a similar issue. Shouldn't take me long to confirm

[replaysMike]

Neat - it was actually 2 different issues. MySql doesn't like the Rank keyword as apparently it's a reserved word, but it's not an issue in MariaDb.

Also good catch with string concatenation as MySql only likes CONCAT, and doesn't support the ANSI standard of || out of the box without enabling PIPES_AS_CONCAT. MariaDb will use || however it gives incorrect results but CONCAT works on both well.

Patch coming up.