fix: remove proxy for api client requests & resolve localhost requests (#276)

Author: Aarushsr12

src/main/actions/getProxiedAxios.ts

@@ -2,11 +2,54 @@ import axios, { AxiosInstance } from "axios";
 import { readFileSync } from "fs";
 import { HttpsProxyAgent, HttpsProxyAgentOptions } from "https-proxy-agent";
 import { ClientRequest, RequestOptions } from "agent-base";
+import { Socket } from "net";
+import http from "http";
+import https from "https";
 import {
   addCookiesToRequest,
   storeCookiesFromResponse,
 } from "./cookiesHelpers";
 
+const LOCAL_IPV4 = "127.0.0.1";
+const LOCAL_IPV6 = "::1";
+
+const checkConnection = (host: string, port: number): Promise<boolean> => {
+  return new Promise((resolve) => {
+    const socket = new Socket();
+    const timeout = 1000;
+
+    socket.setTimeout(timeout);
+
+    socket.once("connect", () => {
+      socket.destroy();
+      resolve(true);
+    });
+
+    socket.once("timeout", () => {
+      socket.destroy();
+      resolve(false);
+    });
+
+    socket.once("error", () => {
+      socket.destroy();
+      resolve(false);
+    });
+
+    socket.connect(port, host);
+  });
+};
+
+
+const createLocalhostLookup = async (port: number) => {
+  const ipv6Works = await checkConnection(LOCAL_IPV6, port).catch(() => false);
+  const targetIp = ipv6Works ? LOCAL_IPV6 : LOCAL_IPV4;
+  const targetFamily = ipv6Works ? 6 : 4;
+
+  return (_lookupHostname: string, _options: any, callback: any) => {
+    callback(null, targetIp, targetFamily);
+  };
+};
+
 class PatchedHttpsProxyAgent extends HttpsProxyAgent {
   ca: unknown;
 
@@ -32,17 +75,48 @@ let proxyConfig: ProxyConfig;
 
 function createAxiosInstance(
   config: ProxyConfig,
+  enableRQProxy: boolean = false,
   addStoredCookies: boolean = false
 ): AxiosInstance {
-  const instance = axios.create({
-    proxy: false,
-    httpAgent: new HttpsProxyAgent(`http://${config.ip}:${config.port}`),
-    httpsAgent: new PatchedHttpsProxyAgent({
-      host: config.ip,
-      port: config.port,
-      ca: readFileSync(config.rootCertPath),
-    }),
-  });
+  let instance: AxiosInstance;
+  if (enableRQProxy) {
+    instance = axios.create({
+      proxy: false,
+      httpAgent: new HttpsProxyAgent(`http://${config.ip}:${config.port}`),
+      httpsAgent: new PatchedHttpsProxyAgent({
+        host: config.ip,
+        port: config.port,
+        ca: readFileSync(config.rootCertPath),
+      }),
+    });
+  } else {
+    instance = axios.create({
+      proxy: false,
+    });
+
+    instance.interceptors.request.use(async (requestConfig) => {
+      const { url: requestUrl } = requestConfig;
+
+      if (!requestUrl) {
+        return requestConfig;
+      }
+
+      const url = new URL(requestUrl);
+      const { hostname, port: urlPort, protocol } = url;
+
+      if (hostname === "localhost" || hostname === LOCAL_IPV6 || hostname === LOCAL_IPV4) { 
+        // convert string port to integer
+        const port = urlPort ? parseInt(urlPort, 10) : protocol === "https:" ? 443 : 80;
+
+        const lookup = await createLocalhostLookup(port);
+
+        requestConfig.httpAgent = new http.Agent({ lookup });
+        requestConfig.httpsAgent = new https.Agent({ lookup });
+      }
+
+      return requestConfig;
+    });
+  }
 
   instance.interceptors.response.use(storeCookiesFromResponse);
   if (addStoredCookies) {
@@ -60,8 +134,12 @@ export const createOrUpdateAxiosInstance = (
   };
 
   try {
-    proxiedAxios = createAxiosInstance(proxyConfig);
-    proxiedAxiosWithSessionCookies = createAxiosInstance(proxyConfig, true);
+    proxiedAxios = createAxiosInstance(proxyConfig, false);
+    proxiedAxiosWithSessionCookies = createAxiosInstance(
+      proxyConfig,
+      false,
+      true
+    );
   } catch (error) {
     /* Do nothing */
     console.error("Error creating or updating Axios instance:", error);