Test fixes.

Author: ilijaljubicic

CLAUDE.md

@@ -11,11 +11,11 @@ ReqFlow is an AI-driven framework for system modeling and requirements managemen
 - **Linting**: Modular system for validating and fixing markdown formatting issues
 
 ## Command Line Usage
-- Initialize ReqFlow: `reqflow init`
-- Validate requirements: `reqflow validate specifications/`
-- Generate HTML: `reqflow specifications/ output/ --html`
-- Lint requirements: `reqflow --lint specifications/`
-- Generate diagrams: `reqflow --lint specifications/ --generate-diagrams`
+- Validate requirements: `reqflow --validate`
+- Generate HTML: `reqflow --html`
+- Lint requirements: `reqflow --lint --dry-run`
+- Generate diagrams: `reqflow --generate-diagrams`
+- Show Change Impact: `reqflow --change-impact --git-comit=HEAD~1`
 
 ## Build and Test Commands
 - Build: `cargo build`
@@ -25,18 +25,10 @@ ReqFlow is an AI-driven framework for system modeling and requirements managemen
 - Lint: `cargo clippy -- -D warnings`
 - Format: `cargo fmt`
 
-## Dependencies
-- Markdown parsing: `pulldown-cmark`  
-- HTML generation: `maud`
-- Path handling: `camino`
-- Command line: `clap` with derive feature
-- Regex: `regex`
 
 ## Key File Locations
-- Configuration example: `reqflow.yml.example`
-- Design specifications: `specifications/DesignSpecifications/`
-- Test fixtures: `test-fixtures/`
-- E2E tests: `tests/e2e-*/`
+- Requirements and Specifications: `specifications/**/*.md`
+- E2E tests: `tests/*/`
 
 ## Code Style Guidelines
 - Follow Rust standard naming conventions

tests/test-excluded-patterns/specifications/DesignSpecifications/DirectMessages.md

@@ -0,0 +1,16 @@
+# Design Specification: Excluded File
+
+This file should be excluded from processing.
+
+## Overview
+
+This document describes the design of a feature.
+
+### DSD-001 Design Element
+
+This is a design element that should not be processed.
+
+```markdown
+
+Test.
+```

tests/test-excluded-patterns/specifications/SystemRequirements/ValidFile.md

@@ -9,7 +9,7 @@ This file should be processed.
 This is a system requirement.
 
 #### Metadata
-  * type: requirement
+  * type: user-requirement
 
 #### Relations
   * satisfiedBy: [../DesignSpecifications/ExcludedFile.md](../DesignSpecifications/ExcludedFile.md)
@@ -21,8 +21,8 @@ This is a system requirement.
 Users must be able to send direct messages to other users.
 
 #### Metadata
-* type: requirement
+* type: user-requirement
 * priority: high
 
 #### Relations
-* satisfiedBy: [DesignSpecifications/DirectMessages.md](DesignSpecifications/DirectMessages.md)  
+* satisfiedBy: [../DesignSpecifications/DirectMessages.md](../DesignSpecifications/DirectMessages.md)  

tests/test-excluded-patterns/test.sh

@@ -17,20 +17,24 @@ OUTPUT=$(cd "$TEST_DIR" && "$REQFLOW_BIN" --config "${TEST_DIR}/reqflow.yaml"  -
 EXIT_CODE=$?
 
 
+
 printf "%s\n" "$OUTPUT" > "${TEST_DIR}/test_results.log"
 
+if [[ $EXIT_CODE -ne 0 ]]; then
+    exit $EXIT_CODE
+fi
+
+
 # There should be no errors about excluded file relations being invalid
-if echo "$OUTPUT" | grep -q "Missing relation target.*DesignSpecifications/ExcludedFile.md"; then
+if echo "$OUTPUT" | grep -q "Missing relation target"; then
   echo "FAILED: Relation to excluded file was incorrectly reported as invalid"
   exit 1
 fi
 
 # There should also be no elements from excluded files in the registry
-# Check this by looking for validation of relations FROM excluded files
-# This is trickier to test without having access to the internal registry
-# We'll use a heuristic: if the relation from DSD-001 is validated, it means 
-# the element was processed, which is incorrect
-if echo "$OUTPUT" | grep -q "DSD-001"; then
+OUTPUT=$(cd "$TEST_DIR" && "$REQFLOW_BIN" --config "${TEST_DIR}/reqflow.yaml"  --model-summary | grep -n 'Element:')
+
+if echo "$OUTPUT" | grep -q "DesignSpecifications"; then
   echo "FAILED: Elements from excluded files are being processed"
   exit 1
 fi

tests/test-external-folders/test.sh

@@ -7,7 +7,7 @@ EXIT_CODE=$?
 printf "%s\n" "$OUTPUT" > "${TEST_DIR}/test_results.log"
 
 
-if [[ $status -ne 0 ]]; then
+if [[ $EXIT_CODE -ne 0 ]]; then
     exit $EXIT_CODE
 fi
 

tests/test-fragment-relations/test.sh

@@ -28,7 +28,6 @@ if [ $EXIT_CODE -ne 0 ]; then
   exit 1
 fi
 
-
 # Verify that successful validation message is displayed
 if ! echo "$OUTPUT" | grep -q "Validation completed successfully with no errors."; then
   echo "FAILED: Missing success message for relation validation"

tests/test-invalid-relations/test.sh

@@ -3,15 +3,15 @@
 # Test: Validation of Invalid Relation Types and Formats
 # ----------------------------------------------------
 # Acceptance Criteria:
-# - System should detect and report invalid relation types (typos, etc.)
-# - System should detect and report relations to non-existent targets
-# - System should detect and report if system requirement is missing parent relation
-# - System should detect and report if there is circular dependency in requirements
-# - System should detect and report if relation type has incompactible element
-# - System should detect and report invalid metadata subsection format
-# - System should detect and report duplicate relations in Relations subsection
-# - System should detect and report duplicate elements
-# - System should detect and report duplicate subsections
+# - System should detect and report Duplicate element
+# - System should detect and report Invalid metadata format
+# - System should detect and report Invalid relation format
+# - System should detect and report Unsupported relation type
+# - System should detect and report Invalid identifier
+# - System should detect and report Duplicate subsection
+# - System should detect and report Incompatible element types for relation
+# - System should detect and report Circular dependency error
+# - System should detect and report Missing parent relation"
 #
 # Test Criteria:
 # - Command exits with 0 error code but outputs expected validation errors

tests/test-lint-expected/test.sh

@@ -3,14 +3,13 @@
 # Test: Whitespace Linting Functionality
 # --------------------------------------
 # Acceptance Criteria:
-# - System should detect excess whitespace after headers
-# - System should fix excess whitespace in linting mode
-# - The output should show before/after changes
+# - The dry-run output should show before/after changes with specific expected lint commands to be applied
+# - The lint should apply expected fixes
 #
 # Test Criteria:
 # - Command exits with success (0) return code
-# - Output shows whitespace being fixed
-# - Output should contain diff-style formatting
+# - Dry-run Output should contain diff-style formatting
+# - The lint should apply expected fixes and produce expected output
 #