Skip to content

Commit 814bfca

Browse files
fix: rescript-legacy broken for ppx's (#8103)
This resolves PPX errors with "Ill-formed list of warnings" after removal of -bs-v flag. The mtime from being appended to the -bs-v flag, after the change in #7627 it was being appended to the warnings flag instead, causing the compiler error Fixes #8090 Signed-off-by: Rob <illusionalsagacity@users.noreply.github.com> Co-authored-by: Christoph Knittel <ck@cca.io>
1 parent 4afaab9 commit 814bfca

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
- Formatter: normalize underscore placeholders in pipe expressions to canonical form (e.g., `a->map2(_, fn)` formats to `a->map2(fn)`). https://github.com/rescript-lang/rescript/pull/8033
3030
- Fix rewatch panic on duplicate module name. https://github.com/rescript-lang/rescript/pull/8102
3131
- Fix `let?` unwrap to use actual variable names from pattern instead of hardcoded "x"/"e". When using `let? Some(myVar) = ...`, the variable name `myVar` is now properly propagated in early returns. https://github.com/rescript-lang/rescript/issues/8085
32+
- Fix 'Ill-formed list of warnings' errors for ppx's with rescript-legacy. https://github.com/rescript-lang/rescript/pull/8103
3233

3334
#### :memo: Documentation
3435

compiler/bsb/bsb_ninja_rule.ml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,6 @@ let make_custom_rules ~(gentype_config : Bsb_config_types.gentype_config)
145145
(match ppx_files with
146146
| [] -> ()
147147
| _ ->
148-
Ext_list.iter ppx_files (fun x ->
149-
match string_of_float (Unix.stat x.name).st_mtime with
150-
| exception _ -> ()
151-
| st -> Ext_buffer.add_char_string buf ',' st);
152148
Ext_buffer.add_char_string buf ' ' (Bsb_build_util.ppx_flags ppx_files));
153149
(match pp_file with
154150
| None -> ()

0 commit comments

Comments
 (0)