update CCI chart legend

Author: rosasurfer

mql40/include/rsf/core/indicator.mqh

@@ -100,7 +100,7 @@ int init() {
    // before onInit(): log input parameters if loaded by iCustom()
    if (__isSuperContext && IsLogDebug()) {
       string sInputs = InputsToStr();
-      if (StringLen(sInputs) > 0) {
+      if (sInputs != "") {
          sInputs = StringConcatenate(sInputs,                                                        NL,
                                      "AutoConfiguration=", AutoConfiguration,                   ";", NL,
                                      "__lpSuperContext=",  "0x", IntToHexStr(__lpSuperContext), ";");

mql40/include/rsf/indicators/chartinfos/init.mqh

@@ -136,12 +136,12 @@ int afterInit() {
 
       // setup a chart ticker
       if (!__virtualTicksTimerId) {
-         int hWnd = __ExecutionContext[EC.chart];
-         int millis = 2000;                                          // once every 2 seconds
+         int hWnd = __ExecutionContext[EC.chart], milliseconds;
 
          if (StrStartsWithI(GetAccountServer(), "XTrade-")) {
-            // offline ticker to update chart data in synthetic charts
-            __virtualTicksTimerId = SetupTickTimer(hWnd, millis, TICK_CHART_REFRESH|TICK_IF_WINDOW_VISIBLE);
+            // offline ticker to update synthetic charts
+            milliseconds = 1000;
+            __virtualTicksTimerId = SetupTickTimer(hWnd, milliseconds, TICK_CHART_REFRESH|TICK_IF_WINDOW_VISIBLE);
             if (!__virtualTicksTimerId) return(catch("afterInit(1)->SetupTickTimer(hWnd="+ IntToHexStr(hWnd) +") failed", ERR_RUNTIME_ERROR));
 
             // display ticker status
@@ -153,8 +153,9 @@ int afterInit() {
             ObjectSetText(label, "n", 6, "Webdings", LimeGreen);     // a "dot" marker, Green = online
          }
          else {
-            // virtual ticks to update chart infos on a slow data feed
-            __virtualTicksTimerId = SetupTickTimer(hWnd, millis, TICK_IF_WINDOW_VISIBLE);
+            // virtual ticks to update chart infos/custom positions without waiting for the next tick
+            milliseconds = 600;
+            __virtualTicksTimerId = SetupTickTimer(hWnd, milliseconds, TICK_IF_WINDOW_VISIBLE);
             if (!__virtualTicksTimerId) return(catch("afterInit(2)->SetupTickTimer(hWnd="+ IntToHexStr(hWnd) +") failed", ERR_RUNTIME_ERROR));
          }
       }

mql40/indicators/CCI.mq4

@@ -1,7 +1,7 @@
 /**
  * Commodity Channel Index - a true momentum indicator. Measures sudden price acceleration.
  *
- * Defined as the upscaled ratio of the current distance to average distance from a Moving Average (default: SMA).
+ * Defined as the upscaled ratio of current distance to average distance from a Moving Average (default: SMA).
  * The upscaling factor of 66.67 was chosen so that the majority of indicator values falls between +200 and -200.
  * Signal level is +/-100.
  */
@@ -57,18 +57,16 @@ extern string Signal.Sound.Down              = "Signal Down.wav";
 #property indicator_minimum  -180
 
 double cci     [];                                 // all CCI values
-double cciLong [];                                 // long trade segments
-double cciShort[];                                 // short trade segments
-double trend   [];                                 // trade segment length
+double cciLong [];                                 // long colored CCI values
+double cciShort[];                                 // short colored CCI values
+double trend   [];                                 // last color segment length
 
-int    appliedPrice;
+int appliedPrice;
 
-bool   signal.sound;
-bool   signal.alert;
-bool   signal.mail;
-bool   signal.telegram;
-
-string indicatorName = "";
+bool signal.sound;
+bool signal.alert;
+bool signal.mail;
+bool signal.telegram;
 
 // parameter stepper directions
 #define STEP_UP    1
@@ -276,8 +274,9 @@ bool onTrendChange(int direction) {
 
    // skip the signal if it was already handled elsewhere
    string sPeriod   = PeriodDescription();
-   string eventName = "rsf::"+ StdSymbol() +","+ sPeriod +"."+ indicatorName +".onTrendChange("+ direction +")."+ TimeToStr(Time[0]), propertyName = "";
-   string message1  = indicatorName +" signal "+ ifString(direction==MODE_LONG, "long", "short") +" (bid: "+ NumberToStr(_Bid, PriceFormat) +")";
+   string indicator = "CCI("+ Periods +")";
+   string eventName = "rsf::"+ StdSymbol() +","+ sPeriod +"."+ indicator +".onTrendChange("+ direction +")."+ TimeToStr(Time[0]), propertyName = "";
+   string message1  = indicator +" "+ ifString(direction==MODE_LONG, "long", "short") +" signal (bid: "+ NumberToStr(_Bid, PriceFormat) +")";
    string message2  = Symbol() +","+ PeriodDescription() +": "+ message1;
    string localTime = TimeToStr(TimeLocalEx("onTrendChange(2)"), TIME_MINUTES|TIME_SECONDS);
    string accountAlias = GetAccountAlias();
@@ -416,8 +415,9 @@ bool SetIndicatorOptions(bool redraw = false) {
    redraw = redraw!=0;
 
    string stepSize = ifString(Periods.Step, ":"+ Periods.Step, "");
-   indicatorName = "CCI("+ Periods + stepSize +")";
-   IndicatorShortName(indicatorName);
+   string sSignal  = ifString(Signal.onTrendChange, " signal", "");
+   string name     = "CCI("+ Periods + stepSize +")"+ sSignal;
+   IndicatorShortName(name);                          // subwindow chart legend
 
    IndicatorBuffers(indicator_buffers);
    SetIndexBuffer(MODE_MAIN,  cci     );
@@ -430,10 +430,10 @@ bool SetIndicatorOptions(bool redraw = false) {
    SetIndexDrawBegin(MODE_LONG,  drawBegin);
    SetIndexDrawBegin(MODE_SHORT, drawBegin);
 
-   SetIndexLabel(MODE_MAIN,  "CCI("+ Periods +")");   // displays values in indicator and "Data" window
+   SetIndexLabel(MODE_MAIN,  "CCI("+ Periods +")");   // "Data" window labels
    SetIndexLabel(MODE_LONG,  NULL);
    SetIndexLabel(MODE_SHORT, NULL);
-   SetIndexLabel(MODE_TREND, NULL);                   // prevents trend value in indicator window
+   SetIndexLabel(MODE_TREND, NULL);
 
    SetIndexStyle(MODE_MAIN,  DRAW_NONE);
    SetIndexStyle(MODE_TREND, DRAW_NONE);

mql40/indicators/ZigZag.mq4

@@ -1784,7 +1784,7 @@ bool SetIndicatorOptions(bool redraw = false) {
    IndicatorBuffers(terminal_buffers);
    SetIndexBuffer(MODE_UPPER_BAND,      upperBand     ); SetIndexEmptyValue(MODE_UPPER_BAND,       0); SetIndexLabel(MODE_UPPER_BAND,      donchianName +" upper band");  if (!Donchian.ShowChannel) SetIndexLabel(MODE_UPPER_BAND,      NULL);
    SetIndexBuffer(MODE_LOWER_BAND,      lowerBand     ); SetIndexEmptyValue(MODE_LOWER_BAND,       0); SetIndexLabel(MODE_LOWER_BAND,      donchianName +" lower band");  if (!Donchian.ShowChannel) SetIndexLabel(MODE_LOWER_BAND,      NULL);
-   SetIndexBuffer(MODE_SEMAPHORE_OPEN,  semaphoreOpen ); SetIndexEmptyValue(MODE_SEMAPHORE_OPEN,   0);                                                                                              SetIndexLabel(MODE_SEMAPHORE_OPEN,  NULL);
+   SetIndexBuffer(MODE_SEMAPHORE_OPEN,  semaphoreOpen ); SetIndexEmptyValue(MODE_SEMAPHORE_OPEN,   0);                                                                                               SetIndexLabel(MODE_SEMAPHORE_OPEN,  NULL);
    SetIndexBuffer(MODE_SEMAPHORE_CLOSE, semaphoreClose); SetIndexEmptyValue(MODE_SEMAPHORE_CLOSE,  0); SetIndexLabel(MODE_SEMAPHORE_CLOSE, shortName +" high/low");       if (!ZigZag.Width)         SetIndexLabel(MODE_SEMAPHORE_CLOSE, NULL);
    SetIndexBuffer(MODE_UPPER_CROSS,     upperCross    ); SetIndexEmptyValue(MODE_UPPER_CROSS,      0); SetIndexLabel(MODE_UPPER_CROSS,     shortName +" extension up");   if (!crossingDrawType)     SetIndexLabel(MODE_UPPER_CROSS,     NULL);
    SetIndexBuffer(MODE_LOWER_CROSS,     lowerCross    ); SetIndexEmptyValue(MODE_LOWER_CROSS,      0); SetIndexLabel(MODE_LOWER_CROSS,     shortName +" extension down"); if (!crossingDrawType)     SetIndexLabel(MODE_LOWER_CROSS,     NULL);