Sort execution asc by default

Author: runabol

README.md

@@ -890,14 +890,14 @@ By default, returns the full job (definition, execution tasks, context, etc.). P
 ### Get job execution
 
 ```shell
-GET /jobs/<JOB_ID>/execution?page=1&size=25&sort=desc
+GET /jobs/<JOB_ID>/execution?page=1&size=25
 ```
 
 Returns a paginated list of execution tasks as `TaskSummary` objects. Query params:
 
 - `page` – page number (default: `1`)
 - `size` – page size (default: `25`, max: `100`)
-- `sort` – `desc` (default, most recently started first) or `asc` (matches full job execution order)
+- `sort` – `asc` (default, matches full job execution order) or `desc` (most recently started first)
 
 ### Submit a job
 

datastore/postgres/postgres_test.go

@@ -679,21 +679,21 @@ func TestPostgresGetJobExecution(t *testing.T) {
 		assert.NoError(t, err)
 	}
 
-	page, err := ds.GetJobExecution(ctx, j1.ID, 1, 2, "desc")
+	page, err := ds.GetJobExecution(ctx, j1.ID, 1, 2, "asc")
 	assert.NoError(t, err)
 	assert.Equal(t, 1, page.Number)
 	assert.Equal(t, 2, len(page.Items))
 	assert.Equal(t, 5, page.TotalItems)
 	assert.Equal(t, 3, page.TotalPages)
-	assert.Equal(t, "task-5", page.Items[0].Name)
-	assert.Equal(t, "task-4", page.Items[1].Name)
-
-	page, err = ds.GetJobExecution(ctx, j1.ID, 1, 2, "asc")
-	assert.NoError(t, err)
 	assert.Equal(t, "task-1", page.Items[0].Name)
 	assert.Equal(t, "task-2", page.Items[1].Name)
 
-	_, err = ds.GetJobExecution(ctx, "not-a-job", 1, 10, "desc")
+	page, err = ds.GetJobExecution(ctx, j1.ID, 1, 2, "desc")
+	assert.NoError(t, err)
+	assert.Equal(t, "task-5", page.Items[0].Name)
+	assert.Equal(t, "task-4", page.Items[1].Name)
+
+	_, err = ds.GetJobExecution(ctx, "not-a-job", 1, 10, "asc")
 	assert.ErrorIs(t, err, datastore.ErrJobNotFound)
 }
 

internal/coordinator/api/api.go

@@ -464,12 +464,12 @@ func (s *API) getJob(c echo.Context) error {
 // @Param id path string true "Job ID"
 // @Param page query int false "page number"
 // @Param size query int false "page size"
-// @Param sort query string false "sort order (desc or asc, default: desc)"
+// @Param sort query string false "sort order (asc or desc, default: asc)"
 func (s *API) getJobExecution(c echo.Context) error {
 	id := c.Param("id")
 	sort := c.QueryParam("sort")
 	if sort == "" {
-		sort = "desc"
+		sort = "asc"
 	}
 	if sort != "desc" && sort != "asc" {
 		return echo.NewHTTPError(http.StatusBadRequest, fmt.Sprintf("invalid sort: %s", sort))

internal/coordinator/api/api_test.go

@@ -490,10 +490,10 @@ func Test_getJobExecution(t *testing.T) {
 	assert.Equal(t, 2, len(page.Items))
 	assert.Equal(t, 5, page.TotalItems)
 	assert.Equal(t, 3, page.TotalPages)
-	assert.Equal(t, "task-5", page.Items[0].Name)
-	assert.Equal(t, "task-4", page.Items[1].Name)
+	assert.Equal(t, "task-1", page.Items[0].Name)
+	assert.Equal(t, "task-2", page.Items[1].Name)
 
-	req, err = http.NewRequest("GET", fmt.Sprintf("/jobs/%s/execution?page=1&size=2&sort=asc", j1.ID), nil)
+	req, err = http.NewRequest("GET", fmt.Sprintf("/jobs/%s/execution?page=1&size=2&sort=desc", j1.ID), nil)
 	assert.NoError(t, err)
 	w = httptest.NewRecorder()
 	api.server.Handler.ServeHTTP(w, req)
@@ -502,8 +502,8 @@ func Test_getJobExecution(t *testing.T) {
 	assert.NoError(t, err)
 	err = json.Unmarshal(body, &page)
 	assert.NoError(t, err)
-	assert.Equal(t, "task-1", page.Items[0].Name)
-	assert.Equal(t, "task-2", page.Items[1].Name)
+	assert.Equal(t, "task-5", page.Items[0].Name)
+	assert.Equal(t, "task-4", page.Items[1].Name)
 	assert.NoError(t, ds.Close())
 }