Skip to content

Bug: "Select Catagory" as a input.value causes a waste of a fetch request. #5

@MohamedBakoush

Description

@MohamedBakoush

For getApis() at app.js the input.value isn't checked to see if a valid category is selected causing the system to waste fetch requests if an invalid category was selected.

Apihouse/app.js

Lines 20 to 26 in 4b3243b

async function getApis() {
apiList.innerHTML = "";
count.textContent = "";
let category = input.value;
renderLoader();
fetch(`https://api.publicapis.org/entries?category=${category}&https=true`)

To Reproduce
Steps to reproduce the behaviour:

  1. Selected "Select Catagory" as a Catagory
  2. Click "show API's"
  3. See "Sorry, Something went wrong !" error

Potential Solution

A simple solution would be to put a validity checker above renderLoader() by exiting getApis() function if a category == "Select Category". As "Select Category" is the only available invalid selectable category from the current option's, making a simple if statement all that's needed to fix this bug.

if (category === "Select Category") return;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions