refactor: deduplicate common function (renovatebot#36641)

Author: RahulGautamSingh

lib/workers/repository/init/apis.ts

@@ -1,4 +1,3 @@
-import { configFileNames } from '../../../config/app-strings';
 import type { RenovateConfig } from '../../../config/types';
 import {
   REPOSITORY_DISABLED_BY_CONFIG,
@@ -7,18 +6,13 @@ import {
 import { logger } from '../../../logger';
 import type { RepoParams, RepoResult } from '../../../modules/platform';
 import { platform } from '../../../modules/platform';
+import { getDefaultConfigFileName } from '../onboarding/common';
 
 // TODO: fix types (#22198)
 export type WorkerPlatformConfig = RepoResult &
   RenovateConfig &
   Record<string, any>;
 
-// TODO #22198
-const getDefaultConfigFile = (config: RenovateConfig): string =>
-  configFileNames.includes(config.onboardingConfigFileName!)
-    ? config.onboardingConfigFileName!
-    : configFileNames[0];
-
 async function getJsonFile(file: string): Promise<RenovateConfig | null> {
   try {
     return await platform.getJsonFile(file);
@@ -31,7 +25,7 @@ async function validateOptimizeForDisabled(
   config: RenovateConfig,
 ): Promise<void> {
   if (config.optimizeForDisabled) {
-    const renovateConfig = await getJsonFile(getDefaultConfigFile(config));
+    const renovateConfig = await getJsonFile(getDefaultConfigFileName(config));
     if (renovateConfig?.enabled === false) {
       throw new Error(REPOSITORY_DISABLED_BY_CONFIG);
     }
@@ -63,7 +57,7 @@ async function validateOptimizeForDisabled(
 
 async function validateIncludeForks(config: RenovateConfig): Promise<void> {
   if (config.forkProcessing !== 'enabled' && config.isFork) {
-    const defaultConfigFile = getDefaultConfigFile(config);
+    const defaultConfigFile = getDefaultConfigFileName(config);
     const repoConfig = await getJsonFile(defaultConfigFile);
     if (!repoConfig) {
       logger.debug(

lib/workers/repository/init/merge.ts

@@ -28,13 +28,15 @@ import { maskToken } from '../../../util/mask';
 import { regEx } from '../../../util/regex';
 import { parseAndValidateOrExit } from '../../global/config/parse/env';
 import { getOnboardingConfig } from '../onboarding/branch/config';
-import { getDefaultConfigFileName } from '../onboarding/branch/create';
 import {
   getOnboardingConfigFromCache,
   getOnboardingFileNameFromCache,
   setOnboardingConfigDetails,
 } from '../onboarding/branch/onboarding-branch-cache';
-import { OnboardingState } from '../onboarding/common';
+import {
+  OnboardingState,
+  getDefaultConfigFileName,
+} from '../onboarding/common';
 import type { RepoFileConfig } from './types';
 
 export async function detectConfigFile(): Promise<string | null> {

lib/workers/repository/onboarding/branch/create.ts

@@ -1,23 +1,12 @@
-import { configFileNames } from '../../../../config/app-strings';
 import { GlobalConfig } from '../../../../config/global';
 import type { RenovateConfig } from '../../../../config/types';
 import { logger } from '../../../../logger';
 import { scm } from '../../../../modules/platform/scm';
 import { compile } from '../../../../util/template';
+import { getDefaultConfigFileName } from '../common';
 import { OnboardingCommitMessageFactory } from './commit-message';
 import { getOnboardingConfigContents } from './config';
 
-const defaultConfigFile = configFileNames[0];
-
-export function getDefaultConfigFileName(
-  config: Partial<RenovateConfig>,
-): string {
-  // TODO #22198
-  return configFileNames.includes(config.onboardingConfigFileName!)
-    ? config.onboardingConfigFileName!
-    : defaultConfigFile;
-}
-
 export async function createOnboardingBranch(
   config: Partial<RenovateConfig>,
 ): Promise<string | null> {

lib/workers/repository/onboarding/branch/rebase.ts

@@ -3,7 +3,7 @@ import type { RenovateConfig } from '../../../../config/types';
 import { logger } from '../../../../logger';
 import { scm } from '../../../../modules/platform/scm';
 import { toSha256 } from '../../../../util/hash';
-import { defaultConfigFile } from '../common';
+import { getDefaultConfigFileName } from '../common';
 import { OnboardingCommitMessageFactory } from './commit-message';
 import { getOnboardingConfigContents } from './config';
 
@@ -22,7 +22,7 @@ export async function rebaseOnboardingBranch(
     return null;
   }
 
-  const configFile = defaultConfigFile(config);
+  const configFile = getDefaultConfigFileName(config);
   const contents = await getOnboardingConfigContents(config, configFile);
   const currentConfigHash = toSha256(contents);
 

lib/workers/repository/onboarding/common.ts

@@ -7,7 +7,7 @@ export function getSemanticCommitPrTitle(config: RenovateConfig): string {
   return `${config.semanticCommitType ?? 'chore'}: ${config.onboardingPrTitle}`;
 }
 
-export function defaultConfigFile(config: RenovateConfig): string {
+export function getDefaultConfigFileName(config: RenovateConfig): string {
   return configFileNames.includes(config.onboardingConfigFileName!)
     ? config.onboardingConfigFileName!
     : configFileNames[0];

lib/workers/repository/onboarding/pr/config-description.ts

@@ -1,11 +1,9 @@
 import is from '@sindresorhus/is';
-import { configFileNames } from '../../../../config/app-strings';
 import type { RenovateConfig } from '../../../../config/types';
 import { logger } from '../../../../logger';
 import type { PackageFile } from '../../../../modules/manager/types';
 import { emojify } from '../../../../util/emoji';
-
-const defaultConfigFile = configFileNames[0];
+import { getDefaultConfigFileName } from '../common';
 
 export function getScheduleDesc(config: RenovateConfig): string[] {
   logger.debug('getScheduleDesc()');
@@ -36,9 +34,7 @@ export function getConfigDesc(
   packageFiles?: Record<string, PackageFile[]>,
 ): string {
   // TODO: type (#22198)
-  const configFile = configFileNames.includes(config.onboardingConfigFileName!)
-    ? config.onboardingConfigFileName!
-    : defaultConfigFile;
+  const configFile = getDefaultConfigFileName(config);
   logger.debug('getConfigDesc()');
   logger.trace({ config });
   const descriptionArr = getDescriptionArray(config);

lib/workers/repository/onboarding/pr/index.ts

@@ -23,7 +23,7 @@ import { addParticipants } from '../../update/pr/participants';
 import { isOnboardingBranchConflicted } from '../branch/onboarding-branch-cache';
 import {
   OnboardingState,
-  defaultConfigFile,
+  getDefaultConfigFileName,
   getSemanticCommitPrTitle,
 } from '../common';
 import { getBaseBranchDesc } from './base-branch';
@@ -234,7 +234,7 @@ function getRebaseCheckbox(onboardingRebaseCheckbox?: boolean): string {
 async function getOnboardingConfigHashComment(
   config: RenovateConfig,
 ): Promise<string> {
-  const configFile = defaultConfigFile(config);
+  const configFile = getDefaultConfigFileName(config);
   const existingContents =
     (await getFile(configFile, config.onboardingBranch)) ?? '';
   const hash = toSha256(existingContents);