Skip to content

Commit f31aec3

Browse files
authored
chore(tools): handle additional errors (renovatebot#42205)
chore(tools): handle additional error In the case that `pdm` can't be executed, for instance if it's only installed in a Virtualenv that's not currently active, this previously would silently pass, even though the command had failed. We can now make it more resilient by warning/erroring in the cases that: - there is a timeout - the process was killed - the process failed to execute Originally raised as renovatebot#40987, which was closed due to the migration to `execa` and errors being flagged as an `unhandledRejection`. However, after b35d7c9, we would no longer reject, leading to an incomplete error handling case.
1 parent fe7ab7e commit f31aec3

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

tools/mkdocs.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,15 @@ function checkResult(res: ExecaSyncReturnValue<string>): void {
7979
} else if (res.exitCode) {
8080
logger.error(`Error occured:\n${res.stderr || res.stdout}`);
8181
process.exit(res.exitCode);
82+
} else if (res.timedOut) {
83+
logger.error({ res }, 'Process timed out');
84+
process.exit(-1);
85+
} else if (res.killed) {
86+
logger.error({ res }, 'Process was killed');
87+
process.exit(-1);
88+
} else if (res.failed) {
89+
logger.error({ res }, 'Process call failed');
90+
process.exit(-1);
8291
} else {
8392
logger.debug(`Build completed:\n${res.stdout || res.stderr}`);
8493
}

tools/prepare-release.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,15 @@ async function build(): Promise<void> {
5050
} else if (res.exitCode) {
5151
logger.error(`Error occured:\n${res.stderr || res.stdout}`);
5252
process.exit(res.exitCode);
53+
} else if (res.timedOut) {
54+
logger.error({ res }, 'Process timed out');
55+
process.exit(-1);
56+
} else if (res.killed) {
57+
logger.error({ res }, 'Process was killed');
58+
process.exit(-1);
59+
} else if (res.failed) {
60+
logger.error({ res }, 'Process call failed');
61+
process.exit(-1);
5362
} else {
5463
logger.debug(`Build succeeded:\n${res.stdout || res.stderr}`);
5564
}

0 commit comments

Comments
 (0)