Update Soroban protocol version to match testnet (hyperledger-solang#1821)

ahmadsamehh · salaheldinsoliman · web-flow · commit 2ca1eeb4b093 · 2025-08-03T19:56:54.000+02:00
Signed-off-by: salaheldinsoliman &lt;salaheldin_sameh@aucegypt.edu&gt;
Co-authored-by: salaheldinsoliman &lt;salaheldin_sameh@aucegypt.edu&gt;
Co-authored-by: salaheldinsoliman &lt;49910731+salaheldinsoliman@users.noreply.github.com&gt;
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -317,9 +317,12 @@ jobs:
       run: |
         chmod 755 ./bin/solang
         echo "$(pwd)/bin" >> $GITHUB_PATH
-    
+    - name: Install system dependencies for stellar-cli
+      run: apt-get update && apt-get install -y libdbus-1-dev pkg-config
     - name: Install Soroban
-      run: cargo install --locked stellar-cli --version 22.0.0
+      run: cargo install --locked stellar-cli --version 23.0.0
+    - name: Add wasm32v1-none target
+      run: rustup target add wasm32v1-none
     - name: Add cargo install location to PATH
       run: echo "$HOME/.cargo/bin" >> $GITHUB_PATH
     - run: npm install
@@ -328,7 +331,7 @@ jobs:
       run: npm run build
       working-directory: ./integration/soroban
     - name: Build rust contracts
-      run: soroban contract build --profile release-with-logs
+      run: stellar contract build --profile release-with-logs
       working-directory: ./integration/soroban/rust/contracts
     - name: Setup Soroban enivronment
       run: npm run setup
diff --git a/Cargo.toml b/Cargo.toml
@@ -71,7 +71,7 @@ solang-forge-fmt = { version = "0.2.0", optional = true }
 # We don't use ethers-core directly, but need the correct version for the
 # build to work.
 ethers-core = { version = "2.0.10", optional = true }
-soroban-sdk = { version = "22.0.7", features = ["testutils"], optional = true }
+soroban-sdk = { version = "23.0.0-rc.2.2", features = ["testutils"], optional = true }
 
 [dev-dependencies]
 num-derive = "0.4"
diff --git a/integration/soroban/auth_framework.spec.js b/integration/soroban/auth_framework.spec.js
@@ -3,15 +3,15 @@ import { readFileSync } from 'fs';
 import { expect } from 'chai';
 import path from 'path';
 import { fileURLToPath } from 'url';
-import { call_contract_function, extractLogEvent } from './test_helpers.js';
-import { assert } from 'console';
+import { call_contract_function, toSafeJson } from './test_helpers.js';
+import { Server } from '@stellar/stellar-sdk/rpc';
 
 const __filename = fileURLToPath(import.meta.url);
 const dirname = path.dirname(__filename);
-const server = new StellarSdk.SorobanRpc.Server("https://soroban-testnet.stellar.org:443");
+const server = new Server("https://soroban-testnet.stellar.org");
 
 function readContractAddress(filename) {
-  return readFileSync(path.join(dirname, '.soroban', 'contract-ids', filename), 'utf8').trim();
+  return readFileSync(path.join(dirname, '.stellar', 'contract-ids', filename), 'utf8').trim();
 }
 
 describe('Auth Framework', () => {
@@ -28,34 +28,28 @@ describe('Auth Framework', () => {
   });
 
   it('calls a', async () => {
-
-    
     let values = [
-        b.address().toScVal(),
-        c.address().toScVal()
+      b.address().toScVal(),
+      c.address().toScVal()
     ];
-
-
     let res = await call_contract_function("call_b", server, keypair, a, ...values);
 
-
-    expect(res.returnValue().value().toString()).to.equal("22");
-    
+    expect(res.status, `Call to 'a' contract failed: ${toSafeJson(res)}`).to.equal("SUCCESS");
+    expect(res.returnValue, `Unexpected return value for 'a': ${toSafeJson(res)}`).to.equal(22n);
   });
 
-  it ('call falis with invalid `a` contract', async () => {
-    
-    
+  it('call fails with invalid `a` contract', async () => {
     let values = [
-        b.address().toScVal(),
-        c.address().toScVal()
+      b.address().toScVal(),
+      c.address().toScVal()
     ];
-
     let res = await call_contract_function("call_b", server, keypair, a_invalid, ...values);
 
-    assert(res.toString().includes("recording authorization only] encountered authorization not tied to the root contract invocation for an address. Use `require_auth()` in the top invocation or enable non-root authorization."));
-
+    expect(res.status).to.not.equal("SUCCESS");
+    expect(
+      res.error || toSafeJson(res),
+      'Missing expected Soroban auth error message'
+    ).to.include("recording authorization only] encountered authorization not tied to the root contract invocation for an address. Use `require_auth()` in the top invocation or enable non-root authorization.");
   });
 
-
 });
diff --git a/integration/soroban/counter.spec.js b/integration/soroban/counter.spec.js
@@ -3,50 +3,45 @@ import { readFileSync } from 'fs';
 import { expect } from 'chai';
 import path from 'path';
 import { fileURLToPath } from 'url';
-import { call_contract_function } from './test_helpers.js';
+import { call_contract_function, toSafeJson } from './test_helpers.js';
+import { Server } from '@stellar/stellar-sdk/rpc';
 
 const __filename = fileURLToPath(import.meta.url);
 const dirname = path.dirname(__filename);
 
 describe('Counter', () => {
-  let keypair;
-  const server = new StellarSdk.SorobanRpc.Server(
-    "https://soroban-testnet.stellar.org:443",
-  );
+  let keypair, contract;
+  const server = new Server("https://soroban-testnet.stellar.org");
 
-  let contractAddr;
-  let contract;
   before(async () => {
-
     console.log('Setting up counter contract tests...');
 
     // read secret from file
     const secret = readFileSync('alice.txt', 'utf8').trim();
     keypair = StellarSdk.Keypair.fromSecret(secret);
 
-    let contractIdFile = path.join(dirname, '.soroban', 'contract-ids', 'counter.txt');
+    let contractIdFile = path.join(dirname, '.stellar', 'contract-ids', 'counter.txt');
     // read contract address from file
-    contractAddr = readFileSync(contractIdFile, 'utf8').trim().toString();
-
+    const contractAddr = readFileSync(contractIdFile, 'utf8').trim();
     // load contract
     contract = new StellarSdk.Contract(contractAddr);
   });
 
   it('get correct initial counter', async () => {
-    // get the count
-    let count = await call_contract_function("count", server, keypair, contract);
-    console.log(count.returnValue().value());
-    expect(count.returnValue().value().toString()).eq("10");
+    let res = await call_contract_function("count", server, keypair, contract);
+
+    expect(res.status, `Counter 'count' call failed: ${toSafeJson(res)}`).to.equal("SUCCESS");
+    expect(res.returnValue, `Unexpected counter value: ${toSafeJson(res)}`).to.equal(10n);
   });
 
   it('increment counter', async () => {
     // increment the counter
-    await call_contract_function("increment", server, keypair, contract);
+    let incRes = await call_contract_function("increment", server, keypair, contract);
+    expect(incRes.status, `Counter 'increment' call failed: ${toSafeJson(incRes)}`).to.equal("SUCCESS");
 
-    // get the count
-    let count = await call_contract_function("count", server, keypair, contract);
-    expect(count.returnValue().value().toString()).eq("11");
+    // get the count again
+    let res = await call_contract_function("count", server, keypair, contract);
+    expect(res.status, `Counter 'count' after increment failed: ${toSafeJson(res)}`).to.equal("SUCCESS");
+    expect(res.returnValue, `Unexpected counter value after increment: ${toSafeJson(res)}`).to.equal(11n);
   });
 });
-
-
diff --git a/integration/soroban/cross_contract.spec.js b/integration/soroban/cross_contract.spec.js
@@ -3,14 +3,19 @@ import { readFileSync } from 'fs';
 import { expect } from 'chai';
 import path from 'path';
 import { fileURLToPath } from 'url';
-import { call_contract_function, extractLogEvent } from './test_helpers.js';
+import {
+  call_contract_function,
+  extractLogMessagesFromDiagnosticEvents,
+  toSafeJson,
+} from './test_helpers.js';
+import { Server } from '@stellar/stellar-sdk/rpc';
 
 const __filename = fileURLToPath(import.meta.url);
 const dirname = path.dirname(__filename);
-const server = new StellarSdk.SorobanRpc.Server("https://soroban-testnet.stellar.org:443");
+const server = new Server("https://soroban-testnet.stellar.org");
 
 function readContractAddress(filename) {
-  return readFileSync(path.join(dirname, '.soroban', 'contract-ids', filename), 'utf8').trim();
+  return readFileSync(path.join(dirname, '.stellar', 'contract-ids', filename), 'utf8').trim();
 }
 
 describe('Cross Contract Calls', () => {
@@ -34,13 +39,13 @@ describe('Cross Contract Calls', () => {
     ].map(StellarSdk.xdr.ScVal.scvU64);
 
     let res = await call_contract_function("add", server, keypair, caller, addr, ...values);
-    let returnValue = res.returnValue().value().toString();
 
-    console.log(returnValue);
-    expect(returnValue).to.equal("3");
+    expect(res.status, `Rust contract tx failed: ${toSafeJson(res)}`).to.equal("SUCCESS");
+    // Return value is already decoded (should be 3n for u64 add)
+    expect(res.returnValue, `Unexpected returnValue for Rust contract: ${toSafeJson(res)}`).to.equal(3n);
 
-    let logMessages = extractLogEvent(res.diagnosticEvents()).logMessages;
-    console.log(logMessages);
+    const logMessages = extractLogMessagesFromDiagnosticEvents(res.raw);
+    expect(logMessages.length > 0, "No logMessages found in Rust contract response").to.be.true;
     expect(logMessages[0]).to.contain('Soroban SDK add function called!');
   });
 
@@ -53,13 +58,12 @@ describe('Cross Contract Calls', () => {
     ].map(StellarSdk.xdr.ScVal.scvU64);
 
     let res = await call_contract_function("add", server, keypair, caller, addr, ...values);
-    let returnValue = res.returnValue().value().toString();
 
-    console.log(returnValue);
-    expect(returnValue).to.equal("3");
+    expect(res.status, `Solidity contract tx failed: ${toSafeJson(res)}`).to.equal("SUCCESS");
+    expect(res.returnValue, `Unexpected returnValue for Solidity contract: ${toSafeJson(res)}`).to.equal(3n);
 
-    let logMessages = extractLogEvent(res.diagnosticEvents()).logMessages;
-    console.log(logMessages);
+    const logMessages = extractLogMessagesFromDiagnosticEvents(res.raw);
+    expect(logMessages.length > 0, "No logMessages found in Solidity contract response").to.be.true;
     expect(logMessages[0]).to.contain('add called in Solidity');
   });
 });
diff --git a/integration/soroban/package.json b/integration/soroban/package.json
@@ -1,7 +1,7 @@
 {
     "type": "module",
     "dependencies": {
-      "@stellar/stellar-sdk": "^12.0.1",
+      "@stellar/stellar-sdk": "14.0.0-rc.2",
       "chai": "^5.1.1",
       "dotenv": "^16.4.5",
       "mocha": "^10.4.0"
diff --git a/integration/soroban/runtime_error.spec.js b/integration/soroban/runtime_error.spec.js
@@ -3,46 +3,40 @@ import { readFileSync } from 'fs';
 import { expect } from 'chai';
 import path from 'path';
 import { fileURLToPath } from 'url';
-import { call_contract_function } from './test_helpers.js';
+import { call_contract_function, toSafeJson } from './test_helpers.js';
+import { Server } from '@stellar/stellar-sdk/rpc';
 
 const __filename = fileURLToPath(import.meta.url);
 const dirname = path.dirname(__filename);
 
 describe('Runtime Error', () => {
-  let keypair;
-  const server = new StellarSdk.SorobanRpc.Server(
-    "https://soroban-testnet.stellar.org:443",
-  );
+  let keypair, contract;
+  const server = new Server("https://soroban-testnet.stellar.org");
 
-  let contractAddr;
-  let contract;
   before(async () => {
-
     console.log('Setting up runtime_error.sol contract tests...');
 
     // read secret from file
     const secret = readFileSync('alice.txt', 'utf8').trim();
     keypair = StellarSdk.Keypair.fromSecret(secret);
 
-    let contractIdFile = path.join(dirname, '.soroban', 'contract-ids', 'Error.txt');
-    // read contract address from file
-    contractAddr = readFileSync(contractIdFile, 'utf8').trim().toString();
+    const contractIdFile = path.join(dirname, '.stellar', 'contract-ids', 'Error.txt');
+    const contractAddr = readFileSync(contractIdFile, 'utf8').trim();
 
-    // load contract
     contract = new StellarSdk.Contract(contractAddr);
 
-    // call decrement once. The second call however will result in a runtime error
+    // call decrement once (to reach error state on the next call)
     await call_contract_function("decrement", server, keypair, contract);
   });
 
   it('prints error', async () => {
+    // decrement the counter again, expecting a runtime error
+    const res = await call_contract_function("decrement", server, keypair, contract);
 
-    // decrement the counter again, resulting in a runtime error
-    let res = await call_contract_function("decrement", server, keypair, contract);
-
-    expect(res).to.contain('runtime_error: math overflow in runtime_error.sol:6:9-19');
+    expect(res.status).to.not.equal("SUCCESS");
+    // The error message may be in res.error or a safe string version
+    const errorString = res.error || toSafeJson(res);
+    expect(errorString).to.contain('runtime_error: math overflow in runtime_error.sol:6:9-19');
   });
 
 });
-
-
diff --git a/integration/soroban/rust/Cargo.toml b/integration/soroban/rust/Cargo.toml
@@ -5,7 +5,7 @@ members = [
 ]
 
 [workspace.dependencies]
-soroban-sdk = "22"
+soroban-sdk = { version = "23.0.0-rc.2.3" }
 
 [profile.release]
 opt-level = "z"
diff --git a/integration/soroban/setup.js b/integration/soroban/setup.js
@@ -21,10 +21,10 @@ function exe(command) {
 }
 
 function generate_alice() {
-  exe(`${soroban} keys generate alice --network testnet --overwrite`);
+  exe(`stellar keys generate alice --network testnet --overwrite --fund`);
 
   // get the secret key of alice and put it in alice.txt
-  exe(`${soroban} keys show alice > alice.txt`);
+  exe(`stellar keys show alice > alice.txt`);
 }
 
 
@@ -34,19 +34,19 @@ function filenameNoExtension(filename) {
 
 function deploy(wasm) {
 
-  let contractId = path.join(dirname, '.soroban', 'contract-ids', filenameNoExtension(wasm) + '.txt');
+  let contractId = path.join(dirname, '.stellar', 'contract-ids', filenameNoExtension(wasm) + '.txt');
 
-  exe(`(${soroban} contract deploy --wasm ${wasm} --ignore-checks --source-account alice --network testnet) > ${contractId}`);
+  exe(`(stellar contract deploy --wasm ${wasm} --ignore-checks --source-account alice --network testnet) > ${contractId}`);
 }
 
 function deploy_all() {
-  const contractsDir = path.join(dirname, '.soroban', 'contract-ids');
+  const contractsDir = path.join(dirname, '.stellar', 'contract-ids');
   mkdirSync(contractsDir, { recursive: true });
 
   let wasmFiles = readdirSync(`${dirname}`).filter(file => file.endsWith('.wasm'));
   console.log(dirname);
   
-  let rust_wasm = path.join('rust','target','wasm32-unknown-unknown', 'release-with-logs', 'hello_world.wasm');
+  let rust_wasm = path.join('rust','target','wasm32v1-none', 'release-with-logs', 'hello_world.wasm');
 
   // add rust wasm file to the list of wasm files
   wasmFiles.push(rust_wasm);
@@ -58,7 +58,7 @@ function deploy_all() {
 
 function add_testnet() {
 
-  exe(`${soroban} network add \
+  exe(`stellar network add \
     --global testnet \
     --rpc-url https://soroban-testnet.stellar.org:443 \
     --network-passphrase "Test SDF Network ; September 2015"`);
diff --git a/integration/soroban/storage_types.spec.js b/integration/soroban/storage_types.spec.js
diff --git a/integration/soroban/test_helpers.js b/integration/soroban/test_helpers.js
diff --git a/src/emit/soroban/mod.rs b/src/emit/soroban/mod.rs
diff --git a/tests/soroban_testcases/ttl.rs b/tests/soroban_testcases/ttl.rs

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"type": "module",`
`3`	`3`	`"dependencies": {`
`4`		`- "@stellar/stellar-sdk": "^12.0.1",`
	`4`	`+ "@stellar/stellar-sdk": "14.0.0-rc.2",`
`5`	`5`	`"chai": "^5.1.1",`
`6`	`6`	`"dotenv": "^16.4.5",`
`7`	`7`	`"mocha": "^10.4.0"`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ members = [`
`5`	`5`	`]`
`6`	`6`
`7`	`7`	`[workspace.dependencies]`
`8`		`-soroban-sdk = "22"`
	`8`	`+soroban-sdk = { version = "23.0.0-rc.2.3" }`
`9`	`9`
`10`	`10`	`[profile.release]`
`11`	`11`	`opt-level = "z"`