(chore) reduce default window size and make jpg quality configurable

Author: leonjza

cmd/scan.go

@@ -142,6 +142,7 @@ func init() {
 	scanCmd.PersistentFlags().StringSliceVar(&opts.Scan.UriFilter, "uri-filter", []string{"http", "https"}, "Valid URIs to pass to the scanning process")
 	scanCmd.PersistentFlags().StringVarP(&opts.Scan.ScreenshotPath, "screenshot-path", "s", "./screenshots", "Path to store screenshots")
 	scanCmd.PersistentFlags().StringVar(&opts.Scan.ScreenshotFormat, "screenshot-format", "jpeg", "Format to save screenshots as. Valid formats are: jpeg, png")
+	scanCmd.PersistentFlags().IntVar(&opts.Scan.ScreenshotJpegQuality, "screenshot-jpeg-quality", 60, "The quality of JPEG screenshots (1-100)")
 	scanCmd.PersistentFlags().BoolVar(&opts.Scan.ScreenshotFullPage, "screenshot-fullpage", false, "Do full-page screenshots, instead of just the viewport")
 	scanCmd.PersistentFlags().BoolVar(&opts.Scan.ScreenshotSkipSave, "screenshot-skip-save", false, "Do not save screenshots to the screenshot-path (useful together with --write-screenshots)")
 	scanCmd.PersistentFlags().StringVar(&opts.Scan.JavaScript, "javascript", "", "A JavaScript function to evaluate on every page, before a screenshot. Note: It must be a JavaScript function! e.g., () => console.log('gowitness');")
@@ -156,8 +157,8 @@ func init() {
 	scanCmd.PersistentFlags().StringVar(&opts.Chrome.Proxy, "chrome-proxy", "", "An HTTP/SOCKS5 proxy server to use. Specify the proxy using this format: proto://address:port")
 	scanCmd.PersistentFlags().StringVar(&opts.Chrome.WSS, "chrome-wss-url", "", "A websocket URL to connect to a remote, already running Chrome DevTools instance (i.e., Chrome started with --remote-debugging-port)")
 	scanCmd.PersistentFlags().StringVar(&opts.Chrome.UserAgent, "chrome-user-agent", "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/128.0.0.0 Safari/537.36", "The user-agent string to use")
-	scanCmd.PersistentFlags().IntVar(&opts.Chrome.WindowX, "chrome-window-x", 1920, "The Chrome browser window width, in pixels")
-	scanCmd.PersistentFlags().IntVar(&opts.Chrome.WindowY, "chrome-window-y", 1080, "The Chrome browser window height, in pixels")
+	scanCmd.PersistentFlags().IntVar(&opts.Chrome.WindowX, "chrome-window-x", 1280, "The Chrome browser window width, in pixels")
+	scanCmd.PersistentFlags().IntVar(&opts.Chrome.WindowY, "chrome-window-y", 720, "The Chrome browser window height, in pixels")
 	scanCmd.PersistentFlags().StringSliceVar(&opts.Chrome.Headers, "chrome-header", []string{}, "Extra headers to add to requests. Supports multiple --header flags")
 
 	// Write options for scan subcommands

pkg/runner/drivers/chromedp.go

@@ -429,7 +429,7 @@ func (run *Chromedp) Witness(target string, thisRunner *runner.Runner) (*models.
 		chromedp.ActionFunc(func(ctx context.Context) error {
 			var err error
 			params := page.CaptureScreenshot().
-				WithQuality(80).
+				WithQuality(int64(run.options.Scan.ScreenshotJpegQuality)).
 				WithFormat(page.CaptureScreenshotFormat(run.options.Scan.ScreenshotFormat))
 
 			// if fullpage

pkg/runner/drivers/go-rod.go

@@ -424,7 +424,7 @@ func (run *Gorod) Witness(target string, runner *runner.Runner) (*models.Result,
 	switch run.options.Scan.ScreenshotFormat {
 	case "jpeg":
 		screenshotOptions.Format = proto.PageCaptureScreenshotFormatJpeg
-		screenshotOptions.Quality = gson.Int(80)
+		screenshotOptions.Quality = gson.Int(run.options.Scan.ScreenshotJpegQuality)
 	case "png":
 		screenshotOptions.Format = proto.PageCaptureScreenshotFormatPng
 	}

pkg/runner/options.go

@@ -77,6 +77,8 @@ type Scan struct {
 	ScreenshotPath string
 	// ScreenshotFormat to save as
 	ScreenshotFormat string
+	// ScreenshotJpegQuality is the quality of the JPEG screenshot (1-100)
+	ScreenshotJpegQuality int
 	// ScreenshotFullPage saves full, scrolled web pages
 	ScreenshotFullPage bool
 	// ScreenshotToWriter passes screenshots as a model property to writers