Fixes to get it working in SS4, is very much a bodge

Author: oilee80

_config.php

@@ -15,9 +15,9 @@
 $htmlEditorNames = Config::inst()->get('Shortcodable', 'htmleditor_names');
 if (is_array($htmlEditorNames)) {
     foreach ($htmlEditorNames as $htmlEditorName) {
-        HtmlEditorConfig::get($htmlEditorName)->enablePlugins(array(
-            'shortcodable' => sprintf('../../../%s/javascript/editor_plugin.js', SHORTCODABLE_DIR)
-        ));
+        // HtmlEditorConfig::get($htmlEditorName)->enablePlugins(array(
+        //     'shortcodable' => sprintf('/resources/%s/javascript/editor_plugin.js', SHORTCODABLE_DIR)
+        // ));
         HtmlEditorConfig::get($htmlEditorName)->addButtonsToLine(1, 'shortcodable');
     }
 }

_config/config.yml

@@ -2,13 +2,13 @@
 Name: shortcodable
 After:
     - framework/*
-    - cms/*
+    # - cms/*
 ---
 
 LeftAndMain:
   extra_requirements_javascript:
-    - 'shortcodable/javascript/editor_plugin.js'
-    - 'shortcodable/javascript/shortcodable.js'
+    - 'resources/shortcodable/javascript/editor_plugin.js'
+    - 'resources/shortcodable/javascript/shortcodable.js'
   extra_requirements_css:
     - 'shortcodable/css/shortcodable.css'
 

src/Extensions/ShortcodableParser.php

@@ -2,15 +2,15 @@
 
 namespace Silverstripe\Shortcodable;
 
-use SilverStripe\Core\Object;
+use SilverStripe\View\ViewableData;
 
 /**
  * ShortcodableParser - temporary measure, based on wordpress parser
  * This parser is only used to parse tags in the html editor field for editing in the popup window.
  *
  * @todo update SS ShortcodeParser to offer a public api for converting a shortcode to a data array, and use that instead.
  */
-class ShortcodableParser extends Object
+class ShortcodableParser extends ViewableData
 {
     /**
      * @var array

src/Shortcodable.php

@@ -2,17 +2,18 @@
 
 namespace Silverstripe;
 
-use SilverStripe\Core\Object;
+use SilverStripe\View\ViewableData;
 use SilverStripe\View\Parsers\ShortcodeParser;
 use SilverStripe\Core\Config\Config;
+use Silverstripe\Shortcodable\ShortcodableParser;
 
 /**
  * Shortcodable
  * Manages shortcodable configuration and register shortcodable objects
  *
  * @author shea@livesource.co.nz
  **/
-class Shortcodable extends Object
+class Shortcodable extends ViewableData
 {
     private static $shortcodable_classes = array();
 
@@ -32,7 +33,7 @@ public static function register_class($class)
                 user_error("Failed to register \"$class\" with shortcodable. $class must have the method parse_shortcode(). See /shortcodable/README.md", E_USER_ERROR);
             }
             ShortcodeParser::get('default')->register($class, array($class, 'parse_shortcode'));
-            singleton('ShortcodableParser')->register($class);
+            singleton(ShortcodableParser::class)->register($class);
         }
     }