1.4.0 sniffer issue

[mfendeksilverstripe]

1.4.0 sniffer issue

Looks like an issue was introduced in 1.4.0. The issue is not present in 1.3.0. Getting the following error:

----------------------------------------------------------------------
 1 | ERROR | An error occurred during processing; checking has been
   |       | aborted. The error message was: Undefined array key ""
   |       | in
   |       | /var/www/mysite/www/vendor/silverstripeltd/bespoke-standards/src/Sniffs/Property/TypehintPrivateStaticSniff.php
   |       | on line 67
   |       | The error originated in the
   |       | Silverstripe.Property.TypehintPrivateStatic sniff on
   |       | line 67. (Internal.Exception)
----------------------------------------------------------------------

[mfendeksilverstripe]

FYI: @n8-dev

[n8-dev]

Initial thoughts, something specific in code base is not working with this sniff that was missed in test construction.

[n8-dev]

Confirmed its the occurance of things like

    /**
     * Static internal cache data
     *
     * @var array
     */
    protected static array $cacheData = [];

[n8-dev]

Exploring in #33

[edwilde]

Perhaps a 1.4.1 release with this removed until it can be fixed?

At the moment I am having to lock them all to ~1.3.0 which will make future updates more challenging

[n8-dev]

Yeah, I haven't had time to return to this.

Good idea.

[n8-dev]

PR for that #34 if either of you could approve/

Now approved.
So this issue is patched out of existence in 1.4.1.

However leaving the issue open as we'd like to fix the issue and bring the sniff back.