added tests and cleaned up cansendemail function

Author: Radroaches

src/Extensions/SiteTreeContentReview.php

@@ -585,50 +585,13 @@ public function canBeReviewedBy(Member $member = null)
      */
     public function canSendEmail(Member $member = null)
     {
-        if (!$this->owner->obj("NextReviewDate")->exists()) {
-            return false;
-        }
+        $canSendEmail = $this->canBeReviewedBy($member);
 
         if ($this->owner->obj("NextReviewDate")->InFuture()) {
-            return false;
-        }
-
-        $options = $this->getOptions();
-
-        if (!$options) {
-            return false;
-        }
-
-        if (!$options
-            // Options can be a SiteConfig with different extension applied
-            || (!$options->hasExtension(__CLASS__)
-                && !$options->hasExtension(ContentReviewDefaultSettings::class))
-        ) {
-            return false;
-        }
-
-        if ($options->OwnerGroups()->count() == 0 && $options->OwnerUsers()->count() == 0) {
-            return false;
-        }
-
-        if (!$member) {
-            return true;
-        }
-
-        // Whether or not a user is allowed to review the content of the page.
-        if ($this->owner->hasMethod("canReviewContent") && !$this->owner->canReviewContent($member)) {
-            return false;
-        }
-
-        if ($member->inGroups($options->OwnerGroups())) {
-            return true;
+            $canSendEmail = false;
         }
 
-        if ($options->OwnerUsers()->find("ID", $member->ID)) {
-            return true;
-        }
-
-        return false;
+        return $canSendEmail;
     }
 
     /**

tests/php/SiteTreeContentReviewTest.php

@@ -195,6 +195,21 @@ public function testCanBeReviewedInFuture()
         DBDatetime::clear_mock_now();
     }
 
+    public function testCanNotSendReviewEmail()
+    {
+        DBDatetime::set_mock_now("2010-01-01 12:00:00");
+
+        /** @var Member $author */
+        $author = $this->objFromFixture(Member::class, "author");
+
+        /** @var Page|SiteTreeContentReview $page */
+        $page = $this->objFromFixture(Page::class, "staff");
+
+        $this->assertFalse($page->canSendEmail($author));
+
+        DBDatetime::clear_mock_now();
+    }
+
     public function testCanNotBeReviewedByUser()
     {
         DBDatetime::set_mock_now("2010-03-01 12:00:00");