Add generic list types. Bump min framework version to 5.2 (#20)

- silverstripe/framework 5.2 is required for working generics list types
- silverstripe/framework 5.1 is EOL Oct 17, 2024

Author: Cambis

composer.json

@@ -22,7 +22,7 @@
     ],
     "require": {
         "php": "^8.1",
-        "silverstripe/framework": "^5.1"
+        "silverstripe/framework": "^5.2"
     },
     "require-dev": {
         "phpunit/phpunit": "^9.5",

src/Service/Results/Facet.php

@@ -10,7 +10,7 @@ class Facet extends ViewableData
 {
 
     /**
-     * @var ArrayList|FacetData[]
+     * @var ArrayList<FacetData>
      */
     private ArrayList $data;
 
@@ -32,6 +32,9 @@ public function forTemplate(): DBHTMLText
         return $this->renderWith(static::class);
     }
 
+    /**
+     * @return ArrayList<FacetData>
+     */
     public function getData(): ArrayList
     {
         return $this->data;

src/Service/Results/Facets.php

@@ -5,6 +5,9 @@
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\FieldType\DBHTMLText;
 
+/**
+ * @extends ArrayList<Facet>
+ */
 class Facets extends ArrayList
 {
 

src/Service/Results/Records.php

@@ -2,9 +2,13 @@
 
 namespace SilverStripe\Discoverer\Service\Results;
 
+use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\FieldType\DBHTMLText;
 use SilverStripe\ORM\PaginatedList;
 
+/**
+ * @extends PaginatedList<ArrayList<Record>, Record>
+ */
 class Records extends PaginatedList
 {
 

src/Service/Results/Results.php

@@ -13,14 +13,8 @@ class Results extends ViewableData
 
     use Injectable;
 
-    /**
-     * @var Records|Record[]
-     */
     private Records $records;
 
-    /**
-     * @var Facets|Facet[]
-     */
     private Facets $facets;
 
     private ?string $indexName = null;