Merge pull request #36 from Cambis/fix/decorated-links

FIX: Update argument syntax for Record::getDecoratedLink()

Author: blueo

docs/detailed-result-handling.md

@@ -78,7 +78,7 @@ the two, as it will automatically consider whether there are existing GET params
 The following example assumes that you have indexed a `title` and `link` for each search Document.
 
 ```silverstripe
-<a href="{$getDecoratedLink($Link)}">$Title</a>
+<a href="{$getDecoratedLink($Link.forTemplate)}">$Title</a>
 ```
 
 **Note:** Analytics is perhaps the most likely feature to be missing from search service providers. EG: It is

tests/Service/Results/RecordTest.php

@@ -3,15 +3,29 @@
 namespace SilverStripe\Discoverer\Tests\Service\Results;
 
 use PHPUnit\Framework\Attributes\DataProvider;
-use SilverStripe\Control\Controller;
+use SilverStripe\Assets\Dev\TestAssetStore;
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\Discoverer\Analytics\AnalyticsData;
 use SilverStripe\Discoverer\Service\Results\Field;
 use SilverStripe\Discoverer\Service\Results\Record;
+use SilverStripe\View\SSViewer;
 
 class RecordTest extends SapphireTest
 {
 
+    protected function setUp(): void
+    {
+        parent::setUp();
+        SSViewer::config()->set('source_file_comments', false);
+        TestAssetStore::activate('RecordTest');
+    }
+
+    protected function tearDown(): void
+    {
+        TestAssetStore::reset();
+        parent::tearDown();
+    }
+
     public function testAnalyticsData(): void
     {
         $record = Record::create();
@@ -29,6 +43,13 @@ public function testGetDecoratedLink(?AnalyticsData $analyticsData, string $link
         $this->assertEquals($expectedLink, $record->getDecoratedLink($link));
     }
 
+    public function testGetDecoratedLinkTemplate(): void
+    {
+        $actual = Record::create()->renderWith('DecoratedLink', ['Link' => Field::create('http://www.example.com')]);
+
+        $this->assertSame('<a href="SilverStripe\Discoverer\Service\Results\Field">Link</a><a href="http://www.example.com">Link</a>', trim($actual->RAW()));
+    }
+
     public static function provideLinks(): array
     {
         // SapphireTest doesn't like the use of injector in data providers

tests/Service/Results/RecordTest/templates/DecoratedLink.ss

@@ -0,0 +1 @@
+<a href="{$getDecoratedLink($Link)}">Link</a><a href="{$getDecoratedLink($Link.forTemplate)}">Link</a>