AOS-294: Forager Bifrost > Document search extraction limit could be worded better (#25)

* AOS-294: Modified the alert message for text extraction of large file sizes

* AOS-294: Fixed linting

* AOS-294: Fix unit test

Author: adunn49

lang/en.yml

@@ -1,4 +1,4 @@
 en:
   SilverStripe\ForagerBifrost\Extensions\FileFormExtension:
     FILE_LIMIT_MESSAGE: "Document search extraction limit is {limit}"
-    LARGE_FILE_WARNING: "File size is {size} which exceeds the search extraction limit of {limit}"
+    LARGE_FILE_WARNING: "Text contained within this {size} file cannot be indexed for search. The file size limit for text extraction is {limit}."

src/Extensions/FileFormExtension.php

@@ -78,7 +78,8 @@ private function createLargeFileWarning(File $file): ?LiteralField
                     ['class' => 'alert alert-warning'],
                     _t(
                         self::class . '.LARGE_FILE_WARNING',
-                        'File size is {size} which exceeds the search extraction limit of {limit}',
+                        'Text contained within this {size} file cannot be indexed for search. '
+                            . 'The file size limit for text extraction is {limit}.',
                         [
                             'size' => $file->getSize(),
                             'limit' => SearchFile::sizeLimit(),

tests/Extensions/FileFormExtensionTest.php

@@ -139,7 +139,8 @@ public function testCreateLargeFileWarning(): void
 
         $this->assertInstanceOf(LiteralField::class, $field);
         $this->assertEquals(
-            '<p class="alert alert-warning">File size is 16 MB which exceeds the search extraction limit of 15 MB</p>',
+            '<p class="alert alert-warning">Text contained within this 16 MB file cannot be indexed for search.'
+                . ' The file size limit for text extraction is 15 MB.</p>',
             $field->getContent()
         );
     }