Fix ruff lint and formatting issues

Author: simion

src/reviewd/daemon.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import contextlib
 import functools
 import logging
 import os
@@ -336,10 +337,8 @@ def run_poll_loop(
 
     # Save terminal settings so we can restore after subprocesses corrupt them
     _saved_termios = None
-    try:
+    with contextlib.suppress(termios.error, ValueError, OSError):
         _saved_termios = termios.tcgetattr(sys.stdin.fileno())
-    except (termios.error, ValueError, OSError):
-        pass
 
     executor = ThreadPoolExecutor(max_workers=max_workers, thread_name_prefix='review')
     futures: dict[Future, PRInfo] = {}
@@ -348,10 +347,8 @@ def run_poll_loop(
 
     def _restore_terminal():
         if _saved_termios is not None:
-            try:
+            with contextlib.suppress(termios.error, ValueError, OSError):
                 termios.tcsetattr(sys.stdin.fileno(), termios.TCSADRAIN, _saved_termios)
-            except (termios.error, ValueError, OSError):
-                pass
 
     def _handle_shutdown(_signum, _frame):
         nonlocal _force_quit

tests/test_config_env.py

@@ -16,44 +16,58 @@ def _write_config(tmp_path, data: dict) -> str:
 
 def test_env_var_substitution(tmp_path, monkeypatch):
     monkeypatch.setenv('TEST_GH_TOKEN', 'ghp_secret123')
-    path = _write_config(tmp_path, {
-        'github': {'token': '${TEST_GH_TOKEN}'},
-        'repos': [{'name': 'r', 'path': '/tmp/r', 'provider': 'github'}],
-    })
+    path = _write_config(
+        tmp_path,
+        {
+            'github': {'token': '${TEST_GH_TOKEN}'},
+            'repos': [{'name': 'r', 'path': '/tmp/r', 'provider': 'github'}],
+        },
+    )
     config = load_global_config(path)
     assert config.github.token == 'ghp_secret123'
 
 
 def test_missing_env_var_raises(tmp_path, monkeypatch):
     monkeypatch.delenv('NONEXISTENT_VAR_XYZ', raising=False)
-    path = _write_config(tmp_path, {
-        'github': {'token': '${NONEXISTENT_VAR_XYZ}'},
-        'repos': [{'name': 'r', 'path': '/tmp/r', 'provider': 'github'}],
-    })
+    path = _write_config(
+        tmp_path,
+        {
+            'github': {'token': '${NONEXISTENT_VAR_XYZ}'},
+            'repos': [{'name': 'r', 'path': '/tmp/r', 'provider': 'github'}],
+        },
+    )
     with pytest.raises(ValueError, match='NONEXISTENT_VAR_XYZ is not set'):
         load_global_config(path)
 
 
 def test_max_concurrent_reviews_parsed(tmp_path):
-    path = _write_config(tmp_path, {
-        'max_concurrent_reviews': 8,
-        'repos': [{'name': 'r', 'path': '/tmp/r', 'provider': 'github'}],
-    })
+    path = _write_config(
+        tmp_path,
+        {
+            'max_concurrent_reviews': 8,
+            'repos': [{'name': 'r', 'path': '/tmp/r', 'provider': 'github'}],
+        },
+    )
     config = load_global_config(path)
     assert config.max_concurrent_reviews == 8
 
 
 def test_max_concurrent_reviews_default(tmp_path):
-    path = _write_config(tmp_path, {
-        'repos': [{'name': 'r', 'path': '/tmp/r', 'provider': 'github'}],
-    })
+    path = _write_config(
+        tmp_path,
+        {
+            'repos': [{'name': 'r', 'path': '/tmp/r', 'provider': 'github'}],
+        },
+    )
     config = load_global_config(path)
     assert config.max_concurrent_reviews == 4
 
 
 def test_git_env_has_terminal_prompt_disabled():
     from reviewd.reviewer import _GIT_ENV
+
     assert _GIT_ENV['GIT_TERMINAL_PROMPT'] == '0'
 
     from reviewd.config import _GIT_ENV as _CONFIG_GIT_ENV
+
     assert _CONFIG_GIT_ENV['GIT_TERMINAL_PROMPT'] == '0'