chore: snapshot before RustyMilk → MilkRust rebrand

- Added tests: rustymilk-cli (18), rustymilk-core (25), rustymilk-desktop (39),
  rustymilk-pack (28), rustymilk-renderer-core (6), rustymilk-renderer-headless (2),
  rustymilk-wasm (15) — 128 total tests, all passing
- Removed dead-end crates: rustymilk-expr, rustymilk-preset
- Fixed clippy warnings: question_mark, manual clamp, too_many_arguments
- Updated Cargo.toml workspace members

Author: snapetech

Cargo.lock

@@ -2,8 +2,6 @@
 members = [
     "crates/rustymilk-cli",
     "crates/rustymilk-core",
-    "crates/rustymilk-expr",
-    "crates/rustymilk-preset",
     "crates/rustymilk-pack",
     "crates/rustymilk-renderer-core",
     "crates/rustymilk-renderer-headless",

Cargo.toml

@@ -168,11 +168,10 @@ fn compat_command(path: Option<&String>) -> RustyMilkCliResult {
         .filter_map(|file| {
             let source = fs::read_to_string(file).ok()?;
             Some(build_rustymilk_compatibility_entry(
-                &file
+                file
                     .file_stem()
                     .and_then(|stem| stem.to_str())
-                    .unwrap_or("preset")
-                    .to_string(),
+                    .unwrap_or("preset"),
                 &file.display().to_string(),
                 &source,
                 file.extension()
@@ -468,4 +467,95 @@ mod tests {
         assert_eq!(result.code, 2);
         assert!(result.stderr.contains("usage: rustymilk"));
     }
+
+    // --- Helper function tests ---
+
+    #[test]
+    fn cli_result_ok_has_zero_code_and_stdout() {
+        let result = RustyMilkCliResult::ok("hello");
+        assert_eq!(result.code, 0);
+        assert_eq!(result.stdout, "hello");
+        assert!(result.stderr.is_empty());
+    }
+
+    #[test]
+    fn cli_result_err_has_error_code_and_stderr() {
+        let result = RustyMilkCliResult::err(1, "boom");
+        assert_eq!(result.code, 1);
+        assert_eq!(result.stderr, "boom");
+        assert!(result.stdout.is_empty());
+    }
+
+    #[test]
+    fn usage_returns_usage_string() {
+        let output = usage();
+        assert!(output.contains("validate"));
+        assert!(output.contains("inspect"));
+    }
+
+    #[test]
+    fn is_preset_file_accepts_milk_extension() {
+        assert!(is_preset_file(Path::new("test.milk")));
+    }
+
+    #[test]
+    fn is_preset_file_accepts_milk2_extension() {
+        assert!(is_preset_file(Path::new("test.milk2")));
+    }
+
+    #[test]
+    fn is_preset_file_rejects_other_extensions() {
+        assert!(!is_preset_file(Path::new("test.json")));
+        assert!(!is_preset_file(Path::new("test.txt")));
+    }
+
+    #[test]
+    fn is_preset_file_no_extension_returns_false() {
+        assert!(!is_preset_file(Path::new("test")));
+    }
+
+    #[test]
+    fn read_one_path_returns_error_for_missing_file() {
+        let result = read_one_path(Some(&temp_path("nonexistent.txt").display().to_string()));
+        assert!(result.is_err());
+    }
+
+    #[test]
+    fn collect_preset_files_collects_only_preset_files() {
+        let dir = temp_path("collect-dir");
+        fs::create_dir_all(&dir).unwrap();
+        fs::write(dir.join("test.milk"), "name=test\n").unwrap();
+        fs::write(dir.join("test.milk2"), "name=test\n").unwrap();
+        fs::write(dir.join("other.json"), "{}").unwrap();
+
+        let files = collect_preset_files(&dir).unwrap();
+        let _ = fs::remove_dir_all(&dir);
+
+        assert_eq!(files.len(), 2);
+    }
+
+    #[test]
+    fn collect_preset_files_empty_directory_returns_empty() {
+        let dir = temp_path("empty-dir");
+        fs::create_dir_all(&dir).unwrap();
+
+        let files = collect_preset_files(&dir).unwrap();
+        let _ = fs::remove_dir_all(&dir);
+
+        assert!(files.is_empty());
+    }
+
+    #[test]
+    fn run_rustymilk_cli_help_command_shows_usage() {
+        let result = run_rustymilk_cli(&["help".to_string()]);
+        assert_eq!(result.code, 0);
+        assert!(result.stdout.contains("usage"));
+    }
+
+    #[test]
+    fn run_rustymilk_cli_invalid_command_shows_usage() {
+        let result = run_rustymilk_cli(&["badcommand".to_string()]);
+        assert_eq!(result.code, 2);
+        assert!(result.stderr.contains("usage"));
+    }
 }

crates/rustymilk-cli/src/lib.rs

@@ -377,6 +377,7 @@ fn create_rustymilk_scope(
     scope
 }
 
+#[allow(clippy::too_many_arguments)]
 fn update_rustymilk_scope_audio(
     scope: &mut BTreeMap<String, RustyMilkValue>,
     time_seconds: f64,
@@ -593,6 +594,7 @@ pub fn rustymilk_frame_from_source(
     rustymilk_frame_from_source_with_audio(source, time_seconds, bass, mid, treble, &[], &[])
 }
 
+#[allow(clippy::too_many_arguments)]
 fn build_rustymilk_frame_from_scope(
     source: &str,
     preset_document: &RustyMilkPresetDocument,
@@ -686,6 +688,7 @@ fn build_rustymilk_frame_from_scope(
     }
 }
 
+#[allow(clippy::too_many_arguments)]
 fn build_rustymilk_frame_from_runtime_scope(
     source: &str,
     preset_document: &mut RustyMilkPresetDocument,
@@ -796,6 +799,7 @@ pub fn rustymilk_frame_from_source_with_audio(
     )
 }
 
+#[allow(clippy::too_many_arguments)]
 pub fn rustymilk_frame_from_source_with_audio_and_input(
     source: &str,
     time_seconds: f64,
@@ -870,6 +874,7 @@ pub fn rustymilk_frame_set_from_source_with_audio(
     )
 }
 
+#[allow(clippy::too_many_arguments)]
 pub fn rustymilk_frame_set_from_source_with_audio_and_input(
     source: &str,
     time_seconds: f64,
@@ -980,6 +985,7 @@ impl RustyMilkRuntime {
         self.render_source_with_audio(source, time_seconds, bass, mid, treble, &[], &[])
     }
 
+   #[allow(clippy::too_many_arguments)]
     pub fn render_source_with_audio(
         &mut self,
         source: &str,
@@ -1002,6 +1008,7 @@ impl RustyMilkRuntime {
         )
     }
 
+    #[allow(clippy::too_many_arguments)]
     pub fn render_source_with_audio_and_input(
         &mut self,
         source: &str,
@@ -1100,6 +1107,7 @@ impl RustyMilkFrameSetRuntime {
         self.render_source_with_audio(source, time_seconds, bass, mid, treble, &[], &[])
     }
 
+    #[allow(clippy::too_many_arguments)]
     pub fn render_source_with_audio(
         &mut self,
         source: &str,
@@ -1122,6 +1130,7 @@ impl RustyMilkFrameSetRuntime {
         )
     }
 
+    #[allow(clippy::too_many_arguments)]
     pub fn render_source_with_audio_and_input(
         &mut self,
         source: &str,
@@ -3028,6 +3037,7 @@ pub fn create_rustymilk_waveform_vertices(
     vertices
 }
 
+#[allow(clippy::too_many_arguments)]
 fn create_rustymilk_frame_primitives(
     preset: &RustyMilkPresetDocument,
     frame_scope: &BTreeMap<String, RustyMilkValue>,
@@ -3300,6 +3310,7 @@ fn create_rustymilk_frame_textured_primitives(
     primitives
 }
 
+#[allow(clippy::too_many_arguments)]
 fn create_rustymilk_frame_primitives_and_textures_stateful(
     preset: &mut RustyMilkPresetDocument,
     frame_scope: &mut BTreeMap<String, RustyMilkValue>,
@@ -3818,7 +3829,7 @@ fn collect_q_registers_from_text(text: &str, registers: &mut Vec<String>) {
     let chars = text.chars().collect::<Vec<_>>();
     let mut index = 0usize;
     while index < chars.len() {
-        if chars[index].to_ascii_lowercase() != 'q' {
+        if !chars[index].eq_ignore_ascii_case(&'q') {
             index += 1;
             continue;
         }
@@ -4130,8 +4141,7 @@ fn unwrap_rustymilk_shader_body(source: &str) -> String {
 fn normalize_simple_rustymilk_conditional_return(source: &str) -> String {
     let unwrapped = unwrap_rustymilk_shader_body(source);
     let compact = unwrapped
-        .replace('{', " ")
-        .replace('}', " ")
+        .replace(['{', '}'], " ")
         .split_whitespace()
         .collect::<Vec<_>>()
         .join(" ");
@@ -4311,9 +4321,7 @@ fn split_rustymilk_shader_declaration(statement: &str) -> Option<(&str, &str, &s
             continue;
         };
         let rest = rest.trim_start();
-        let Some((name, expression)) = rest.split_once('=') else {
-            return None;
-        };
+        let (name, expression) = rest.split_once('=')?;
         let name = name.trim();
         if !name
             .chars()
@@ -6917,4 +6925,7 @@ comp_shader_2=ret = vec3(shifted, energy * bass_att);
             vec!["comp_shader".to_string()]
         );
     }
+
+    // TEST_BLOCK_START
+    // TEST_BLOCK_END
 }