services/galexie: add integration tests for S3 storage.

Author: overcat

.github/workflows/galexie-release.yml

@@ -1,4 +1,4 @@
-name: Galexie Release 
+name: Galexie Release
 
 on:
   push:
@@ -16,6 +16,7 @@ jobs:
       # this is the multi-arch index sha, get it by 'docker buildx imagetools inspect stellar/quickstart:testing'
       GALEXIE_INTEGRATION_TESTS_QUICKSTART_IMAGE: docker.io/stellar/quickstart:testing@sha256:5333ec87069efd7bb61f6654a801dc093bf0aad91f43a5ba84806d3efe4a6322
       GALEXIE_INTEGRATION_TESTS_QUICKSTART_IMAGE_PULL: "false"
+      GALEXIE_INTEGRATION_TESTS_LOCALSTACK_IMAGE_PULL: "false"
       STELLAR_CORE_VERSION: 22.3.0-2485.e643061a4.focal
     steps:
       - name: Set VERSION
@@ -29,6 +30,11 @@ jobs:
         shell: bash
         run: |
           docker pull "$GALEXIE_INTEGRATION_TESTS_QUICKSTART_IMAGE"
+
+      - name: Pull LocalStack image
+        shell: bash
+        run: docker pull localstack/localstack:latest
+
       - name: Install captive core
         run: |
           # Workaround for https://github.com/actions/virtual-environments/issues/5245,
@@ -42,8 +48,11 @@ jobs:
           sudo apt-get update && sudo apt-get install -y stellar-core="$STELLAR_CORE_VERSION"
           echo "Using stellar core version $(stellar-core version)"
 
-      - name: Run tests 
-        run: go test -v -race -run TestGalexieTestSuite ./services/galexie/...
+      - name: Run tests - GCS integration
+        run: go test -v -race -run TestGalexieGCSTestSuite ./services/galexie/...
+
+      - name: Run tests - S3 integration
+        run: go test -v -race -run TestGalexieS3TestSuite ./services/galexie/...
 
       - name: Build docker
         run: make -C services/galexie docker-build

.github/workflows/galexie.yml

@@ -7,8 +7,11 @@ on:
 
 jobs:
   galexie:
-    name: Test
+    name: Test ${{ matrix.storage_type }} integration
     runs-on: ubuntu-22.04
+    strategy:
+      matrix:
+        storage_type: [ GCS, S3 ]
     env:
       CAPTIVE_CORE_DEBIAN_PKG_VERSION: 22.3.0-2485.e643061a4.focal
       GALEXIE_INTEGRATION_TESTS_ENABLED: "true"
@@ -17,6 +20,7 @@ jobs:
       # this is the multi-arch index sha, get it by 'docker buildx imagetools inspect stellar/quickstart:testing'
       GALEXIE_INTEGRATION_TESTS_QUICKSTART_IMAGE: docker.io/stellar/quickstart:testing@sha256:5333ec87069efd7bb61f6654a801dc093bf0aad91f43a5ba84806d3efe4a6322
       GALEXIE_INTEGRATION_TESTS_QUICKSTART_IMAGE_PULL: "false"
+      GALEXIE_INTEGRATION_TESTS_LOCALSTACK_IMAGE_PULL: "false"
     steps:
       - name: Install captive core
         run: |
@@ -36,10 +40,16 @@ jobs:
         run: |
           docker pull "$GALEXIE_INTEGRATION_TESTS_QUICKSTART_IMAGE"
 
+      - name: Pull LocalStack image (for S3)
+        if: ${{ matrix.storage_type == 'S3' }}
+        shell: bash
+        run: docker pull localstack/localstack:latest
+
       - uses: actions/checkout@v3
         with:
           # For pull requests, build and test the PR head not a merge of the PR with the destination.
-          ref:  ${{ github.event.pull_request.head.sha || github.ref }}
-          
-      - name: Run test
-        run: go test -v -race -run TestGalexieTestSuite ./services/galexie/... 
+          ref: ${{ github.event.pull_request.head.sha || github.ref }}
+
+      - name: Run tests - ${{ matrix.storage_type }} integration
+        run: |
+          go test -v -race -run "TestGalexie${{ matrix.storage_type }}TestSuite" ./services/galexie/...

services/galexie/DEVELOPER_GUIDE.md

@@ -65,7 +65,8 @@ Optional, can override the version of quickstart used to run standalone stellar
 Note, the version of stellar core in `GALEXIE_INTEGRATION_TESTS_QUICKSTART_IMAGE` and `GALEXIE_INTEGRATION_TESTS_CAPTIVE_CORE_BIN` needs to be on the same major rev or the captive core process may not be able to join or parse ledger meta from the `local` network created by `GALEXIE_INTEGRATION_TESTS_QUICKSTART_IMAGE`
 
 ```
-$ GALEXIE_INTEGRATION_TESTS_ENABLED=true go test -v -race -run TestGalexieTestSuite ./services/galexie/...
+$ GALEXIE_INTEGRATION_TESTS_ENABLED=true go test -v -race -run TestGalexieGCSTestSuite ./services/galexie/...
+$ GALEXIE_INTEGRATION_TESTS_ENABLED=true go test -v -race -run TestGalexieS3TestSuite ./services/galexie/...
 ```
 
 ## Adding support for a new storage type