add unit test cases.

Author: overcat

support/datastore/gcs_test.go

@@ -178,6 +178,33 @@ func TestGCSPutFileIfNotExists(t *testing.T) {
 	require.Equal(t, map[string]string(nil), metadata)
 }
 
+func TestGCSGetFileLastModified(t *testing.T) {
+	server := fakestorage.NewServer([]fakestorage.Object{})
+	defer server.Stop()
+	server.CreateBucketWithOpts(fakestorage.CreateBucketOpts{
+		Name:                  "test-bucket",
+		VersioningEnabled:     false,
+		DefaultEventBasedHold: false,
+	})
+
+	store, err := FromGCSClient(context.Background(), server.Client(), "test-bucket/objects/testnet", DataStoreSchema{})
+	require.NoError(t, err)
+	t.Cleanup(func() {
+		require.NoError(t, store.Close())
+	})
+
+	content := []byte("inside the file")
+	writerTo := &writerToRecorder{
+		WriterTo: bytes.NewReader(content),
+	}
+	err = store.PutFile(context.Background(), "file.txt", writerTo, nil)
+	require.NoError(t, err)
+
+	lastModified, err := store.GetFileLastModified(context.Background(), "file.txt")
+	require.NoError(t, err)
+	require.NotZero(t, lastModified)
+}
+
 func TestGCSPutFileWithMetadata(t *testing.T) {
 	server := fakestorage.NewServer([]fakestorage.Object{})
 	defer server.Stop()

support/datastore/s3_datastore_test.go

@@ -11,6 +11,7 @@ import (
 	"strings"
 	"sync"
 	"testing"
+	"time"
 
 	"github.com/aws/aws-sdk-go-v2/aws"
 	"github.com/aws/aws-sdk-go-v2/config"
@@ -21,9 +22,10 @@ import (
 
 // mockS3Object stores object data and metadata within the mock server.
 type mockS3Object struct {
-	body     []byte
-	metadata map[string]string
-	crc32c   string
+	body         []byte
+	metadata     map[string]string
+	crc32c       string
+	lastModified time.Time
 }
 
 // mockS3Server is our mock S3 server, holding an in-memory "bucket".
@@ -117,7 +119,12 @@ func (s *mockS3Server) handlePutRequest(w http.ResponseWriter, r *http.Request,
 
 	metadata := s.extractMetadata(r.Header)
 	crc32c := r.Header.Get("x-amz-checksum-crc32c")
-	s.objects[key] = mockS3Object{body: body, metadata: metadata, crc32c: crc32c}
+	s.objects[key] = mockS3Object{
+		body:         body,
+		metadata:     metadata,
+		crc32c:       crc32c,
+		lastModified: time.Now(),
+	}
 	w.WriteHeader(http.StatusOK)
 }
 
@@ -129,6 +136,9 @@ func (s *mockS3Server) setObjectHeaders(w http.ResponseWriter, obj mockS3Object)
 	if obj.crc32c != "" {
 		w.Header().Set("x-amz-checksum-crc32c", obj.crc32c)
 	}
+	if !obj.lastModified.IsZero() {
+		w.Header().Set("Last-Modified", obj.lastModified.UTC().Format(http.TimeFormat))
+	}
 }
 
 func (s *mockS3Server) writeS3NoSuchKeyError(w http.ResponseWriter) {
@@ -157,6 +167,10 @@ func setupTestS3DataStore(t *testing.T, ctx context.Context, bucketPath string,
 	}
 	// Initialize the mock server with provided objects.
 	for key, obj := range initObjects {
+		// Ensure lastModified is set if not already set
+		if obj.lastModified.IsZero() {
+			obj.lastModified = time.Now()
+		}
 		mockServer.objects[key] = obj
 	}
 	server := httptest.NewServer(mockServer)
@@ -255,6 +269,20 @@ func TestS3PutFile(t *testing.T) {
 	require.Equal(t, map[string]string(nil), metadata)
 }
 
+func TestS3GetFileLastModified(t *testing.T) {
+	ctx := context.Background()
+	store, teardown := setupTestS3DataStore(t, ctx, "test-bucket/objects/testnet", map[string]mockS3Object{})
+	defer teardown()
+
+	content := []byte("inside the file")
+	err := store.PutFile(ctx, "file.txt", bytes.NewReader(content), nil)
+	require.NoError(t, err)
+
+	lastModified, err := store.GetFileLastModified(context.Background(), "file.txt")
+	require.NoError(t, err)
+	require.NotZero(t, lastModified)
+}
+
 func TestS3PutFileIfNotExists(t *testing.T) {
 	ctx := context.Background()
 	store, teardown := setupTestS3DataStore(t, ctx, "test-bucket/objects/testnet", map[string]mockS3Object{})
@@ -424,9 +452,10 @@ func TestS3GetFileValidatesCRC32C(t *testing.T) {
 	ctx := context.Background()
 	store, teardown := setupTestS3DataStore(t, ctx, "test-bucket/objects/testnet", map[string]mockS3Object{
 		"objects/testnet/file.txt": {
-			body:     []byte("hello"),
-			metadata: map[string]string{},
-			crc32c:   "VLn+tw==", // invalid CRC32C for the content
+			body:         []byte("hello"),
+			metadata:     map[string]string{},
+			crc32c:       "VLn+tw==", // invalid CRC32C for the content
+			lastModified: time.Now(),
 		}})
 	defer teardown()