fix: memory leak in stream operations

Vladimir Sokolovskiy · Vladimir Sokolovskiy · commit b9255bf4202e · 2025-07-09T17:05:31.000+05:00
diff --git a/clients/horizonclient/client.go b/clients/horizonclient/client.go
@@ -158,12 +158,12 @@ func (c *Client) stream(
 		if err != nil {
 			return errors.Wrap(err, "error sending HTTP request")
 		}
+		defer resp.Body.Close()
 
 		// Expected statusCode are 200-299
 		if !(resp.StatusCode >= 200 && resp.StatusCode < 300) {
 			return fmt.Errorf("got bad HTTP status code %d", resp.StatusCode)
 		}
-		defer resp.Body.Close()
 
 		reader := bufio.NewReader(resp.Body)
 

Original file line number	Diff line number	Diff line change
`@@ -158,12 +158,12 @@ func (c *Client) stream(`
`158`	`158`	`if err != nil {`
`159`	`159`	`return errors.Wrap(err, "error sending HTTP request")`
`160`	`160`	`}`
	`161`	`+ defer resp.Body.Close()`
`161`	`162`
`162`	`163`	`// Expected statusCode are 200-299`
`163`	`164`	`if !(resp.StatusCode >= 200 && resp.StatusCode < 300) {`
`164`	`165`	`return fmt.Errorf("got bad HTTP status code %d", resp.StatusCode)`
`165`	`166`	`}`
`166`		`- defer resp.Body.Close()`
`167`	`167`
`168`	`168`	`reader := bufio.NewReader(resp.Body)`
`169`	`169`